Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

tch on the current head This no longer applies, but it's in "Needs review" status in the Commitfest. Could you please post a rebased version? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make change

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

GE’ was here WAIT_EVENT_LOGICAL_SYNC_STATE_CHANGE, ^ -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] The case for removing replacement selection sort

it to CF 1. This breaks the documentation build, because doc/src/sgml/release-9.6.sgml still contains but you removed that id. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] WAL logging problem in 9.4.3?

of HEAP_INSERT_SKIP_WAL but hasn't removed that reference to it. I'm not sure what happened. Is it possible that your patch was not created by diffing against master? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Getting error message with latest PG source on Windows.

because it does not (and can not) correspond to any attribute in use. It seems like we need to do that. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Getting error message with latest PG source on Windows.

On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> I am getting the following error message when trying to build latest >> PG source on Wind

Re: [HACKERS] More flexible LDAP auth search filters?

On Wed, Sep 13, 2017 at 1:55 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/11/17 23:58, Thomas Munro wrote: >> Sounds good. Here it is with $username. It's nice not to have to >> escape any characters in URLs. I suppose more keywords could be

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

ng to do no > database roundtrips. Hi Elvis, FYI the recovery test 001_stream_rep.pl fails with this patch applied. You can see that if you configure with --enable-tap-tests, build and then cd into src/test/recovery and "make check". -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] Log LDAP "diagnostic messages"?

Protocol error >>> DETAIL: LDAP diagnostics: unsupported extended operation. >>> >> +1, pretty neat. Here is a new version adopting Alvaro's wording. I'll set this back to "Needs review" status. -- Thomas Munro http://www.enterprisedb.com ldap-diagn

Re: [HACKERS] new function for tsquery creartion

t;Poogle" (kidding!) ... well I'm not sure, but I feel like it deserves a proper name. websearch_to_tsquery()? I see that your AROUND(n) is an undocumented Google search syntax. That's a good trick to know. Please send a rebased version of the patch for people to review and test as that

Re: [HACKERS] Cached plans and statement generalization

bmitted this patch for the Autum commitfest. The patch didn't survive the Summer bitrotfest. Could you please rebase it? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postg

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

ecified name does not exist. > + > + > + > > I understand the --drop-slot part. But I don't understand what it means > to ignore a missing replication slot when running --start. Also "--start" breaks the documentation build (missing slash on the closing tag). -- Thomas

Re: [HACKERS] Automatic testing of patches in commit fest

On Mon, Sep 11, 2017 at 11:40 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > Thomas Munro has hacked up a prototype of application testing > automatically if patches submitted apply and build: > http://commitfest.cputube.org/ > > I would recommend have a look at

Re: [HACKERS] Automatic testing of patches in commit fest

to ask for the build ID of the latest build for that branch. For now you have to note the Commitfest entry ID, and then when find the corresponding branch (ie commitfest/14/1234) on the page it dumps you on. It would be nice to fix that. -- Thomas Munro http://www.enterprisedb.com -- Sent vi

Re: [HACKERS] Automatic testing of patches in commit fest

that's cfbot's fault, but if we were to nail down the acceptable formats then it'd become your fault if it didn't understand your patch :-D -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: htt

Re: [HACKERS] Supporting huge pages on Windows

On Thu, Aug 17, 2017 at 2:11 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Apr 12, 2017 at 7:08 PM, Tsunakawa, Takayuki > <tsunakawa.ta...@jp.fujitsu.com> wrote: >> Oh, I got it now. Thanks. The revised patch is attached. The only >> modifie

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

quot; badge take you there directly... Eventually I'll also teach it how to dump a backtrace out of gdb the tests leave a smouldering core. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Automatic testing of patches in commit fest

legitimate complaint. The rejected hunk is trying to replace this line: ! return exec_simple_check_node((Node *) ((ArrayCoerceExpr *) node)->arg); But you removed exec_simple_check_node in 00418c61244138bd8ac2de58076a1d0dd4f539f3, so this 02 patch needs to be rebased. > Also, at this point th

Re: [HACKERS] Automatic testing of patches in commit fest

autious and over time we can revise it.) -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Causal reads take II

On Thu, Aug 10, 2017 at 2:02 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > Rebased after conflicting commit 030273b7. Now using format-patch > with a commit message to keep track of review/discussion history. TAP test 006_logical_decoding.pl failed with that version.

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

.10.0-229.11.1.el7.x86_64 -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

On Tue, Sep 26, 2017 at 9:57 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> On Tue, Sep 26, 2017 at 9:13 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Pushed with that change; we'll soon see what the buildfarm thinks. > > Hmm. One failu

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

On Tue, Sep 26, 2017 at 10:12 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> I think the problem here is that posix_fallocate() doesn't set errno. > > Huh. So the fact that it worked for me is likely because glibc

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

vide a fallback for posix_fallocate() but let ENOTSUPP escape from fallocate(). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

On Thu, Aug 17, 2017 at 11:39 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Jun 29, 2017 at 12:24 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> fallocate-v5.patch > > Added to commitfest so we don't lose track of this. Rebase

Re: [HACKERS] Log LDAP "diagnostic messages"?

ll addition to your TAP test which exercises the non-NULL code path because slapd rejects TLS by default with a diagnostic message. I'm not sure if this is worth adding, since it doesn't actually verify that the code path is reached (though you can see that it is from the logs). -- Thomas M

Re: [HACKERS] Causal reads take II

> segment 00010020, offset 10092544 Hi Dmitry, Thanks for testing. Yeah, it looks like the patch may be corrupting the WAL stream in some case that I didn't hit in my own testing procedure. I will try to reproduce these failures. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A design for amcheck heapam verification

ng, rather than 'init'. 'init' has connotations of being the second phase in an allocate-and-init pattern for me. Then bloom_filt_make() would be trivially implemented on top of bloom_estimate() and bloom_init(), and bloom_init() could be used directly in DSM, DSA, traditional shmem without having t

Re: [HACKERS] [sqlsmith] stuck spinlock in pg_stat_get_wal_receiver after OOM

pstrdup()? The buffers could be statically sized with NAMEDATALEN and MAXCONNINFO. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

d POSIX itself *does* > list EINTR, so I'm hesitant to muck with that. Ah, it all makes sense now that I see the fallback strategy section of the posix_fallocate() man page. I was unaware that there were kernel releases that had the syscall but lacked support in tmpfs. Thanks for te

Re: [HACKERS] SERIALIZABLE with parallel query

s way your test case behaves the same as non-parallel mode. > I will continue my review on the latest patch and share any updates. Thanks! -- Thomas Munro http://www.enterprisedb.com ssi-parallel-v8.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Parallel Hash take II

ing of the > topic is very deliberate and high level, which suggests that ours > should be, too. Very interesting and certainly relevant (the parts I've read so far), though we don't have multiple consumers. Multiplexing one thread so that it is both a consumer and a producer is an

[HACKERS] MCXT_ALLOC_NO_OOM -> DSA_ALLOC_NO_OOM in dsa.c

Hi hackers, I spotted a (harmless) thinko in dsa.c. Please see attached. -- Thomas Munro http://www.enterprisedb.com dsa-alloc-no-oom.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] POC: Sharing record typmods between backends

On Wed, Aug 23, 2017 at 11:58 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Aug 23, 2017 at 5:46 PM, Andres Freund <and...@anarazel.de> wrote: >> Notes for possible followup commits of the dshash API: >> - nontrivial portions of dsahash are essenti

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

GNU_SOURCE -c -o guc.o guc.c guc.c:3309:3: error: ‘SSL_LIBRARY’ undeclared here (not in a function) SSL_LIBRARY, ^~~ I guess it should have a fallback definition, though I don't know what it should be. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (

Re: [HACKERS] Parallel Hash take II

memset to overwrite atomics when loading a new batch. This worked on modern systems but would of course fail when using emulated atomics. Fixed in the attached. In the process I discovered that initialising and clearing large hash tables this way is quite a lot slower than memset on my machine under sim

Re: [HACKERS] POC: Sharing record typmods between backends

res Freund <and...@anarazel.de> wrote: > On 2017-08-21 11:02:52 +1200, Thomas Munro wrote: >> 2. Andres didn't like what I did to DecrTupleDescRefCount, namely >> allowing to run when there is no ResourceOwner. I now see that this >> is probably an indication of a different pr

Re: [HACKERS] Secondary index access optimizations

turn true; > +} > + I'm less sure about this part. It seems like a slippery slope. A couple of regression test failures: inherit ... FAILED rowsecurity ... FAILED 2 of 179 tests failed. I didn't try to unders

Re: [HACKERS] Protect syscache from bloating with negative cache entries

483 at postmaster.c:4029 frame #18: 0x00010edeb785 postgres`ServerLoop + 597 at postmaster.c:1753 frame #19: 0x00010ede8f71 postgres`PostmasterMain(argc=8, argv=0x7fe271403860) + 5553 at postmaster.c:1361 frame #20: 0x00010ed0ccd9 postgres`main(argc=8, argv=0x7fe271403860) + 761

Re: [HACKERS] Parallel Hash take II

On Sat, Sep 2, 2017 at 5:13 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Aug 31, 2017 at 8:53 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Check out ExecReScanGather(): it shuts down and waits for all workers >> to complet

Re: [HACKERS] Optional message to user when terminating/cancelling backend

builds because commit 81c5e46c490e just stole your OIDs: make[3]: Entering directory `/home/travis/build/postgresql-cfbot/postgresql/src/backend/catalog' cd ../../../src/include/catalog && '/usr/bin/perl' ./duplicate_oids 772 972 make[3]: *** [postgres.bki] Error 1 -- Thomas Munro http

Re: [HACKERS] memory fields from getrusage()

for > macOS. That should cover all platforms that I could find.(*) Apparently ru_maxrss is in *pages* on Solaris-derived systems: https://illumos.org/man/3c/getrusage AIX seems to be like Linux and FreeBSD (kilobytes): https://www.ibm.com/support/knowledgecenter/en/ssw_aix_61/com.ibm.aix.basetrf1/ge

Re: [HACKERS] Parallel Hash take II

On Sat, Sep 2, 2017 at 10:45 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Sep 1, 2017 at 6:32 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Sat, Sep 2, 2017 at 5:13 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> On Thu

Re: [HACKERS] A design for amcheck heapam verification

/~oz/hash.html [3] https://www.postgresql.org/message-id/CAEepm%3D3g1_fjJGp38QGv%2B38BC2HHVkzUq6s69nk3mWLgPHqC3A%40mail.gmail.com -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Fix warnings and typo in dshash

1, not UINT64CONST(1). See attached. > I have noticed a typo in dshash.h for which a separate patch is attached. +1 -- Thomas Munro http://www.enterprisedb.com fix_warning.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Surjective functional indexes

after commits 2cd70845 and c6293249. You need to change this: Form_pg_attribute att = RelationGetDescr(indexDesc)->attrs[i]; ... to this: Form_pg_attribute att = TupleDescAttr(RelationGetDescr(indexDesc), i); Thanks! -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-ha

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

^ After commits 2cd70845 and c6293249 you need to change expressions of that format to, for example: node->datumFormat = TupleDescAttr(curr->tts_tupleDescriptor, tc->attNumP1 - 1); Thanks! -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing

Re: [HACKERS] SERIALIZABLE with parallel query

On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > [ssi-parallel-v5.patch] Rebased. -- Thomas Munro http://www.enterprisedb.com ssi-parallel-v6.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] CLUSTER command progress monitor

On Thu, Aug 31, 2017 at 2:12 PM, Tatsuro Yamada <yamada.tats...@lab.ntt.co.jp> wrote: > Any comments or suggestion are welcome. Although this patch updates src/test/regress/expected/rules.out I think perhaps you included the wrong version? That regression test fails for me -- Thomas M

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

date. Maybe one of them would like to commit this? In the meantime its bits have begun to rot. Michael, could you please rebase? Thanks! -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_serial early wraparound

On Wed, Jun 28, 2017 at 1:11 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova >> <lubennikov...@gmail.com>

Re: [HACKERS] A design for amcheck heapam verification

On Wed, Aug 30, 2017 at 1:00 PM, Peter Geoghegan <p...@bowt.ie> wrote: > On Tue, Aug 29, 2017 at 4:34 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Some drive-by comments on the lib patch: > > I was hoping that you'd look at this, since you'll probabl

Re: [HACKERS] oversight in EphemeralNamedRelation support

> relation. I agree. > PFA a simple patch to fix this issue, with updated regression test. Thanks! I suppose we could consider moving the schemaname check into getRTEForSpecialRelationType(), since otherwise both callers need to do that (and as you discovered, one forgot). -- Thomas Munro http://w

[HACKERS] Continuous integration on Windows?

). I wonder... has anyone here with Microsoft know-how ever tried to produce an appveyor.yml file that would do a MSVC build and check-world? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Parallel Hash take II

On Tue, Sep 19, 2017 at 8:06 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Sep 14, 2017 at 10:01 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> 3. Gather Merge and Parallel Hash Join may have a deadlock problem. > > [...] > > Thomas

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Sat, Oct 21, 2017 at 8:09 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Oct 17, 2017 at 7:27 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> While testing parallelism work I've wanted to be able to prevent >> gather nodes from running

Re: [HACKERS] Planning counters in pg_stat_statements

On Tue, Nov 7, 2017 at 6:39 PM, Tsunakawa, Takayuki <tsunakawa.ta...@jp.fujitsu.com> wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Thomas Munro >> I have often wanted $SUBJECT and was happy to find that Fujii-san

Re: [HACKERS] LDAP URI decoding bugs

On Sat, Nov 11, 2017 at 8:37 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 11/6/17 23:30, Michael Paquier wrote: >> On Fri, Nov 3, 2017 at 12:57 PM, Thomas Munro >> <thomas.mu...@enterprisedb.com> wrote: >>> 1. If you set up a pg_hba.

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Sun, Nov 12, 2017 at 8:51 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sun, Nov 12, 2017 at 9:18 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> How about parallel_leader_participation = on|off? The attached >> version has it that

Re: [HACKERS] Parallel Hash take II

Hi Andres and Peter, Please see below for inline responses to your feedback. New patch attached. On Wed, Nov 8, 2017 at 10:01 AM, Andres Freund wrote: > +set min_parallel_table_scan_size = 0; > +set parallel_setup_cost = 0; > +-- Make a simple relation with well distributed

Re: [HACKERS] LDAPS

On Sat, Nov 4, 2017 at 2:05 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I've only tested the attached lightly on FreeBSD + OpenLDAP and > don't know if it'll work elsewhere. While rebasing this on top of a nearby changes, I looked into how portable it is. The prev

[HACKERS] LDAPS

elsewhere. Thoughts? -- Thomas Munro http://www.enterprisedb.com ldaps-v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] LDAP URI decoding bugs

to macros.) Please see attached. -- Thomas Munro http://www.enterprisedb.com ldap-fixes.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Secondary index access optimizations

ition-wise join stuff), as far as I can tell in a good way. Can you please double check those changes and post an updated patch? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] [PATCH] Overestimated filter cost and its mitigation

d this project on). + /* Make a temporary clause list for selectivity calcuation */ s/calcuation/calculation/ -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Add ALWAYS DEFERRED option for constraints

home/nico/ws/postgres/src/test/regress/data/constro.data'; -COPY COPY_TBL FROM '@abs_srcdir@/data/constrf.data'; +COPY COPY_TBL FROM '/home/nico/ws/postgres/src/test/regress/data/constrf.data'; -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] Flexible configuration for full-text search

of the patch the binary upgrade test in src/bin/pg_dump/t/002_pg_dump.pl fails for me: # Failed test 'binary_upgrade: dumps ALTER TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1 ...' # at t/002_pg_dump.pl line 6715. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers

Re: [HACKERS] Restricting maximum keep segments by repslots

n't expect your new columns. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Statement-level rollback

h to apply on top of yours to fix that and some small copy/paste errors, if I understood correctly. -- Thomas Munro http://www.enterprisedb.com docs-suggestion.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] ucs_wcwidth vintage

different frozen versions of the Unicode standard in the source tree, and that might affect some proper languages. 樂 [1] http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Fri, Nov 3, 2017 at 2:24 PM, Peter Geoghegan <p...@bowt.ie> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> That way you don't have to opt in to BufFile's >> double buffering and segmentation schemes just to get shared file >> clean-up, if for

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Wed, Nov 1, 2017 at 2:11 PM, Peter Geoghegan <p...@bowt.ie> wrote: > On Tue, Oct 31, 2017 at 5:07 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Another complaint is that perhaps fd.c >> knows too much about buffile.c's business. For example, >

Re: [HACKERS] Parallel Hash take II

On Mon, Oct 30, 2017 at 1:49 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > A couple of stupid things outstanding: > > 1. EXPLAIN ANALYZE for Parallel Hash "actual" shows the complete row > count, which is interesting to know (or not? maybe I sho

[HACKERS] Planning counters in pg_stat_statements

x_%3DDO-Gu-MfPW3VQ4qC7TfVdH2zHmvZfrGv6fQ3D-Tw%40mail.gmail.com -- Thomas Munro http://www.enterprisedb.com pg-stat-statements-planning-v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

[HACKERS] OpenTemporaryFile() vs resowner.c

ResourceOwnerEnlargeXXX() interface is to be able to put it before resource acquisition. The existing OpenTemporaryFile() coding has the same mistake. Please see attached. [1] https://www.postgresql.org/message-id/20171107210155.kuksdd324kgz5oev%40alap3.anarazel.de -- Thomas Munro http

Re: [HACKERS] Parallel Hash take II

in fact this change is probably not needed for my patch set (theory not tested). I will put it in a separate patch as requested by Andres, because it's generally a good idea anyway for the reasons that Robert explained (ie you probably always want to clean up memory last, since it might contain the meta-data/locks/control objects/whatever you'll need to clean up anything else). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parallel Hash take II

act. Do you see a bug? None of this has any impact on whether files are leaked: either SharedFileSet removes the files, or you crash (or take a filesystem snapshot, etc) and RemovePgTempFiles() mops them up at the next clean startup. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] UPDATE of partition key

On Tue, Nov 7, 2017 at 8:03 AM, Robert Haas <robertmh...@gmail.com> wrote: > The changes to trigger.c still make me super-nervous. Hey THOMAS > MUNRO, any chance you could review that part? Looking, but here's one silly thing that jumped out at me while getting started with this patc

Re: [HACKERS] UPDATE of partition key

will > include these changes (also for list_parted) in the upcoming v23 > patch. That looks good. Thanks. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

SockFD, [], [AC_MSG_ERROR([library > 'dns_sd' is required for Bonjour])]) > > fi Hi Luke, It lives in libSystem.dylib (implicitly linked) on macOS, so that would break the build there. We'd need something a bit more conditional, but I don't know what. -- Thomas Munro http://www.enterprise

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

quot;DNSServiceRegister() failed: error code -65537", which might just mean it wants to talk to some daemon I'm not running. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

On Thu, Nov 9, 2017 at 6:27 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> On Thu, Nov 9, 2017 at 5:03 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Is the AC_SEARCH_LIBS configure call needed to make P

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

e native API it's shouting about. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] UPDATE of partition key

On Wed, Nov 8, 2017 at 5:57 PM, Amit Khandekar <amitdkhan...@gmail.com> wrote: > On 8 November 2017 at 07:55, Thomas Munro <thomas.mu...@enterprisedb.com> > wrote: >> On Tue, Nov 7, 2017 at 8:03 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> The c

Re: [HACKERS] LDAPS

On Sat, Nov 4, 2017 at 2:05 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > That > said, I've only tested the attached lightly on FreeBSD + OpenLDAP and > don't know if it'll work elsewhere. Oops, that version's TAP test was a little too dependent on my system's ldap.con

Re: [HACKERS] Continuous integration on Windows?

ht find this: this plaintext-password-in-script-files stuff is intended for use on self-destructing isolated build bot images only and should never be done on a computer you care about.) Hooray! Now I can go and figure out why my Parallel Hash regression test is failing with file permissions problems

Re: [HACKERS] Parallel Hash take II

On Tue, Oct 24, 2017 at 10:10 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > Here is an updated patch set that does that ^. It's a bit hard to understand what's going on with the v21 patch set I posted yesterday because EXPLAIN ANALYZE doesn't tell you anything interesti

Re: [HACKERS] Block level parallel vacuum WIP

h. > > Did you ever find out what the cause of this problem was? I wonder if it might have been the same issue that commit 19de0ab23ccba12567c18640f00b49f01471018d fixed a week or so later. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parallel Hash take II

t the costing shows the partial row estimate used for costing purposes. 2. The BufFileSet's temporary directory gets created even if you don't need it for batches. Duh. 3. I don't have a good query rescan regression query yet. I wish I could write my own query plans to test the executor. -- Thomas Munro http

Re: [HACKERS] Parallel Hash take II

On Tue, Aug 1, 2017 at 9:28 AM, Andres Freund <and...@anarazel.de> wrote: > On 2017-07-26 20:12:56 +1200, Thomas Munro wrote: >> I'll report on performance separately. > > Looking forward to that ;) Here are some experimental results from a Xeon E5-2695 v3 with a ton of R

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

In the newest version I changed that flexible array to tablespaces[8], because 8 should be enough tablespaces for anyone (TM). I don't really believe anyone uses temp_tablespaces for IO load balancing anymore and I hate code like the above. So I think Rushabh should now remove the above-quot

Re: [HACKERS] Causal reads take II

On Sun, Oct 1, 2017 at 10:03 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> I tried few more times, and I've got it two times from four attempts on a >> fresh >> installation (when all instances were on the same machine). But anyway I'll >> try >> to

<    4   5   6   7   8   9