Re: [HACKERS] PATCH: Minor notes in CLUSTER page

2010-05-07 Thread Andy Lester
 nly
 one sentence I think we should add it adjacent to the existing
 sentence discussing remembering the index.  My proposed patch
 attached; thoughts?

As long as there's a pointer to the answer I'm happy.

xoa

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] PATCH: Minor doc addition to CLUSTER page

2010-05-06 Thread Andy Lester
I couldn't figure out how to get rid of the CLUSTER flag on an index.
Once I got the answer from IRC, I wrote this patch to point future users
to the answer.

xoxo,
Andy



-- 
Andy Lester = a...@petdance.com = www.petdance.com = AIM:petdance
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 662de36..7afe72a 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -176,6 +176,15 @@ CREATE TABLE replaceable 
class=parameternewtable/replaceable AS
 temporary file about the same size as the table itself, so peak disk usage
 is about three times the table size instead of twice the table size.
/para
+
+   para
+To remove the internal flag that notes that an index has been clustered,
+use commandALTER TABLE/command.
+programlisting
+ALTER TABLE replaceable class=parametertable/replaceable SET WITHOUT 
CLUSTER;
+/programlisting
+   /para
+
  /refsect1
 
  refsect1

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] PATCH: Minor notes in CLUSTER page

2010-05-06 Thread Andy Lester
I was looking for how to undo a CLUSTER call earlier today.  Nothing on
the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
page.  I figure a pointer to would help the next person in my situation.

xoxo,
Andy



-- 
Andy Lester = a...@petdance.com = www.petdance.com = AIM:petdance
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 662de36..7afe72a 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -176,6 +176,15 @@ CREATE TABLE replaceable 
class=parameternewtable/replaceable AS
 temporary file about the same size as the table itself, so peak disk usage
 is about three times the table size instead of twice the table size.
/para
+
+   para
+To remove the internal flag that notes that an index has been clustered,
+use commandALTER TABLE/command.
+programlisting
+ALTER TABLE replaceable class=parametertable/replaceable SET WITHOUT 
CLUSTER;
+/programlisting
+   /para
+
  /refsect1
 
  refsect1

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester


I've got my git clone set up, a copy of GCC 4.4 (and other compilers)  
at the ready, and am glad to help out on low-level scut work.  Anybody  
need anything done?  splint?  valgrind?  Let me know.


xoxo,
Andy

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] GCC 4.4 compiler warnings

2009-05-01 Thread Andy Lester


On Apr 29, 2009, at 11:32 AM, Tom Lane wrote:

As of CVS HEAD and gcc 4.4.0-3, we seem to be warning-free in a  
standard

build.  I did not try many optional build flags though.



I'm also working on a set of extra-stringent build flags for GCC 4.4.  
The more we can get the compiler to watch for, the better.


--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester

If you're an Emacs person, you fix it in your ~/.emacs file so that
every .c file in the Postgres tree is automatically handled with the
correct mode.  Surely vi apologists can make their editor do the same.



Thanks for your remarkable response.  I will refer to it often for  
months to come.  I think it tells me quite a bit about the Postgres  
world.


--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester


On May 1, 2009, at 2:37 PM, Joshua D. Drake wrote:


Regardless, I
agree with Tom that the idea of having decorators of any kind in  
source

or docs is a bad idea.


Why is it a bad idea?  I don't understand the downside of a line or  
two at the bottom of a source file.




That being said, there is no reason why we can have a section of the
wiki that has .rc files for respective editors and environments that
conform to .Org coding conventions.



I've always found it preferable to have the editors enforce the coding  
standards for us, without relying on the coder do anything on his  
end.  I'd rather that volunteers, especially new volunteers, spend  
their time and brain cycles thinking about code, not messing with  
config files.


xoa

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester

Because it becomes one more maintenance task we don't need.


There should be nothing to maintain, if it's done right.


 The linux kernel is a mess. There are a couple of hundred files  
with inconssistent mode lines. Most have none (and there are  
thousands).


So it sounds like they could benefit from a tool that ensured that  
they would be kept consistent, and so that when it was decided that  
changes needed to be made, the single tool (likely a 20-line Perl  
program) would take care of it.




So we're hardly alone in not doing it the way you're suggesting.



Sure, and I'm sure there are plenty of projects that do use them to  
great effect, most notably Perl 5 and Parrot.  Perl 5 specifically has  
had the mish-mosh of tabs-vs-spaces reduced by the addition of  
modelines.


xoa

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester

Well, a volunteer whose first proposed contribution is a patch to add
modelines to every file in the tree (with the clear subtext that we're
idiots to not have thought of it before)


No subtext at all.  Perhaps the volunteer figured nobody ever bothered  
with it before.




should expect a bit of
push-back.  If he'd phrased it as would this be a good idea? then
I would have reacted differently.



But since he didn't, it's OK to be insulting?

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester

There should be nothing to maintain, if it's done right.


Any line in the source tree will have to get maintained, or why  
would you spend any time writing it?


I meant by hand.



See doc/FAQ_DEV and those specific lines:


I see no such file.  Perhaps it doesn't get exported into the git  
mirror?



Sorry if the push-back has been read as harsh, but I've got the  
(very personal) feeling that to become a contributor to PostgreSQL,  
you *will* have to be able to read this level of criticism back from  
the mail you send.



I'm all for criticism of ideas.  I wish there had been some in Tom's  
original mail.


xoa

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-05-01 Thread Andy Lester


On May 1, 2009, at 3:46 PM, Joshua D. Drake wrote:


See doc/FAQ_DEV and those specific lines:


I see no such file.  Perhaps it doesn't get exported into the git
mirror?


It is actually:

http://wiki.postgresql.org/wiki/Developer_FAQ


I understand that the FAQ is on the wiki.  What I am saying is that my  
git repo does not have doc/FAQ_DEV.  I didn't see it scroll by in the  
CVS repo that I'm rsyncing, either.



--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Andy Lester


On Apr 30, 2009, at 2:27 AM, David Fetter wrote:


Please clean up this code at least to the point where it's
strict-clean, which means putting use strict; right after the
shebang line and not checking it in until it runs that way.



I can take care of this, David.  Shouldn't be too tough.

--
Andy Lester = a...@petdance.com = www.petdance.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Andy Lester


On Apr 30, 2009, at 6:41 AM, Robert Haas wrote:


Please clean up this code at least to the point where it's
strict-clean, which means putting use strict; right after the
shebang line and not checking it in until it runs that way.


And use warnings;, too.



I'll prob'ly come up with a policy file for Perl::Critic and a make  
target for perlcritic.


xoa

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andy Lester


I've got my git clone set up, a copy of GCC 4.4 (and other compilers)  
at the ready, and am glad to help out on low-level scut work.  Anybody  
need anything done?  splint?  valgrind?  Let me know.


xoxo,
Andy

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andy Lester

Getting our Perl into shape would be Really Good(TM). :)



I will, but right now my #1 is getting some vi modelines in place so  
we can all be using the same tab/space settings.


xoxo,
Andy

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Throw some low-level C scutwork at me

2009-04-30 Thread Andy Lester


On Apr 30, 2009, at 4:39 PM, Andrew Dunstan wrote:

I will, but right now my #1 is getting some vi modelines in place  
so we can all be using the same tab/space settings.



Hasn't that been discussed before and rejected? (For one thing,  
plenty of us don't use vi)



For those who do use vi, it enforces proper file formatting for the  
user without having to worry about local settings.


And if you're an Emacs person, you can help figure out what the  
modeline should be for Emacs, and we can get that in there, too.


xoa

--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Keyword list sanity check

2009-04-30 Thread Andy Lester


On Apr 30, 2009, at 2:11 PM, David Fetter wrote:


Here's a patch that gets it to pass perlcritic -4 and still (as far as
I can tell) work.



Tell ya what.  Let me at it and I'll give a larger, more inclusive  
patch.


xoxo,
Andy


--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers