of the patch looks fine.
Thanks
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
, in postgres_fdw case. If this assumption is correct,
we need a mapping between a local ordinary table and a foreign table which
points remote replicated table.
--
Shigeru HANADA
shigeru.han...@gmail.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
Thank for your comments.
2015-05-21 23:11 GMT+09:00 Robert Haas robertmh...@gmail.com:
On Sat, May 16, 2015 at 9:04 AM, Shigeru Hanada
shigeru.han...@gmail.com wrote:
d) All relations must have the same effective user id
This check is done with userid stored in PgFdwRelationInfo, which
via CSP I/F).
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
hope to use sub-plan generation, but we don't have any
concrete use case as of now.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Thanks for the comments.
2015/05/01 22:35、Robert Haas robertmh...@gmail.com のメール:
On Mon, Apr 27, 2015 at 5:07 AM, Shigeru Hanada
shigeru.han...@gmail.com wrote:
2015-04-27 11:00 GMT+09:00 Kouhei Kaigai kai...@ak.jp.nec.com:
Hanada-san, could you adjust your postgres_fdw patch according
(SELECT r.a9, r.a10, r.a11, r.a12 FROM (SELECT tid
a9, bid a10, tbalance a11, filler a12 FROM public.pgbench_tellers) r) r (a1,
a2, a3, a4) WHERE
((l.a1 = r.a2))
(4 rows)
Thoughts?
Regards,
--
Shigeru HANADA
shigeru.han...@gmail.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers
= r.a2))
(4 rows)
Thoughts?
Regards,
--
Shigeru HANADA
shigeru.han...@gmail.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
bms_shift_members is added.
set_deparse_planstate is also changed to pass ps_tlist as namespace for
deparsing.
These chanes seems reasonable, so I mark this patch as “ready for committers”
to hear committers' thoughts.
Regards,
--
Shigeru HANADA
shigeru.han...@gmail.com
--
Sent via
cycles during
planning if that is not for EXPLAIN, but it seems difficult to get a list of
name of relations in ExplainForeignScan() phase, because planning information
has gone away at that time.
--
Shigeru HANADA
shigeru.han...@gmail.com
explain_foreign_join_v2.patch
Description: Binary
.
—
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
2015/03/25 19:09、Kouhei Kaigai kai...@ak.jp.nec.com のメール:
On Wed, Mar 25, 2015 at 3:14 PM, Shigeru HANADA shigeru.han...@gmail.com
wrote:
Or bottom of make_join_rel(). IMO build_join_rel() is responsible for
just building (or searching from a list) a RelOptInfo for given relids
2015/03/25 18:53、Ashutosh Bapat ashutosh.ba...@enterprisedb.com のメール:
On Wed, Mar 25, 2015 at 3:14 PM, Shigeru HANADA shigeru.han...@gmail.com
wrote:
Or bottom of make_join_rel(). IMO build_join_rel() is responsible for just
building (or searching from a list) a RelOptInfo for given
.
Another idea is to pass “found” as parameter to FDW handler, and let FDW to
decide to skip or not. Some of FDWs (and some of CSP?) might want to be
conscious of join combination.
—
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
tables, each is inherited by foreign tables and partitioned with identical join
key, by building a path tree which joins sharded tables first, and then union
those results.
--
Shigeru HANADA
shigeru.han...@gmail.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
some errors like this:
! ERROR: could not find RelOptInfo for given relids
Could you check that?
—
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
information at that timing, just before
set_cheapest. It would not be good I/F if each FDW needs to copy many
code form joinrel.c...
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
Kaigai-san and Ashutosu, whole-row
reference handling and use of get_joinrel_parampathinfo().
2015-03-05 22:00 GMT+09:00 Shigeru Hanada shigeru.han...@gmail.com:
Hi Ashutosh, thanks for the review.
2015-03-04 19:17 GMT+09:00 Ashutosh Bapat ashutosh.ba...@enterprisedb.com
to make the Output item more readable?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
2015-03-04 17:00 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp:
On 2015/03/03 21:34, Shigeru Hanada wrote:
I rebased join push-down patch onto Kaigai-san's Custom/Foreign Join
v6 patch.
Thanks for the work, Hanada-san and KaiGai-san!
Maybe I'm missing something, but did we agree
Shigeru Hanada shigeru.han...@gmail.com:
I rebased join push-down patch onto Kaigai-san's Custom/Foreign Join
v6 patch. I posted some comments to v6 patch in this post:
http://www.postgresql.org/message-id/CAEZqfEcNvjqq-P=jxnw1pb4t9wvpcporcn7g6cc46jgub7d...@mail.gmail.com
Before applying my v3
, ... for each column of
them.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
(SELECT people.id FROM people INNER JOIN
countries ON people.country_id = countries.id LIMIT 3) x;
ERROR: could not open relation with OID 0
Good catch. In my quick trial, removing LIMIT3 avoids this error.
I'll check it right now.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql
Sent: Tuesday, March 03, 2015 6:31 PM
To: Kaigai Kouhei(海外 浩平); Robert Haas
Cc: Tom Lane; pgsql-hackers@postgreSQL.org; Shigeru Hanada
Subject: Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)
The attached version of custom/foreign-join interface patch
fixes up the problem
-Strom Project
KaiGai Kohei kai...@ak.jp.nec.com
--
Shigeru HANADA
foreign_join_v3.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
(gdb) p str
$6 = 0x1d17cf7 foo
Join push-down underlying UPDATE or DELETE requires ctid as its
output, but it seems not fully supported. I'm fixing this issue now.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
that all
interface between core and FDW should be in FdwRoutine, instead of
using hook function. Now I'm writing document about it, and will post
it in a day.
2015-02-19 16:19 GMT+09:00 Shigeru Hanada shigeru.han...@gmail.com:
2015-02-17 10:39 GMT+09:00 Kouhei Kaigai kai...@ak.jp.nec.com:
Let me
because I thought that create_plan_recurse
can be called by core before giving control to FDWs. But I'm not sure
it can be applied to custom scans. I'll recheck that part.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
-way (not only 2-way) joins should be supported in
the first version by construct SELECT SQL by containing source query
in FROM clause as inline views (a.k.a. from clause subquery).
2014-12-26 13:48 GMT+09:00 Shigeru Hanada shigeru.han...@gmail.com:
2014-12-16 1:22 GMT+09:00 Robert Haas robertmh
Project
KaiGai Kohei kai...@ak.jp.nec.com
-Original Message-
From: pgsql-hackers-ow...@postgresql.org
[mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Shigeru Hanada
Sent: Monday, February 16, 2015 1:03 PM
To: Robert Haas
Cc: PostgreSQL-development
Subject: Re: [HACKERS] Join
2014-12-16 0:45 GMT+09:00 Tom Lane t...@sss.pgh.pa.us:
Shigeru Hanada shigeru.han...@gmail.com writes:
I'm working on $SUBJECT and would like to get comments about the
design. Attached patch is for the design below. Note that the patch
requires Kaigai-san's custom foriegn join patch[1
2014-12-16 1:22 GMT+09:00 Robert Haas robertmh...@gmail.com:
On Mon, Dec 15, 2014 at 3:40 AM, Shigeru Hanada
shigeru.han...@gmail.com wrote:
I'm working on $SUBJECT and would like to get comments about the
design. Attached patch is for the design below.
I'm glad you are working on this.
1
subtree.
Regards,
--
Shigeru HANADA
join_pushdown.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I found a minor typo in bgworker.sgml. Patch attached. It should be
applied to 9.4 too.
--
Shigeru HANADA
fix_typo_in_bgworker.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
2014-09-08 8:07 GMT+09:00 Shigeru HANADA shigeru.han...@gmail.com:
(2014/09/04 21:37), Robert Haas wrote: On Wed, Sep 3, 2014 at 5:16 AM,
Probably both the initial cost and final cost calculations should be
delegated to the FDW, but maybe within postgres_fdw, the initial cost
should do only
(2014/09/04 21:37), Robert Haas wrote: On Wed, Sep 3, 2014 at 5:16 AM,
Shigeru Hanada shigeru.han...@gmail.com wrote:
(1) Separate cost estimation phases?
For existing join paths, planner estimates their costs in two phaeses.
In the first phase initial_cost_foo(), here foo is one of
nestloop
be another story.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
is already joined files accessed via foreign tables.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
,
postgresReScanForeignScan needn't to be called in the update pushdown
case. The assertion is a good idea. I'll add it.
Done.
You can find the updated version of the patch at
http://www.postgresql.org/message-id/53fffa50.6020...@lab.ntt.co.jp
Thanks,
Best regards,
Etsuro Fujita
--
Shigeru
AttrNumber max_attr; /* largest attrno of rel */
445 Relids *attr_needed;/* array indexed [min_attr ..
max_attr] */
Good point! Attached is the revised version of the patch.
Thanks,
Best regards,
Etsuro Fujita
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list
-down for SELECT, UPDATE and
DELETE.
2014-08-04 20:30 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp:
(2014/07/30 17:22), Etsuro Fujita wrote:
(2014/07/29 0:58), Robert Haas wrote:
On Fri, Jul 25, 2014 at 3:39 AM, Albe Laurenz
laurenz.a...@wien.gv.at wrote:
Shigeru Hanada wrote
Hi Fujita-san,
Here is a new review result from Eitoku-san.
2014-07-25 16:30 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp:
(2014/07/24 18:30), Shigeru Hanada wrote:
I'm not sure that I understand your question correctly, but the reason for
that is because foreign tables cannot have
a macro to determine the
mode, say IS_SHIPPABLE(foo).
* Comparison of Macros
Comparison against MaxFdwScanFdwPrivateLength and
MinFdwScanFdwPrivateLength should be == instead of = or = to detect
unexpected value. Adding assert macro seems good too.
--
Shigeru HANADA
--
Sent via pgsql-hackers
, you need to modify
expected file of the test.
Nothing to comment on the design and implementation from your
viewpoint any more?
As much as I can tell, the design seems reasonable. After fix for the
small issue above, I'll move the patch status to Ready for
committer.
--
Shigeru HANADA
for committer.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
to have
forward declarations.
* Fix typos being pointed out.
Check. I found some typos and a wording datatype which is not used
in any other place. Please refer the attached patch.
--
Shigeru HANADA
fix_typo_in_v3.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql
leaving this function *on
success* in that function.
(I guess the comment has been copied and pasted from that for
get_remote_estimate().)
+1 for just removing the comment, because header comment clearly
mentions necessity of releasing the PGresult.
--
Shigeru HANADA
--
Sent via pgsql-hackers
, because one
of main purposes of tableoid is determine actual source table in
appended results.
Am I missing the point?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
The attached one is revised one on documentation stuff and contrib/Makefile.
Thanks,
2014-06-16 17:29 GMT+09:00 Shigeru Hanada shigeru.han...@gmail.com:
Kaigai-san,
I've just applied v1 patch, and tried build and install, but I found two
issues:
1) The contrib/ctidscan is not automatically
Fujii-san,
I found the right description in REL9_3_STABLE branch, thanks for
pointing out the commit.
Sorry for noise.
2014-06-18 12:39 GMT+09:00 Fujii Masao masao.fu...@gmail.com:
On Tue, Jun 17, 2014 at 2:11 PM, Shigeru Hanada
shigeru.han...@gmail.com wrote:
Fujii-san,
I agree
-to-face discussion here.
Thanks,
--
NEC OSS Promotion Center / PG-Strom Project
KaiGai Kohei kai...@ak.jp.nec.com
--
KaiGai Kohei kai...@kaigai.gr.jp
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
not backpatch this to 9.3.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers
as a server-specific configuration.
Connection management seems FDW-specific feature to me. How about to
add FDW option, say pool_connection=true|false, to postgres_fdw which
allows per-server configuration?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
: redirecting log output to logging collector process
HINT: Future log output will appear in directory pg_log.
Attached patch fixes this issue. Please apply onto HEAD and 9.4.
--
Shigeru HANADA
fix_worker_spi.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers
,
however, things to do is similar. We may need to revisit the Hanada-san's
proposition in the past.
I can't recall the details soon but the reason I gave up was about
introducing ForiegnJoinPath node, IIRC. I'll revisit the discussion
and my proposal.
--
Shigeru HANADA
--
Sent via pgsql
patch. They should
go into the part-1 patch where the typo introduced.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
to allow that too.
And I've gave up for lack of time, IOW to finish more fundamental
portion of FDW API.
http://www.postgresql.org/message-id/4f39fc1a.7090...@gmail.com
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
as parameters.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
create_customscan_path.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
in the first-cut.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
amount of discussion we could have in this commit
fest, even though Hanada-san volunteered to move the patches into
ready for committer state at the CF-Nov.
I found some cosmetic flaw and .gitignore leak in the patches. Please
see attached a patch for details.
--
Shigeru HANADA
consistency.
Changing data type from compatible one (i.e., int to numeric,
varchar(n) to text), adding CHECK/NOT NULL constraint would be also
possible.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
it is not a child anymore.
So IMO we should determine which ALTER TABLE features are allowed to
foreign tables, and allow them regardless of the recursivity.
Comments?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
(2014/01/27 21:52), Shigeru Hanada wrote:
2014-01-27 Etsuro Fujita fujita.ets...@lab.ntt.co.jp:
While still reviwing this patch, I feel this patch has given enough
consideration to interactions with other commands, but found the following
incorrect? behabior:
postgres=# CREATE TABLE product
2014-01-27 Etsuro Fujita fujita.ets...@lab.ntt.co.jp:
(2014/01/25 11:27), Shigeru Hanada wrote:
Yeah, the consistency is essential for its ease of use. But I'm not sure
that inherited stats ignoring foreign tables is actually useful for query
optimization. What I think about the consistency
the ALTER TABLE simple recursion mechanism (ie ATSimpleRecursion())
should be modified for the ALTER COLUMN SET STORAGE case.
I just wanted to quickly tell you this for you to take time to consider.
Thanks for the review. It must be an oversight, so I'll fix it up soon.
--
Shigeru HANADA
Hi Fujita-san,
Thanks for the review.
2014/1/23 Etsuro Fujita fujita.ets...@lab.ntt.co.jp:
Shigeru Hanada wrote:
Though this would be debatable, in current implementation, constraints
defined on a foreign table (now only NOT NULL and CHECK are supported)
are not enforced during INSERT
on a foreign
tables contains only expressions which have same semantics as remote
side (in practice, built-in and immutable)?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
(not enforcing). Should it also be noted
explicitly?
Thoughts?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Hi all,
2014/1/14 Shigeru Hanada shigeru.han...@gmail.com:
I'd like to revisit this feature.
Attached patch allows a foreign table to be a child of a table. It
also allows foreign tables to have CHECK constraints. These changes
provide us a chance to propagate query load to multiple servers
KaiGai-san,
2013/12/16 KaiGai Kohei kai...@ak.jp.nec.com:
(2013/12/16 14:15), Shigeru Hanada wrote:
(1) ctidscan
Is session_preload_libraries available to enable the feature, like
shared_*** and local_***? According to my trial it works fine like
two similar GUCs.
It shall be available
Hi Kaigai-san,
2013/12/11 Kohei KaiGai kai...@kaigai.gr.jp:
2013/12/10 Shigeru Hanada shigeru.han...@gmail.com:
The patches could be applied cleanly, but I saw a compiler warning
about get_rel_relkind() in foreign.c, but it's minor issue. Please
just add #include of utils/lsyscache.h
what is going on in Custom Scan.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
to be useful for other FDWs. Is it able
to move them into core?
(4) postgres_fdw estimates costs of join by calculating local numbers.
How about to support remote estimation by throwing EXPLALAIN query
when use_remote_estimates = true.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list
2013/11/29 Kohei KaiGai kai...@kaigai.gr.jp:
I merged all the propositions from Jim. Thanks, it made the documentation
quality better. Also, I fixed up cosmetic stuff around whitespace - tab.
I found some typos in documents and comments. Please see attached
patch for detail.
--
Shigeru
Hi Merlin,
2013/11/22 Merlin Moncure mmonc...@gmail.com:
On Thu, Nov 21, 2013 at 6:43 PM, Shigeru Hanada
shigeru.han...@gmail.com wrote:
2013/11/22 Tom Lane t...@sss.pgh.pa.us:
Merlin Moncure mmonc...@gmail.com writes:
On Thu, Nov 21, 2013 at 9:05 AM, Bruce Momjian br...@momjian.us wrote:
I
AS FOREIGN VIEW
(remote query)?
I think it's nice to support executing ad-hoc remote query written in
the syntax which is valid only on remote data source through FDW, and
at the moment dblink interface seems feasible for that purpose.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list
because commit
784e762e886e6f72f548da86a27cd2ead87dbd1c (committed on 2013-11-21)
allows FunctionScan node to have multiple function expression, so Node
* funcexpr in CustomScan should be List *funcitons now.
I'll continue to review by applying patches onto 2013-11-19 HEAD.
--
Shigeru HANADA
is
reasonably sortable.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
is
following the SQL standard's SQL/MED design, which does not do it
like that.
Pass-through mode mentioned in SQL/MED standard might be what he wants.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
node of Append
Currently prepunion.c assumes that children of Append have
RELKIND_RELATION as relkind always, so we need to set relkind of child
RTE explicitly.
Please see attached PoC patch. I'll enhance implementation, tests and
document and submit the patch for the next CF.
Regards,
--
Shigeru
source server.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
whether postgres_fdw should support, but updatable views
have no system column including ctid. So, we need magic identifier,
perhaps it would be set of primary key value(s), to support updating
remote updatable views via foreign tables.
Just a heads up.
--
Shigeru HANADA
--
Sent via pgsql
was specified for an object. With this context,
existing ruleutils would generate expression-strings with proper
names, without any change.
Is this idea acceptable?
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
')
Has OIDs: no
We can use table and column options without quoting (or with quote
of course) in CREATE/ALTER FOREIGN TABLE commands, so this is not a
barrier against choosing no-postfix names.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
capability for building remote
PostgreSQL query.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Feb 14, 2013 at 6:45 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote:
Shigeru Hanada wrote:
Tom Lane wrote:
It ought to be pulling the rows back a few at a time, and
that's not going to work well if multiple scans are sharing the same
connection. (We might be able to dodge
d) use empty String
+1 for a). If users want to determine whether the result was NULL, or
want to use substitute string for NULL result, they can use coalesce
in SELECT clause. Anyway the feature should be documented clearly.
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql
call.
OK, both threshold and initial palloc were fixed correctly.
I'll mark this patch as Ready for committer.
Good work! :-)
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref
?
# using RELS instead of RELATIONS would be better to shorten the name
* +1 for Alvaro's suggestion about avoiding palloc traffic by starting
with 8 elements or so.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
elements or so.
Done.
Not yet. Initial size of srels array is still 1 element.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Dec 18, 2012 at 2:52 AM, Pavel Stehule pavel.steh...@gmail.com wrote:
Attached updated patch
Seems fine. I'll mark this as ready for committer.
Nice work!
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
about pulling up codes for PGRES_TUPLES_OK case in
StoreQueryResult to new static function, say StoreQueryTuple? It
would make StoreQueryResult more similar to PrintQueryResult's style,
and IMO it makes the code more readable.
Regards,
--
Shigeru HANADA
gset_fix.patch
Description: Binary data
.
--
Shigeru HANADA
drop-in-tx.diff
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
, so 4th number in
the result above should be compared to 4th number of not-patched PG?
--
Shigeru HANADA
drop-in-transaction-v3.1.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
VERBOSE was
specified. This would make EXPLAIN output easy to read, even if many
foreign tables are used in a query.
Thoughts?
--
Shigeru HANADA
cursor to avoid possible memory
exhaust on large result set. I switched to single-row processing mode
(it could be said protocol-level cursor), which was added in 9.2,
because it accomplish same task with less SQL calls than cursor.
Regards,
--
Shigeru HANADA
the one more familiar to me at that time. I think that only few
people feel that postgres is shortened name of
postgresql.
How about using postgres_fdw for PG-FDW?
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
, but mentioning it clearly might be better.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
be worth mentioning that it's not
recommended to use postgresql_fdw_validator as validator of a
third-party's FDW to avoid dependency.
Regards,
--
Shigeru HANADA
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
1 - 100 of 289 matches
Mail list logo