Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-06 Thread Robert Haas
On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch wrote: > New patch attached and rebased on HEAD > (8c75ad436f75fc629b61f601ba884c8f9313c9af). I've committed this with some modifications: - I changed the comment for the half_rounded() macros because the one

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-06 Thread Adrian Vondendriesch
Am 06.11.2015 um 17:06 schrieb Robert Haas: > On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch > wrote: >> New patch attached and rebased on HEAD >> (8c75ad436f75fc629b61f601ba884c8f9313c9af). > > I've committed this with some modifications: > > - I changed

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-06 Thread Robert Haas
On Fri, Nov 6, 2015 at 12:44 PM, Adrian Vondendriesch wrote: > Am 06.11.2015 um 17:06 schrieb Robert Haas: >> On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch >> wrote: >>> New patch attached and rebased on HEAD >>>

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-05 Thread Adrian.Vondendriesch
New patch attached and rebased on HEAD (8c75ad436f75fc629b61f601ba884c8f9313c9af). Am 03.11.2015 um 04:06 schrieb Robert Haas: > On Sat, Oct 31, 2015 at 2:25 PM, Julien Rouhaud > wrote: >> I just reviewed your patch, everything looks fine for me. Maybe some >> minor

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-03 Thread Julien Rouhaud
On 03/11/2015 04:06, Robert Haas wrote: > On Sat, Oct 31, 2015 at 2:25 PM, Julien Rouhaud > wrote: >> I just reviewed your patch, everything looks fine for me. Maybe some >> minor cosmetic changes could be made to avoid declaring too many vars, >> but I think a

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-11-02 Thread Robert Haas
On Sat, Oct 31, 2015 at 2:25 PM, Julien Rouhaud wrote: > I just reviewed your patch, everything looks fine for me. Maybe some > minor cosmetic changes could be made to avoid declaring too many vars, > but I think a committer would have a better idea on this, so I mark >

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-10-31 Thread Julien Rouhaud
On 20/09/2015 14:16, Adrian.Vondendriesch wrote: > Hi all, > Hello, > Am 06.04.2015 um 20:52 schrieb Tom Lane: >> "David G. Johnston" writes: >>> I'll let a hacker determine whether this is a bug or a feature >>> request though it is a POLA violation in either case.

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

2015-09-20 Thread Adrian.Vondendriesch
Hi all, Am 06.04.2015 um 20:52 schrieb Tom Lane: > "David G. Johnston" writes: >> I'll let a hacker determine whether this is a bug or a feature request >> though it is a POLA violation in either case. > > I'd say it's a feature request --- a perfectly reasonable