[HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Tom Lane
Back in April we changed EXPLAIN VERBOSE to not dump the internal plan tree anymore, on the grounds that non-hackers didn't want that info and hackers could get it with debug_print_plan and related variables. Well, now that I've tried to do some planner development work relying on debug_print_plan

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Simon Riggs
On Tue, 2008-08-19 at 12:40 -0400, Tom Lane wrote: Back in April we changed EXPLAIN VERBOSE to not dump the internal plan tree anymore, on the grounds that non-hackers didn't want that info and hackers could get it with debug_print_plan and related variables. Well, now that I've tried to do

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread daveg
On Tue, Aug 19, 2008 at 06:33:33PM +0100, Simon Riggs wrote: On Tue, 2008-08-19 at 12:40 -0400, Tom Lane wrote: Back in April we changed EXPLAIN VERBOSE to not dump the internal plan tree anymore, on the grounds that non-hackers didn't want that info and hackers could get it with

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Hannu Krosing
On Tue, 2008-08-19 at 12:40 -0400, Tom Lane wrote: Back in April we changed EXPLAIN VERBOSE to not dump the internal plan tree anymore, on the grounds that non-hackers didn't want that info and hackers could get it with debug_print_plan and related variables. Well, now that I've tried to do

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Tom Lane
Hannu Krosing [EMAIL PROTECTED] writes: what about changing (or adding) values log and notice ? debug_print_plan = log; debug_print_plan = notice; so you could set that on demand ? Well, we could, but it would break existing habits for not much gain. Really this proposal is to make

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Robert Treat
On Tuesday 19 August 2008 12:40:11 Tom Lane wrote: I'd also like to propose making debug_pretty_print default to ON. At least for me, the other formatting is 100% unreadable. Any thoughts on just making it always print that way and getting rid of the GUC? Anyone want to argue they'll be

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread David Fetter
On Tue, Aug 19, 2008 at 10:06:33PM -0400, Robert Treat wrote: On Tuesday 19 August 2008 12:40:11 Tom Lane wrote: I'd also like to propose making debug_pretty_print default to ON. At least for me, the other formatting is 100% unreadable. Any thoughts on just making it always print that way

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Tom Lane
Robert Treat [EMAIL PROTECTED] writes: On Tuesday 19 August 2008 12:40:11 Tom Lane wrote: I'd also like to propose making debug_pretty_print default to ON. At least for me, the other formatting is 100% unreadable. Any thoughts on just making it always print that way and getting rid of the

Re: [HACKERS] Adjusting debug_print_plan to be more useful by default

2008-08-19 Thread Tom Lane
David Fetter [EMAIL PROTECTED] writes: On Tue, Aug 19, 2008 at 10:06:33PM -0400, Robert Treat wrote: Any thoughts on just making it always print that way and getting rid of the GUC? Anyone want to argue they'll be turning this off? I can vaguely imagine somebody wanting to debug the pretty