Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-03-03 Thread Robert Haas
On Thu, Feb 27, 2014 at 8:05 AM, Michael Paquier wrote: > On Wed, Feb 26, 2014 at 5:45 AM, Alvaro Herrera > wrote: >> Robert Haas escribió: >>> On Mon, Feb 24, 2014 at 9:34 AM, Alvaro Herrera >>> wrote: >>> > Yeah, erroring out seems good enough. Particularly if you add a hint >>> > saying "ple

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-27 Thread Michael Paquier
On Wed, Feb 26, 2014 at 5:45 AM, Alvaro Herrera wrote: > Robert Haas escribió: >> On Mon, Feb 24, 2014 at 9:34 AM, Alvaro Herrera >> wrote: >> > Yeah, erroring out seems good enough. Particularly if you add a hint >> > saying "please upgrade the extension". >> >> In past instances where this has

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-25 Thread Alvaro Herrera
Robert Haas escribió: > On Mon, Feb 24, 2014 at 9:34 AM, Alvaro Herrera > wrote: > > Yeah, erroring out seems good enough. Particularly if you add a hint > > saying "please upgrade the extension". > > In past instances where this has come up, we have actually made the > .so backward-compatible.

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-25 Thread Robert Haas
On Mon, Feb 24, 2014 at 9:34 AM, Alvaro Herrera wrote: > Yeah, erroring out seems good enough. Particularly if you add a hint > saying "please upgrade the extension". In past instances where this has come up, we have actually made the .so backward-compatible. See pg_stat_statements in particula

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-25 Thread Greg Stark
On 25 Feb 2014 08:54, "Heikki Linnakangas" wrote: > > > I hope there are no applications relying on pageinspect. It's a very low-level tool. Or if someone has written a nice GUI around it, I'd like to hear about it so that I can start using it :-). > > >> I see more flexibility to keep them as the

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-25 Thread Heikki Linnakangas
On 02/25/2014 06:52 AM, Michael Paquier wrote: On Tue, Feb 25, 2014 at 10:02 AM, Alvaro Herrera wrote: (Not that it's this patch' responsibility to do that.) Definitely a different patch. Don't you think that this would break existing applications? I hope there are no applications relying o

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-24 Thread Michael Paquier
On Tue, Feb 25, 2014 at 10:02 AM, Alvaro Herrera wrote: > While we're messing with this, I wonder if there's any way to have > infomask and infomask2 displayed in hex format rather than plain int > without having to specify that in every query. I'm not well known for > being able to do such conve

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-24 Thread Michael Paquier
On Mon, Feb 24, 2014 at 11:34 PM, Alvaro Herrera wrote: > > Andres Freund escribió: > > On 2014-02-24 17:53:31 +0900, Michael Paquier wrote: > > > On Sun, Feb 23, 2014 at 6:09 AM, Alvaro Herrera > > > wrote: > > > > > > > Michael Paquier escribió: > > > > > Hi all, > > > > > > > > > > Please find

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-24 Thread Alvaro Herrera
While we're messing with this, I wonder if there's any way to have infomask and infomask2 displayed in hex format rather than plain int without having to specify that in every query. I'm not well known for being able to do such conversions off the top of my head ... (Not that it's this patch' res

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-24 Thread Alvaro Herrera
Andres Freund escribió: > On 2014-02-24 17:53:31 +0900, Michael Paquier wrote: > > On Sun, Feb 23, 2014 at 6:09 AM, Alvaro Herrera > > wrote: > > > > > Michael Paquier escribió: > > > > Hi all, > > > > > > > > Please find attached a patch to dump pageinspect to 1.2. This > > > > simply changes pa

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-24 Thread Andres Freund
On 2014-02-24 17:53:31 +0900, Michael Paquier wrote: > On Sun, Feb 23, 2014 at 6:09 AM, Alvaro Herrera > wrote: > > > Michael Paquier escribió: > > > Hi all, > > > > > > Please find attached a patch to dump pageinspect to 1.2. This simply > > > changes page_header to use the new internal datatype

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-24 Thread Michael Paquier
On Sun, Feb 23, 2014 at 6:09 AM, Alvaro Herrera wrote: > Michael Paquier escribió: > > Hi all, > > > > Please find attached a patch to dump pageinspect to 1.2. This simply > > changes page_header to use the new internal datatype pg_lsn instead of > text. > > Uhm. Does this crash if you pg_upgrade

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-22 Thread Alvaro Herrera
Michael Paquier escribió: > Hi all, > > Please find attached a patch to dump pageinspect to 1.2. This simply > changes page_header to use the new internal datatype pg_lsn instead of text. Uhm. Does this crash if you pg_upgrade a server that has 1.1 installed? -- Álvaro Herrera

[HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-22 Thread Michael Paquier
Hi all, Please find attached a patch to dump pageinspect to 1.2. This simply changes page_header to use the new internal datatype pg_lsn instead of text. Regards, -- Michael diff --git a/contrib/pageinspect/Makefile b/contrib/pageinspect/Makefile index 0e267eb..ee78cb2 100644 --- a/contrib/pagei