Re: [HACKERS] Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h

2017-06-22 Thread Robert Haas
On Wed, Jan 11, 2017 at 10:19 PM, Etsuro Fujita wrote: > While working on pushing down more joins/updates to the remote, I noticed > that in contrib/postgres_fdw/postgres_fdw.h the declaration of > get_jointype_name is misplaced in the section of shippable.c. Since

Re: [HACKERS] Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h

2017-01-12 Thread Etsuro Fujita
On 2017/01/12 13:52, Ashutosh Bapat wrote: On Thu, Jan 12, 2017 at 8:49 AM, Etsuro Fujita wrote: While working on pushing down more joins/updates to the remote, I noticed that in contrib/postgres_fdw/postgres_fdw.h the declaration of get_jointype_name is misplaced

Re: [HACKERS] Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h

2017-01-11 Thread Ashutosh Bapat
On Thu, Jan 12, 2017 at 8:49 AM, Etsuro Fujita wrote: > Hi, > > While working on pushing down more joins/updates to the remote, I noticed > that in contrib/postgres_fdw/postgres_fdw.h the declaration of > get_jointype_name is misplaced in the section of shippable.c.

[HACKERS] Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h

2017-01-11 Thread Etsuro Fujita
Hi, While working on pushing down more joins/updates to the remote, I noticed that in contrib/postgres_fdw/postgres_fdw.h the declaration of get_jointype_name is misplaced in the section of shippable.c. Since that function is defined in contrib/postgres_fdw/deparse.c, we should put that