I've looked this version.
The only reservation I have is that when changing the owner of a schema,
the new owner is not always checked. I would suggest to query the new
owner to check that it matches (5, 11, 12), just as you do in 3.
Also, reowning is tested several times (5, 11, 12). I
On 9 July 2013 08:57, Fabien COELHO coe...@cri.ensmp.fr wrote:
I cannot apply the patch, it seems to be truncated:
Hi Fabien,
Please find attached the updated patch.
It seems the only difference between v5 and v6 is probably a newline at the
end (Line 291 was the last line), in fact meld
Hi Fabien,
Please find attached the updated patch.
It seems the only difference between v5 and v6 is probably a newline at the
end (Line 291 was the last line), in fact meld doesn't even show anything.
I'll try to be more careful though.
git reset --hard HEAD
git pull
patch -p1
PFA an updated patch:
- Renamed ROLEs as per new feedback (although the previous naming was also
as per an earlier feedback)
- Merged tests into namespace
I do not see any difference with v4. I guess you sent the earlier version.
--
Fabien.
--
Sent via pgsql-hackers mailing list
PFA an updated patch:
- Renamed ROLEs as per new feedback (although the previous naming was also
as per an earlier feedback)
- Merged tests into namespace
I do not see any difference with v4. I guess you sent the earlier version.
Sorry, wrong thread, this apply to SEQUENCE tests.
--
Hello Robins,
PFA an updated patch:
- Renamed ROLEs as per new feedback (although the previous naming was also
as per an earlier feedback)
- Merged tests into namespace
I cannot apply the patch, it seems to be truncated:
sh git apply ../regress_schema_v5.patch
### warnings about trailing
Hi Fabien,
Appreciate you being able to check right away.
Seems something went wrong with these set of patches... Would check again
and resubmit them soon.
--
Robins Tharakan
On 9 July 2013 10:57, Fabien COELHO coe...@cri.ensmp.fr wrote:
Hello Robins,
PFA an updated patch:
- Renamed
On 3 July 2013 10:19, Robert Haas robertmh...@gmail.com wrote:
In this particular case, I think that adding a new set of tests isn't
the right thing anyway. Schemas are also known as namespaces, and the
existing namespace test is where related test cases live. Add these
tests there instead.
On Wed, May 8, 2013 at 9:19 PM, Robins Tharakan thara...@gmail.com wrote:
Please find attached an updated patch with the said changes.
I'll try to update the other patches (if they pertain to this feedback) and
update on their respective threads (as well as on Commitfest).
This patch updates
Please find attached an updated patch with the said changes. I'll try to
update the other patches (if they pertain to this feedback) and update
on their respective threads (as well as on Commitfest).
Ok, this new version addresses my questions.
The patch works for me (nothing to compile,
Dear Robins,
Here is an updated patch that uses different schema / role names for
different tests (as per commitfest site feedback).
Short review about this version of the patch:
This patch work for me.
This test is a good thing and allows schema to be thoroughly tested,
including corner
Hi,
Please find attached an updated patch with the said changes.
I'll try to update the other patches (if they pertain to this feedback) and
update on their respective threads (as well as on Commitfest).
--
Robins Tharakan
On 8 May 2013 13:01, Fabien COELHO coe...@cri.ensmp.fr wrote:
Dear
Hi,
Here is an updated patch that uses different schema / role names for
different tests (as per commitfest site feedback).
--
Robins Tharakan
On 18 March 2013 17:16, robins thara...@gmail.com wrote:
Hi,
Attached is an updated patch that uses better schema / role names.
--
Robins
On Tue, May 7, 2013 at 7:26 PM, Robins Tharakan thara...@gmail.com wrote:
Here is an updated patch that uses different schema / role names for
different tests (as per commitfest site feedback).
I'm not sure what's going on here. Reviews are to be posted to
pgsql-hackers, and then linked from
Completely agree. Although the poster was kind enough to intimate me by
email about his update there, but was wondering that if he hadn't, I
wouldnt' have dreamt that there is a feedback on the site, two months down
the line.
--
Robins Tharakan
On 8 May 2013 09:13, Robert Haas
Reviews are to be posted to pgsql-hackers, and then linked from the
CommitFest site. Putting reviews only on the CommitFest site is bad
practice.
Indeed. Sorry, shame on me!
I had not the original mail in my mailbox because I deleted it, I did not
want to create a new thread because this
Thanks Alvaro.
Since the tests were running fine, I didn't bother with elaborate names,
but since you're concerned guess I'll make that change and re-submit.
And yes, I've already submitted (to Commitfest) another patch related to
regression tests for SEQUENCE.
Would submit the SCHEMA patch once
Hi,
Attached is an updated patch that uses better schema / role names.
--
Robins Tharakan
On 18 March 2013 12:59, robins thara...@gmail.com wrote:
Thanks Alvaro.
Since the tests were running fine, I didn't bother with elaborate names,
but since you're concerned guess I'll make that change
Hi,
Please find attached a patch to take 'make check' code-coverage of SCHEMA
from 33% to 98%.
Any feedback is more than welcome.
p.s.: I am currently working on more regression tests (USER / VIEW /
DISCARD etc). Please let me know if I need to post these as one large
patch, instead of
robins escribió:
Hi,
Please find attached a patch to take 'make check' code-coverage of SCHEMA
from 33% to 98%.
Any feedback is more than welcome.
I think you should use more explicit names for shared objects such as
roles -- i.e. not r1 but regression_user_1 and so on. (But be
careful
20 matches
Mail list logo
