Re: [HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2014-02-28 Thread Fabrízio de Royes Mello
On Fri, Feb 28, 2014 at 5:05 PM, Alvaro Herrera wrote: > > Pavel Stehule escribió: > > > I agree with Tom proposal - CINE - where object holds data, COR everywhere > > else. > > > > But it means, so all functionality from this patch have to be rewritten :( > > So we return this patch with feedback

Re: [HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2014-02-28 Thread Alvaro Herrera
Pavel Stehule escribió: > I agree with Tom proposal - CINE - where object holds data, COR everywhere > else. > > But it means, so all functionality from this patch have to be rewritten :( So we return this patch with feedback, right? I don't think it's reasonable to continue waiting this late.

Re: [HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2014-01-30 Thread Pavel Stehule
2014-01-19 Tom Lane : > Stephen Frost writes: > > * Robert Haas (robertmh...@gmail.com) wrote: > >> I kind of don't see the point of having IF NOT EXISTS for things that > >> have OR REPLACE, and am generally in favor of implementing OR REPLACE > >> rather than IF NOT EXISTS where possible. The

Re: [HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2014-01-19 Thread Tom Lane
Stephen Frost writes: > * Robert Haas (robertmh...@gmail.com) wrote: >> I kind of don't see the point of having IF NOT EXISTS for things that >> have OR REPLACE, and am generally in favor of implementing OR REPLACE >> rather than IF NOT EXISTS where possible. The point is usually to get >> the ob

[HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2014-01-18 Thread Stephen Frost
All, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Jun 12, 2013 at 3:00 PM, Peter Eisentraut wrote: > > On 6/12/13 1:29 PM, Fabrízio de Royes Mello wrote: > >> - CREATE AGGREGATE [ IF NOT EXISTS ] ... > >> - CREATE CAST [ IF NOT EXISTS ] ... > >> - CREATE COLLATION [ IF NOT EXISTS ] ...

[HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2013-07-26 Thread Abhijit Menon-Sen
At 2013-07-26 10:39:00 +0200, karl...@gmail.com wrote: > > Hello, as I can see there are more inconsistent places. Right. This is what I was referring to in my original review. All of the relevant sites (pre-patch) that currently do: if (already exists) ereport(ERROR …) should instea

[HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2013-07-13 Thread Abhijit Menon-Sen
At 2013-06-12 14:29:59 -0300, fabriziome...@gmail.com wrote: > > The attached patch add support to "IF NOT EXISTS" to "CREATE" > statements listed below: […] I noticed that this patch was listed as "Needs Review" with no reviewers, so I had a quick look. It applies with a couple of "trailing whit