Re: [HACKERS] pg_basebackup: Allow use of arbitrary compression program

2017-04-27 Thread Michael Harris
Hi All, I have a working prototype now, but there is one aspect I haven't been able to find the best solution for. The CLI interface so far has the following new added option: -C, --compressprog=PRG use supplied external program for compression An example usage would be: pg_basebackup

Re: [HACKERS] pg_basebackup: Allow use of arbitrary compression program

2017-04-11 Thread Michael Harris
Hi, Thanks for the feedback! >> 2) The current logic either uses zlib if compiled in, or offers no >> compression at all, controlled by a series of #ifdef/#endif. I would >> prefer that the user can either use zlib or an external program >> without having to recompile, so I would remove the

Re: [HACKERS] pg_basebackup: Allow use of arbitrary compression program

2017-04-09 Thread Magnus Hagander
On Fri, Apr 7, 2017 at 4:04 AM, Michael Harris wrote: > Hello, > > Back in pg 9.2, we hacked a copy of pg_basebackup to add a command > line option which would allow the user to specify an arbitrary > external program (potentially including arguments) to be used to > compress

Re: [HACKERS] pg_basebackup: Allow use of arbitrary compression program

2017-04-07 Thread Jeff Janes
On Thu, Apr 6, 2017 at 7:04 PM, Michael Harris wrote: > Hello, > > Back in pg 9.2, we hacked a copy of pg_basebackup to add a command > line option which would allow the user to specify an arbitrary > external program (potentially including arguments) to be used to > compress

[HACKERS] pg_basebackup: Allow use of arbitrary compression program

2017-04-06 Thread Michael Harris
Hello, Back in pg 9.2, we hacked a copy of pg_basebackup to add a command line option which would allow the user to specify an arbitrary external program (potentially including arguments) to be used to compress the tar backup. Our motivation was to be able to use pigz (parallel gzip