Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-31 Thread Kyotaro HORIGUCHI
At Thu, 26 Oct 2017 12:42:23 +0200, Robert Haas wrote in > On Thu, Oct 26, 2017 at 10:18 AM, Kyotaro HORIGUCHI > wrote: > > Thank you. I forgot that point. Changed them

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-26 Thread Robert Haas
On Thu, Oct 26, 2017 at 10:18 AM, Kyotaro HORIGUCHI wrote: > Thank you. I forgot that point. Changed them so that the messages > are detected as msgids. Committed, changing "aggressive" to "aggressively" in one place for correct English. -- Robert Haas

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-26 Thread Kyotaro HORIGUCHI
Thank you for the comment. (Thank you Sawada-san for reviewng, too.) At Thu, 19 Oct 2017 13:03:38 +0200, Alvaro Herrera wrote in <20171019110338.awwzc3y674co7wof@alvherre.pgsql> > Kyotaro HORIGUCHI wrote: > > > How about the followings? > > > > "automatic [agressive

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-19 Thread Alvaro Herrera
Kyotaro HORIGUCHI wrote: > How about the followings? > > "automatic [agressive ]vacuum of table \"%s..." > "[aggressive ]vacuuming \"%s..." That form of log message seems acceptable to me (first one is missing a 'g'). In any case, please do not construct the sentence with %s expanding the

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-19 Thread Masahiko Sawada
On Tue, Sep 5, 2017 at 3:41 PM, Kyotaro HORIGUCHI wrote: > Thank you for the opinions. > > At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada > wrote in

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-09-05 Thread Kyotaro HORIGUCHI
Hello, At Mon, 28 Aug 2017 20:07:32 -0700, "David G. Johnston" wrote in > On Mon, Aug 28, 2017 at 2:26 AM, Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp> wrote: > > >

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-09-05 Thread Kyotaro HORIGUCHI
Thank you for the opinions. At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada wrote in

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-08-29 Thread Masahiko Sawada
On Tue, Aug 29, 2017 at 10:16 AM, Robert Haas wrote: > On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI > wrote: >> Currently the message shows the '%d skipped-frozen' message but >> it is insufficient to verify the true effect. This is a

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-08-28 Thread David G. Johnston
On Mon, Aug 28, 2017 at 2:26 AM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > https://www.postgresql.org/docs/devel/static/runtime-config-client.html > > > > ​V​ > ACUUM performs an aggressive scan > ​Maybe this should gets its own thread/patch but I'll tack this on here since

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-08-28 Thread Robert Haas
On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI wrote: > Currently the message shows the '%d skipped-frozen' message but > it is insufficient to verify the true effect. This is a patch to > show mode as 'aggressive' or 'normal' in the closing message of >

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-08-28 Thread Kyotaro HORIGUCHI
Hello, Currently the message shows the '%d skipped-frozen' message but it is insufficient to verify the true effect. This is a patch to show mode as 'aggressive' or 'normal' in the closing message of vacuum. %d frozen-skipped when 'aggressive mode' shows the true effect of ALL_FROZEN. I will add

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-04-04 Thread Masahiko Sawada
On Tue, Apr 4, 2017 at 10:09 AM, Kyotaro HORIGUCHI wrote: > Hello, > > At Fri, 31 Mar 2017 18:20:23 +0900, Masahiko Sawada > wrote in >> On Wed, Mar 29, 2017 at 12:46 PM,

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-04-03 Thread Kyotaro HORIGUCHI
Hello, At Fri, 31 Mar 2017 18:20:23 +0900, Masahiko Sawada wrote in > On Wed, Mar 29, 2017 at 12:46 PM, Kyotaro HORIGUCHI > wrote: > > Hello, it would be too late but

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-03-31 Thread Masahiko Sawada
On Wed, Mar 29, 2017 at 12:46 PM, Kyotaro HORIGUCHI wrote: > Hello, it would be too late but I'd like to propose this because > this cannot be back-patched. > > > In autovacuum logs, "%u skipped frozen" shows the number of pages > skipped by ALL_FROZEN only in

[HACKERS] show "aggressive" or not in autovacuum logs

2017-03-28 Thread Kyotaro HORIGUCHI
Hello, it would be too late but I'd like to propose this because this cannot be back-patched. In autovacuum logs, "%u skipped frozen" shows the number of pages skipped by ALL_FROZEN only in aggressive vacuum. So users cannot tell whether '0 skipped-frozen' means a non-agressive vacuum or no