Re: [HACKERS] [PATCHES] Fix database is ready race condition

2007-02-07 Thread Alvaro Herrera
Jim Nasby wrote: On Feb 5, 2007, at 8:19 AM, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: My suggestions would be 1. Database system has completed recovery and 2. Database system is ready to accept connections The second was in fact the wording I had in mind, sorry for not being

Re: [HACKERS] [PATCHES] Fix database is ready race condition

2007-02-06 Thread Jim Nasby
On Feb 5, 2007, at 8:19 AM, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: My suggestions would be 1. Database system has completed recovery and 2. Database system is ready to accept connections The second was in fact the wording I had in mind, sorry for not being clear. As to the

Re: [HACKERS] [PATCHES] Fix database is ready race condition

2007-02-05 Thread Simon Riggs
On Sun, 2007-02-04 at 14:15 -0500, Tom Lane wrote: Markus Schiltknecht [EMAIL PROTECTED] writes: is there a good reason to print the database system is ready message in StartupXLOG() in xact.c? It has a) nothing to do with xlog and b) opens a small race condition: the message gets

Re: [HACKERS] [PATCHES] Fix database is ready race condition

2007-02-05 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: My suggestions would be 1. Database system has completed recovery and 2. Database system is ready to accept connections The second was in fact the wording I had in mind, sorry for not being clear. As to the first, the question is whether a log message at

Re: [HACKERS] [PATCHES] Fix database is ready race condition

2007-02-04 Thread Tom Lane
Markus Schiltknecht [EMAIL PROTECTED] writes: is there a good reason to print the database system is ready message in StartupXLOG() in xact.c? It has a) nothing to do with xlog and b) opens a small race condition: the message gets printed, while it still take some CPU cycles until the

Re: [HACKERS] [PATCHES] Fix database is ready race condition

2007-02-04 Thread Markus Schiltknecht
Hi, Tom Lane wrote: I don't think there's any compelling reason for having that log message in its current form. What about redefining it to mean postmaster is ready to accept connections --- either with that wording, or keeping the old wording? Then we could just put it in one place in