Re: [HACKERS] Seg fault in pgbench

2016-02-12 Thread Alvaro Herrera
Jeff Janes wrote: > If I give pgbench an empty file, I get a segfault. > > $ touch empty.sql > $ src/bin/pgbench/pgbench -T 60 -f empty.sql > starting vacuum...end. > Segmentation fault (core dumped) > > This has been since this commit: > > commit 8bea3d2219844887e170471f223ba100b3c17571 >

Re: [HACKERS] Seg fault in pgbench

2016-02-12 Thread Fabien COELHO
If I give pgbench an empty file, I get a segfault. $ touch empty.sql $ src/bin/pgbench/pgbench -T 60 -f empty.sql starting vacuum...end. Segmentation fault (core dumped) Oops, shame on me:-( I should have tested this one, especially as I tested it for other changes in pgbench... Thanks

Re: [HACKERS] Seg fault in pgbench

2016-02-12 Thread Jeff Janes
On Fri, Feb 12, 2016 at 12:22 PM, Alvaro Herrera wrote: > Jeff Janes wrote: >> If I give pgbench an empty file, I get a segfault. >> >> $ touch empty.sql >> $ src/bin/pgbench/pgbench -T 60 -f empty.sql >> starting vacuum...end. >> Segmentation fault (core dumped) > > I

Re: [HACKERS] Seg fault in pgbench

2016-02-12 Thread Alvaro Herrera
Jeff Janes wrote: > If I give pgbench an empty file, I get a segfault. > > $ touch empty.sql > $ src/bin/pgbench/pgbench -T 60 -f empty.sql > starting vacuum...end. > Segmentation fault (core dumped) I fixed this by checking whether the first command is NULL; originally this case was handled by