Re: [HACKERS] old warning in docs

2014-02-24 Thread Bruce Momjian
On Sat, Feb 15, 2014 at 07:34:20PM -0500, Bruce Momjian wrote:
> On Sat, Feb 15, 2014 at 07:19:46PM -0500, Robert Haas wrote:
> > On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian  wrote:
> > > I have created the attached patch which removes many of the pre-8.0
> > > references, and trims some of the 8.1-8.3 references.  There are
> > > probably some of these that should be kept, but it is easier to show you
> > > all the possibilities and we can trim down the removal list based on
> > > feedback.
> > 
> > The changes to lobj.sgml seem pointless.  I would also vote for
> > keeping xindex.sgml as-is.  The rest of the changes seem like
> > improvements.
> 
> OK, done.  Updated patch attached.

Patch applied.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] old warning in docs

2014-02-15 Thread Bruce Momjian
On Sat, Feb 15, 2014 at 07:19:46PM -0500, Robert Haas wrote:
> On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian  wrote:
> > I have created the attached patch which removes many of the pre-8.0
> > references, and trims some of the 8.1-8.3 references.  There are
> > probably some of these that should be kept, but it is easier to show you
> > all the possibilities and we can trim down the removal list based on
> > feedback.
> 
> The changes to lobj.sgml seem pointless.  I would also vote for
> keeping xindex.sgml as-is.  The rest of the changes seem like
> improvements.

OK, done.  Updated patch attached.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

  + Everyone has their own god. +
diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
new file mode 100644
index 30fd9bb..a5b74e6
*** a/doc/src/sgml/datatype.sgml
--- b/doc/src/sgml/datatype.sgml
*** NUMERIC
*** 744,754 
  
  
   
!   Prior to PostgreSQL 7.4, the precision in
!   float(p) was taken to mean
!   so many decimal digits.  This has been corrected to match the SQL
!   standard, which specifies that the precision is measured in binary
!   digits.  The assumption that real and
double precision have exactly 24 and 53 bits in the
mantissa respectively is correct for IEEE-standard floating point
implementations.  On non-IEEE platforms it might be off a little, but
--- 744,750 
  
  
   
!   The assumption that real and
double precision have exactly 24 and 53 bits in the
mantissa respectively is correct for IEEE-standard floating point
implementations.  On non-IEEE platforms it might be off a little, but
*** ALTER SEQUENCE  configuration variable is
!used.  As of PostgreSQL 8.1,
!this variable is false by default, so the default behavior is not
!identical to pre-8.0 releases.  Applications that
!require OIDs in the table created by CREATE TABLE
!AS should explicitly specify WITH (OIDS)
!to ensure desired behavior.

   
  
--- 236,246 

  

!The CREATE TABLE AS command allows the user to
 explicitly specify whether OIDs should be included. If the
 presence of OIDs is not explicitly specified,
 the  configuration variable is
!used.

   
  
diff --git a/doc/src/sgml/ref/pg_config-ref.sgml b/doc/src/sgml/ref/pg_config-ref.sgml
new file mode 100644
index 5aac38b..e3f6732
*** a/doc/src/sgml/ref/pg_config-ref.sgml
--- b/doc/src/sgml/ref/pg_config-ref.sgml
***
*** 297,311 
Notes
  

-The option --includedir-server was added in
-PostgreSQL 7.2.  In prior releases, the server include files were
-installed in the same location as the client headers, which could
-be queried with the option --includedir.  To make your
-package handle both cases, try the newer option first and test the
-exit status to see whether it succeeded.
-   
- 
-   
 The options --docdir, --pkgincludedir,
 --localedir, --mandir,
 --sharedir, --sysconfdir,
--- 297,302 
***
*** 316,327 
 The option --htmldir was added in PostgreSQL 8.4.
 The option --ldflags_ex was added in PostgreSQL 9.0.

- 
-   
-In releases prior to PostgreSQL 7.1, before
-pg_config came to be, a method for finding the
-equivalent configuration information did not exist.
-   
   
  
  
--- 307,312 
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
new file mode 100644
index 7222665..736b758
*** a/doc/src/sgml/ref/reindex.sgml
--- b/doc/src/sgml/ref/reindex.sgml
*** REINDEX { INDEX | TABLE | DATABASE | SYS
*** 218,236 
 reindex anything.

  
-   
-Prior to PostgreSQL 8.1, REINDEX
-DATABASE processed only system indexes, not all indexes as one would
-expect from the name.  This has been changed to reduce the surprise
-factor.  The old behavior is available as REINDEX SYSTEM.
-   
- 
-   
-Prior to PostgreSQL 7.4, REINDEX
-TABLE did not automatically process TOAST tables, and so those had
-to be reindexed by separate commands.  This is still possible, but
-redundant.
-   
   
  
   
--- 218,223 
diff --git a/doc/src/sgml/ref/select_into.sgml b/doc/src/sgml/ref/select_into.sgml
new file mode 100644
index 48b789b..e6b5861
*** a/doc/src/sgml/ref/select_into.sgml
--- b/doc/src/sgml/ref/select_into.sgml
*** SELECT [ ALL | DISTINCT [ ON ( 
  

!Prior to PostgreSQL 8.1, the table created by
!SELECT INTO included OIDs by default. In
!PostgreSQL 8.1, this is not the case
!— to include OIDs in the new table, the  configuration variable must be
!enabled. Alternatively, CREATE TABLE AS can be
 used with the WITH OIDS clause.

   
--- 106,114 

  

!To add OIDs to the table created by SELECT INTO,
!enable the  configuration
!   

Re: [HACKERS] old warning in docs

2014-02-15 Thread Robert Haas
On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian  wrote:
> I have created the attached patch which removes many of the pre-8.0
> references, and trims some of the 8.1-8.3 references.  There are
> probably some of these that should be kept, but it is easier to show you
> all the possibilities and we can trim down the removal list based on
> feedback.

The changes to lobj.sgml seem pointless.  I would also vote for
keeping xindex.sgml as-is.  The rest of the changes seem like
improvements.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] old warning in docs

2014-02-13 Thread Bruce Momjian
On Mon, Oct  7, 2013 at 08:43:27AM -0700, David Fetter wrote:
> On Mon, Oct 07, 2013 at 07:51:44AM -0400, Andrew Dunstan wrote:
> > 
> > Given that we have not supported releases older than 8.3 for quite a
> > while, do we need to keep this in extend.sgml any longer?
> > 
> >   
> > 
> >  Changing PG_CONFIG only works when building
> >  against PostgreSQL 8.3 or later.
> >  With older releases it does not work to set it to anything except
> >  pg_config; you must alter your PATH
> >  to select the installation to build against.
> > 
> >
> 
> I say "bin it."  That reminds me.  There are probably a lot of places
> in the docs that refer to versions of PostgreSQL a good bit older than
> 8.3.  Will grep and patch as I get the time.

I have created the attached patch which removes many of the pre-8.0
references, and trims some of the 8.1-8.3 references.  There are
probably some of these that should be kept, but it is easier to show you
all the possibilities and we can trim down the removal list based on
feedback.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

  + Everyone has their own god. +
diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
new file mode 100644
index 30fd9bb..a5b74e6
*** a/doc/src/sgml/datatype.sgml
--- b/doc/src/sgml/datatype.sgml
*** NUMERIC
*** 744,754 
  
  
   
!   Prior to PostgreSQL 7.4, the precision in
!   float(p) was taken to mean
!   so many decimal digits.  This has been corrected to match the SQL
!   standard, which specifies that the precision is measured in binary
!   digits.  The assumption that real and
double precision have exactly 24 and 53 bits in the
mantissa respectively is correct for IEEE-standard floating point
implementations.  On non-IEEE platforms it might be off a little, but
--- 744,750 
  
  
   
!   The assumption that real and
double precision have exactly 24 and 53 bits in the
mantissa respectively is correct for IEEE-standard floating point
implementations.  On non-IEEE platforms it might be off a little, but
*** ALTER SEQUENCE  configuration variable is
!used.  As of PostgreSQL 8.1,
!this variable is false by default, so the default behavior is not
!identical to pre-8.0 releases.  Applications that
!require OIDs in the table created by CREATE TABLE
!AS should explicitly specify WITH (OIDS)
!to ensure desired behavior.

   
  
--- 236,246 

  

!The CREATE TABLE AS command allows the user to
 explicitly specify whether OIDs should be included. If the
 presence of OIDs is not explicitly specified,
 the  configuration variable is
!used.

   
  
diff --git a/doc/src/sgml/ref/pg_config-ref.sgml b/doc/src/sgml/ref/pg_config-ref.sgml
new file mode 100644
index 5aac38b..e3f6732
*** a/doc/src/sgml/ref/pg_config-ref.sgml
--- b/doc/src/sgml/ref/pg_config-ref.sgml
***
*** 297,311 
Notes
  

-The option --includedir-server was added in
-PostgreSQL 7.2.  In prior releases, the server include files were
-installed in the same location as the client headers, which could
-be queried with the option --includedir.  To make your
-package handle both cases, try the newer option first and test the
-exit status to see whether it succeeded.
-   
- 
-   
 The options --docdir, --pkgincludedir,
 --localedir, --mandir,
 --sharedir, --sysconfdir,
--- 297,302 
***
*** 316,327 
 The option --htmldir was added in PostgreSQL 8.4.
 The option --ldflags_ex was added in PostgreSQL 9.0.

- 
-   
-In releases prior to PostgreSQL 7.1, before
-pg_config came to be, a method for finding the
-equivalent configuration information did not exist.
-   
   
  
  
--- 307,312 
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
new file mode 100644
index 7222665..736b758
*** a/doc/src/sgml/ref/reindex.sgml
--- b/doc/src/sgml/ref/reindex.sgml
*** REINDEX { INDEX | TABLE | DATABASE | SYS
*** 218,236 
 reindex anything.

  
-   
-Prior to PostgreSQL 8.1, REINDEX
-DATABASE processed only system indexes, not all indexes as one would
-expect from the name.  This has been changed to reduce the surprise
-factor.  The old behavior is available as REINDEX SYSTEM.
-   
- 
-   
-Prior to PostgreSQL 7.4, REINDEX
-TABLE did not automatically process TOAST tables, and so those had
-to be reindexed by separate commands.  This is still possible, but
-redundant.
-   
   
  
   
--- 218,223 
diff --git a/doc/src/sgml/ref/select_into.sgml b/doc/src/sgml/ref/select_into.sgml
new file mode 100644
index 48b789b..e6b5861
*** a/doc/src/sgml/ref/select_into.sgml
--- b/doc/src/sgml/ref/select_into.sgml
*** SELECT [ ALL | DISTINCT [ 

Re: [HACKERS] old warning in docs

2013-10-08 Thread Magnus Hagander
On Oct 8, 2013 6:27 PM, "Robert Haas"  wrote:
>
> On Mon, Oct 7, 2013 at 7:51 AM, Andrew Dunstan
>  wrote:
> > Given that we have not supported releases older than 8.3 for quite a
while,
> > do we need to keep this in extend.sgml any longer?
>
> +1 for removing that (but only in master, not the back-branches).
>

+1, and definitely not in back branches.

/Magnus


Re: [HACKERS] old warning in docs

2013-10-08 Thread Robert Haas
On Mon, Oct 7, 2013 at 7:51 AM, Andrew Dunstan
 wrote:
> Given that we have not supported releases older than 8.3 for quite a while,
> do we need to keep this in extend.sgml any longer?

+1 for removing that (but only in master, not the back-branches).

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] old warning in docs

2013-10-07 Thread David Fetter
On Mon, Oct 07, 2013 at 07:51:44AM -0400, Andrew Dunstan wrote:
> 
> Given that we have not supported releases older than 8.3 for quite a
> while, do we need to keep this in extend.sgml any longer?
> 
>   
> 
>  Changing PG_CONFIG only works when building
>  against PostgreSQL 8.3 or later.
>  With older releases it does not work to set it to anything except
>  pg_config; you must alter your PATH
>  to select the installation to build against.
> 
>

I say "bin it."  That reminds me.  There are probably a lot of places
in the docs that refer to versions of PostgreSQL a good bit older than
8.3.  Will grep and patch as I get the time.

Cheers,
David.
-- 
David Fetter  http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter  XMPP: david.fet...@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers