Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-22 Thread Stefan Kaltenbrunner
On 01/21/2013 08:45 PM, Tom Lane wrote: Stefan Kaltenbrunner writes: On 01/21/2013 02:00 PM, Tom Lane wrote: (It's entirely likely that the 7.0 server I keep around for testing this is the last one in captivity anywhere. But IIRC, we've heard fairly recent reports of people still using 7.2.

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Tom Lane
Stefan Kaltenbrunner writes: > On 01/21/2013 02:00 PM, Tom Lane wrote: >> (It's entirely likely that the 7.0 server I keep around for testing this >> is the last one in captivity anywhere. But IIRC, we've heard fairly >> recent reports of people still using 7.2. We'd have to desupport before >>

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Stefan Kaltenbrunner
On 01/21/2013 02:00 PM, Tom Lane wrote: > Pavan Deolasee writes: >> On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane wrote: >>> As submitted, this broke pg_dump for dumping from pre-8.0 servers. >>> (7.4 didn't accept commas in SET TRANSACTION syntax, and versions >>> before that didn't have the READ ON

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 8:00 AM, Tom Lane wrote: > Pavan Deolasee writes: >> On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane wrote: >>> As submitted, this broke pg_dump for dumping from pre-8.0 servers. >>> (7.4 didn't accept commas in SET TRANSACTION syntax, and versions >>> before that didn't have t

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Tom Lane
Pavan Deolasee writes: > On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane wrote: >> As submitted, this broke pg_dump for dumping from pre-8.0 servers. >> (7.4 didn't accept commas in SET TRANSACTION syntax, and versions >> before that didn't have the READ ONLY option at all.) > My bad. I did not realiz

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-20 Thread Pavan Deolasee
On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane wrote: > Pavan Deolasee writes: >> Sorry for posting on such an old thread. But here is a patch that >> fixes this. I'm also adding to the next commitfest so that we don't >> lose track of it again. > > As submitted, this broke pg_dump for dumping from pr

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-19 Thread Tom Lane
Pavan Deolasee writes: > Sorry for posting on such an old thread. But here is a patch that > fixes this. I'm also adding to the next commitfest so that we don't > lose track of it again. As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET TRANSACTIO

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-16 Thread Gurjeet Singh
On Wed, Jan 16, 2013 at 1:21 AM, Pavan Deolasee wrote: > > > On Wed, Jan 9, 2013 at 6:42 AM, Gurjeet Singh wrote: > >> >>> >> I have updated the commitfest submission to link to the correct patch >> email. >> >> > Thanks Gurjeet. > > >> I initially thought that this patch deserves accompanying do

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-15 Thread Pavan Deolasee
On Wed, Jan 9, 2013 at 6:42 AM, Gurjeet Singh wrote: > >> > I have updated the commitfest submission to link to the correct patch > email. > > Thanks Gurjeet. > I initially thought that this patch deserves accompanying documentation > because pg_dump's serializable transaction may error out beca

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-08 Thread Gurjeet Singh
On Mon, Dec 31, 2012 at 1:38 AM, Pavan Deolasee wrote: > On Sun, Dec 30, 2012 at 12:38 AM, Stephen Frost > wrote: > > * Pavan Deolasee (pavan.deola...@gmail.com) wrote: > >> On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner > >> > That makes sense to me. The reason I didn't make that change when I

Re: [HACKERS] pg_dump transaction's read-only mode

2012-12-30 Thread Pavan Deolasee
On Sun, Dec 30, 2012 at 12:38 AM, Stephen Frost wrote: > * Pavan Deolasee (pavan.deola...@gmail.com) wrote: >> On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner >> > That makes sense to me. The reason I didn't make that change when I >> > added the serializable special case to pg_dump was that it se

Re: [HACKERS] pg_dump transaction's read-only mode

2012-12-29 Thread Stephen Frost
* Pavan Deolasee (pavan.deola...@gmail.com) wrote: > On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner > > That makes sense to me. The reason I didn't make that change when I > > added the serializable special case to pg_dump was that it seemed > > like a separate question; I didn't want to complicat

Re: [HACKERS] pg_dump transaction's read-only mode

2012-12-06 Thread Pavan Deolasee
On Mon, Sep 10, 2012 at 10:00 PM, Pavan Deolasee wrote: > On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner > wrote: > > >> That makes sense to me. The reason I didn't make that change when I >> added the serializable special case to pg_dump was that it seemed >> like a separate question; I didn't

Re: [HACKERS] pg_dump transaction's read-only mode

2012-09-10 Thread Pavan Deolasee
On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner wrote: > That makes sense to me. The reason I didn't make that change when I > added the serializable special case to pg_dump was that it seemed > like a separate question; I didn't want to complicate an already big > patch with unnecessary changes

Re: [HACKERS] pg_dump transaction's read-only mode

2012-09-07 Thread Kevin Grittner
Pavan Deolasee wrote: > I'm looking at the following code in pg_dump.c > > /* >* Start transaction-snapshot mode transaction to dump >* consistent data. >*/ > ExecuteSqlStatement(fout, "BEGIN"); > if (fout->remoteVersion >= 90100) > { > if (serializable_deferrable) >