Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-03 Thread Robert Haas
On Tue, Aug 3, 2010 at 3:52 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Aug 2, 2010 at 11:16 PM, Jeff Davis wrote: >>> Sure. I attached two tests. > >> Committed. > > I see no sign of a commit from here ... Sigh. Forgot to exit my editor. -- Robert Haas EnterpriseDB: http://www.ente

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-03 Thread Tom Lane
Robert Haas writes: > On Mon, Aug 2, 2010 at 11:16 PM, Jeff Davis wrote: >> Sure. I attached two tests. > Committed. I see no sign of a commit from here ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-03 Thread Robert Haas
On Mon, Aug 2, 2010 at 11:16 PM, Jeff Davis wrote: > On Mon, 2010-08-02 at 12:27 -0400, Robert Haas wrote: >> I was also wondering if it would be worth adding some additional >> regression testing to contrib/btree_gist exercising this new >> functionality.  Thoughts? > > Sure. I attached two tests

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-02 Thread Jeff Davis
On Mon, 2010-08-02 at 12:27 -0400, Robert Haas wrote: > I was also wondering if it would be worth adding some additional > regression testing to contrib/btree_gist exercising this new > functionality. Thoughts? Sure. I attached two tests. Regards, Jeff Davis *** a/contrib/btree_gist/Mak

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 2:39 AM, Jeff Davis wrote: > On Sun, 2010-08-01 at 21:57 -0400, Robert Haas wrote: >> On Fri, Jul 16, 2010 at 1:19 AM, Jeff Davis wrote: >> > Thank you for the review. >> > >> > On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: >> >> (1) Exclusion constraints suppo

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-01 Thread Jeff Davis
On Sun, 2010-08-01 at 21:57 -0400, Robert Haas wrote: > On Fri, Jul 16, 2010 at 1:19 AM, Jeff Davis wrote: > > Thank you for the review. > > > > On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: > >> (1) Exclusion constraints support for operators where "x x" > >> is false (tiny patch) >

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-08-01 Thread Robert Haas
On Fri, Jul 16, 2010 at 1:19 AM, Jeff Davis wrote: > Thank you for the review. > > On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: >> (1) Exclusion constraints support for operators where "x x" >> is false (tiny patch) >> https://commitfest.postgresql.org/action/patch_view?id=307 >> (2

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-07-20 Thread Itagaki Takahiro
2010/7/16 Jeff Davis : >> I'd like to ask you to write additional documentation about btree_gist [1] >> that the module will be more useful when it is used with exclusion >> constraints together. Without documentation, no users find the usages. | Example using an Exclusion Constraint to enforce th

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-07-15 Thread Jeff Davis
Hi, Thank you for the review. On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: > (1) Exclusion constraints support for operators where "x x" > is false (tiny patch) > https://commitfest.postgresql.org/action/patch_view?id=307 > (2) btree_gist support for searching on <> ("not equals")

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-07-12 Thread Itagaki Takahiro
(1) Exclusion constraints support for operators where "x x" is false (tiny patch) https://commitfest.postgresql.org/action/patch_view?id=307 (2) btree_gist support for searching on <> ("not equals") https://commitfest.postgresql.org/action/patch_view?id=308 Those patches should be committed at on

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-05-24 Thread Robert Haas
On Mon, May 24, 2010 at 11:25 PM, Jeff Davis wrote: > I think the original case (same values only) is potentially useful > enough that we should support it. +1. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-05-24 Thread Jeff Davis
On Sat, 2010-05-22 at 01:02 +0300, Marko Tiikkaja wrote: > On 5/21/10 11:47 PM +0300, Jeff Davis wrote: > > It also allows you to enforce the constraint that only one tuple exists > > in a table by doing something like: > > > >create table a > >( > > i int, > > exclude using gist

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-05-24 Thread Takahiro Itagaki
Marko Tiikkaja wrote: > On 5/21/10 11:47 PM +0300, Jeff Davis wrote: > > It also allows you to enforce the constraint that only one tuple exists > > in a table by doing something like: > > > >create table a > >( > > i int, > > exclude using gist (i with<>), > > unique (i)

Re: [HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-05-21 Thread Marko Tiikkaja
On 5/21/10 11:47 PM +0300, Jeff Davis wrote: It also allows you to enforce the constraint that only one tuple exists in a table by doing something like: create table a ( i int, exclude using gist (i with<>), unique (i) ); FWIW, this is achievable a lot more easily: CREA

[HACKERS] (9.1) btree_gist support for searching on "not equals"

2010-05-21 Thread Jeff Davis
This patch adds support to btree_gist for searching on <> ("not equals"). This allows an interesting use of exclusion constraints: Say you have a table: create table zoo ( cage int, animal text, exclude using gist (cage with =, animal with <>) ); That will permit you to add a