Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-29 Thread Kevin Grittner
Tom Lane wrote: > Kevin Grittner writes: >> Tom Lane wrote: >>> So I'm inclined to propose that we set min/max to 0 and 99 >>> here. >> >> Something like the attached back-patched to 8.4? > > Works for me. Done. Thanks for the report, Joel! -- Kevin Grittner EDB: http://www.enterprisedb.c

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-29 Thread Tom Lane
Kevin Grittner writes: > Tom Lane wrote: >> So I'm inclined to propose that we set min/max to 0 and 99 here. > Something like the attached back-patched to 8.4? Works for me. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-29 Thread Kevin Grittner
Tom Lane wrote: > On reflection, I'm not sure that pg_restore as such should be applying any > server version check at all.  pg_restore itself has precious little to do > with whether there will be a compatibility problem; that's mostly down to > the DDL that pg_dump put into the archive file.  A

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-28 Thread Tom Lane
Kevin Grittner writes: > Oh, I just noticed that this is for the *pg_restore* code, not the > pg_dump code, so there isn't necessarily a conflict with the docs. > The pg_dump code does match the docs on its version check. The > question becomes, for each supported version, what do we want to > set

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-27 Thread Kevin Grittner
Kevin Grittner wrote: > Joel Jacobson wrote: > >> As reported by Andrey Karpov in his article >> http://www.viva64.com/en/b/0227/ >> the version number is expressed in octal form 070100 should be >> changed to 70100. >> >> Attached patch fixes the reported issue. > > This is a bug, but it's not c

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-27 Thread Kevin Grittner
Joel Jacobson wrote: > As reported by Andrey Karpov in his article > http://www.viva64.com/en/b/0227/ > the version number is expressed in octal form 070100 should be > changed to 70100. > > Attached patch fixes the reported issue. This is a bug, but it's not clear what the correct patch should

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-25 Thread Oleg Bartunov
Yes, we got temp licence key from them and will provide full report. On Wed, Dec 25, 2013 at 4:38 PM, Joel Jacobson wrote: > As reported by Andrey Karpov in his article > http://www.viva64.com/en/b/0227/, the version number is expressed in > octal form 070100 should be changed to 70100. > > Attac

[HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-25 Thread Joel Jacobson
As reported by Andrey Karpov in his article http://www.viva64.com/en/b/0227/, the version number is expressed in octal form 070100 should be changed to 70100. Attached patch fixes the reported issue. octal-typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hacker