Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-07 Thread Simon Riggs
On 6 February 2013 17:43, Simon Riggs wrote: >> Here's what I think should be done: >> >> 1. Remove the check that prev checkpoint record exists. > > Agreed Done >> 2. Always do fast promotion if in standby mode. Remove the pg_ctl option. > > Disagreed, other viewpoints welcome. Waiting for fu

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-07 Thread Kevin Grittner
Heikki Linnakangas wrote: > On 07.02.2013 10:41, Simon Riggs wrote: >> Why would someone want to turn off safe-promote mode, assuming it was >> fast enough? > Because faster is nicer, even if the slow mode would be "fast enough". http://www.youtube.com/watch?v=H3R-rtWPyJY -Kevin -- Sent

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-07 Thread Robert Haas
On Thu, Feb 7, 2013 at 4:04 AM, Heikki Linnakangas wrote: > It makes me uncomfortable that we're adding switches to pg_ctl promote just > because we're worried there might be bugs in our code. If we don't trust the > code as it is, it needs more testing. We can analyze the code more > thoroughly,

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-07 Thread Simon Riggs
On 7 February 2013 09:04, Heikki Linnakangas wrote: > It makes me uncomfortable that we're adding switches to pg_ctl promote just > because we're worried there might be bugs in our code. If we don't trust the > code as it is, it needs more testing. We can analyze the code more > thoroughly, to ma

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-07 Thread Heikki Linnakangas
On 07.02.2013 10:41, Simon Riggs wrote: On 6 February 2013 18:02, Robert Haas wrote: So I would ask this question: why would someone want to turn off fast-promote mode, assuming for the sake of argument that it isn't buggy? You can write a question many ways, and lead people towards a conclu

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-07 Thread Simon Riggs
On 6 February 2013 18:02, Robert Haas wrote: > So I would ask this question: why would someone want to turn off > fast-promote mode, assuming for the sake of argument that it isn't > buggy? You can write a question many ways, and lead people towards a conclusion as a result. Why would someone w

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-06 Thread Robert Haas
On Wed, Feb 6, 2013 at 1:47 PM, Heikki Linnakangas wrote: > On 06.02.2013 20:02, Robert Haas wrote: >> >> On Wed, Feb 6, 2013 at 12:43 PM, Simon Riggs >> wrote: 2. I don't like demoting the trigger file method to a second class citizen. I think we should make all functionality avail

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-06 Thread Heikki Linnakangas
On 06.02.2013 20:02, Robert Haas wrote: On Wed, Feb 6, 2013 at 12:43 PM, Simon Riggs wrote: 2. I don't like demoting the trigger file method to a second class citizen. I think we should make all functionality available through both methods. If there was a good reason for deprecating the trigger

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-06 Thread Robert Haas
On Wed, Feb 6, 2013 at 12:43 PM, Simon Riggs wrote: >> 2. I don't like demoting the trigger file method to a second class >> citizen. I think we should make all functionality available through both >> methods. If there was a good reason for deprecating the trigger file >> method, I could live with

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-06 Thread Joshua D. Drake
On 02/06/2013 09:43 AM, Simon Riggs wrote: 4. I think fast promotion should be the default. Why not? There are cases where you want the promotion to happen ASAP, and there are cases where you don't care. But there are no scenarios where you want promotion to be slow, Not true. Slow means safe

Re: [HACKERS] [COMMITTERS] pgsql: Fast promote mode skips checkpoint at end of recovery.

2013-02-06 Thread Simon Riggs
On 6 February 2013 16:36, Heikki Linnakangas wrote: > On 31.01.2013 21:33, Simon Riggs wrote: >> >> If anyone really wants me to revert, pls start new hackers thread to >> discuss, or comment on changes. > > > Yes, I still think this needs fixing or reverting. Let me reiterate my > my complaints: