Thank you very much for refining patch.
I thought there is no missing part.
Magnus Hagander wrote:
> On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada wrote:
> > The following patches support Windows x64.
> >
> > 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
> > almo
Magnus Hagander writes:
> On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada wrote:
>> I was checked where the string converted with "%ld" is used.
>> An especially fatal part is not found excluding one of plperl.
> I have not looked at the plperl stuff yet. I'd appreciate a comment
> from someone who
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada wrote:
> The following patches support Windows x64.
>
> 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
> almost the same as that post before.
> http://archives.postgresql.org/pgsql-hackers/2009-06/threads.php#01364
>
> 2) u
On Tue, Jan 5, 2010 at 12:58, Tsutomu Yamada wrote:
> Magnus Hagander wrote:
>
> > 2009/12/4 Tsutomu Yamada :
> > > Thanks to suggestion.
> > > I send pathces again by another mailer for the archive.
> > >
> > > Sorry to waste resources, below is same content that I send before.
> >
> > I
Magnus Hagander wrote:
> 2009/12/4 Tsutomu Yamada :
> > Thanks to suggestion.
> > I send pathces again by another mailer for the archive.
> >
> > Sorry to waste resources, below is same content that I send before.
>
> I have a couple of comments about the first patch (I'll get to the
> o
On Tue, Jan 5, 2010 at 09:14, Tsutomu Yamada wrote:
> Magnus Hagander wrote:
> > On Fri, Jan 1, 2010 at 20:45, Magnus Hagander wrote:
> > > On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada
> wrote:
> > >>
> > >> 2) use appropriate macro and datatypes for Windows API.
> > >> enables more tha
Magnus Hagander wrote:
> On Fri, Jan 1, 2010 at 20:45, Magnus Hagander wrote:
> > On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada wrote:
> >>
> >> 2) use appropriate macro and datatypes for Windows API.
> >> enables more than 32bits shared memory.
> >
> > Are you sure this one should use _
On Fri, Jan 1, 2010 at 20:45, Magnus Hagander wrote:
> On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada wrote:
>>
>> 2) use appropriate macro and datatypes for Windows API.
>> enables more than 32bits shared memory.
>
> Are you sure this one should use __noop, and not __nop?
>
> __noop: http://msdn
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada wrote:
>
> 2) use appropriate macro and datatypes for Windows API.
> enables more than 32bits shared memory.
Are you sure this one should use __noop, and not __nop?
__noop: http://msdn.microsoft.com/en-us/library/s6btaxcs.aspx
__nop: http://msdn.mic
2009/12/31 Magnus Hagander :
> 2009/12/4 Tsutomu Yamada :
> A bit further down, it has:
>
> + /* The size of `void *', as computed by sizeof. */
> + #define SIZEOF_VOID_P 4
> +
>
>
> shouldn't that be 8 for win64 platforms?
Nevermind this second comment. Now that it's no longer 1AM, I see that
thi
2009/12/4 Tsutomu Yamada :
> Thanks to suggestion.
> I send pathces again by another mailer for the archive.
>
> Sorry to waste resources, below is same content that I send before.
I have a couple of comments about the first patch (I'll get to the
others later):
config.win32.h has:
+ #ifdef _MSC_
> As a reference for the future, please let us know when you have done
> this before the patch is submitted. I think it's not very common that
> just because you are in the same company, you have reviewed it. For
> example, I highly doubt that Heikki reviews all the patches Bruce
> post, or the oth
2009/12/9 Tatsuo Ishii :
>> > Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
>> > feedbacks come in, probably until Jan 15th.
>>
>> Of course there's also no rule that you couldn't review these sooner -
>> that might help get the ball rolling!
>
> Of course I did before he p
> >> BTW, is there anyone who wishes the patches get in 8.5? Apparently
> >> Tstutomu, Magnus and I are counted in the group:-) But I'd like to
> >> know how other people are interested in the patches.
> >
> > I am very interested. A 64bit-Windows-Version would give a boost
> > perception-wise
>
>
> Tatsuo,
>
> > Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
> > feedbacks come in, probably until Jan 15th.
> >
> > BTW, is there anyone who wishes the patches get in 8.5? Apparently
> > Tstutomu, Magnus and I are counted in the group:-) But I'd like to
> > know how othe
On Wed, Dec 9, 2009 at 8:31 AM, Massa, Harald Armin wrote:
> Tatsuo,
>
>> Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
>> feedbacks come in, probably until Jan 15th.
>>
>> BTW, is there anyone who wishes the patches get in 8.5? Apparently
>> Tstutomu, Magnus and I are cou
Tatsuo,
> Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
> feedbacks come in, probably until Jan 15th.
>
> BTW, is there anyone who wishes the patches get in 8.5? Apparently
> Tstutomu, Magnus and I are counted in the group:-) But I'd like to
> know how other people are int
On Tue, Dec 8, 2009 at 10:48 PM, Tatsuo Ishii wrote:
>> > Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
>> > feedbacks come in, probably until Jan 15th.
>>
>> Of course there's also no rule that you couldn't review these sooner -
>> that might help get the ball rolling!
>
> > Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
> > feedbacks come in, probably until Jan 15th.
>
> Of course there's also no rule that you couldn't review these sooner -
> that might help get the ball rolling!
Of course I did before he publishes the patches. (I and he
On Tue, Dec 8, 2009 at 10:30 PM, Tatsuo Ishii wrote:
>> Tatsuo Ishii wrote:
>> > Now that Greg is going to close the Nov Commit Festa, I think he is
>> > requesting initial reviews for the patches.
>> >
>>
>> While Magnus might take a look anyway, in general we'll all be taking a
>> break from rev
> Tatsuo Ishii wrote:
> > Now that Greg is going to close the Nov Commit Festa, I think he is
> > requesting initial reviews for the patches.
> >
>
> While Magnus might take a look anyway, in general we'll all be taking a
> break from review until January 15th, when the final CommitFest for th
Tatsuo Ishii wrote:
Now that Greg is going to close the Nov Commit Festa, I think he is
requesting initial reviews for the patches.
While Magnus might take a look anyway, in general we'll all be taking a
break from review until January 15th, when the final CommitFest for this
version start
Magnus,
> Just in case anybody was wondering, I've added myself as a reviewer of
> this one for next commitfest - I doubt that's very surprising :-)
> Others are of course more than welcome to chip in!
Greg Smith wrote:
> There are also a couple of patches that for various reasons have yet to
>
2009/12/4 Tsutomu Yamada :
> Thanks to suggestion.
> I send pathces again by another mailer for the archive.
>
> Sorry to waste resources, below is same content that I send before.
Just in case anybody was wondering, I've added myself as a reviewer of
this one for next commitfest - I doubt that's
Thanks to suggestion.
I send pathces again by another mailer for the archive.
Sorry to waste resources, below is same content that I send before.
Tsutomu Yamada
SRA OSS, Inc. Japan
#
The following patches support Windows x64.
1) use intptr_t for Datum and pointer macros. (to support Window
Stefan Kaltenbrunner escribió:
> Tsutomu Yamada wrote:
> >However, archive.postgresql.org has deleted the attachment.
> >(Why? Email sent to the individual, the attachment is included.)
> >
> >Is it too large ?
> >Should I resend them separately or compressing ?
> >wrong mail format ?
> >Should I
Tsutomu Yamada wrote:
Robert Haas wrote:
> On Tue, Dec 1, 2009 at 6:25 AM, Tsutomu Yamada wrote:
> > Hello.
> >
> > The following patches support Windows x64.
> >
> > 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
> > almost the same as that post before.
> >
Robert Haas wrote:
> On Tue, Dec 1, 2009 at 6:25 AM, Tsutomu Yamada wrote:
> > Hello.
> >
> > The following patches support Windows x64.
> >
> > 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
> > almost the same as that post before.
> > http://archives.postgr
On Tue, Dec 1, 2009 at 6:25 AM, Tsutomu Yamada wrote:
> Hello.
>
> The following patches support Windows x64.
>
> 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
> almost the same as that post before.
> http://archives.postgresql.org/pgsql-hackers/2009-06/threads.php#0
Hello.
The following patches support Windows x64.
1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)
almost the same as that post before.
http://archives.postgresql.org/pgsql-hackers/2009-06/threads.php#01364
2) use appropriate macro and datatypes for Windows API.
30 matches
Mail list logo
