Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-12 Thread Peter Eisentraut
On ons, 2011-07-06 at 12:40 -0400, Robert Haas wrote: I think perhaps we should create a big static array, each row of which would contain: - ObjectType - system cache ID for OID lookups - system catalog table OID for scans - attribute number for the name attribute, where applicable (see

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-09 Thread Kohei KaiGai
2011/7/9 Robert Haas robertmh...@gmail.com: On Fri, Jul 8, 2011 at 9:06 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: I definitely agree with this idea. It will enables to eliminate ugly switch statements for error-messaging reasons. All right, so please submit a patch that introduces that

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-08 Thread Robert Haas
On Fri, Jul 8, 2011 at 9:06 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: I definitely agree with this idea. It will enables to eliminate ugly switch statements for error-messaging reasons. All right, so please submit a patch that introduces that concept first, and then resubmit this patch

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-06 Thread Robert Haas
On Tue, Jun 28, 2011 at 4:17 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The attached patch is rebased one to consolidate routines to remove objects using the revised get_object_address(). The new RemoveObjects() replaces the following routines; having similar structure.  - RemoveRelations  

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-06 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié jul 06 12:40:39 -0400 2011: This patch removes an impressive amount of boilerplate code and replaces it with something much more compact. I like that. In the interest of full disclosure, I suggested this approach to KaiGai at PGCon, so I'm biased:

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-06 Thread Robert Haas
On Wed, Jul 6, 2011 at 1:09 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of mié jul 06 12:40:39 -0400 2011: This patch removes an impressive amount of boilerplate code and replaces it with something much more compact.   I like that.  In the interest

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-06 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié jul 06 14:02:13 -0400 2011: On Wed, Jul 6, 2011 at 1:09 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of mié jul 06 12:40:39 -0400 2011: This patch removes an impressive amount of boilerplate code and

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-06 Thread Robert Haas
On Wed, Jul 6, 2011 at 5:06 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of mié jul 06 14:02:13 -0400 2011: On Wed, Jul 6, 2011 at 1:09 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Robert Haas's message of mié jul 06 12:40:39