Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-12-06 Thread Fujii Masao
On Tue, Dec 6, 2016 at 4:54 PM, Michael Paquier wrote: > On Tue, Dec 6, 2016 at 4:38 PM, Fujii Masao wrote: >> I changed the order of descriptions of the walsender state in >> intuitive one rather than alphabetical one. Also I enhanced >> the

Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-12-05 Thread Michael Paquier
On Tue, Dec 6, 2016 at 4:38 PM, Fujii Masao wrote: > I changed the order of descriptions of the walsender state in > intuitive one rather than alphabetical one. Also I enhanced > the description of "potential" state. > > Could you review the latest patch? Fine for me. The

Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-12-05 Thread Fujii Masao
On Tue, Dec 6, 2016 at 2:13 PM, Michael Paquier wrote: > On Tue, Dec 6, 2016 at 1:54 PM, Fujii Masao wrote: >> + backup: The WAL sender is sending a backup. >> >> Seems it's better to use "This WAL sender" rather than "The WAL sender"

Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-12-05 Thread Michael Paquier
On Tue, Dec 6, 2016 at 1:54 PM, Fujii Masao wrote: > + backup: The WAL sender is sending a backup. > > Seems it's better to use "This WAL sender" rather than "The WAL sender" > like the descriptions of other fields. > > There are two descriptions of "streaming"

Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-12-05 Thread Fujii Masao
On Fri, Nov 11, 2016 at 10:03 PM, Michael Paquier wrote: > On Thu, Nov 10, 2016 at 10:35 PM, Fujii Masao wrote: >> On Wed, Nov 9, 2016 at 2:33 PM, Michael Paquier >> wrote: >>> Hi all, >>> >>> The documentation does

Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-11-11 Thread Michael Paquier
On Thu, Nov 10, 2016 at 10:35 PM, Fujii Masao wrote: > On Wed, Nov 9, 2016 at 2:33 PM, Michael Paquier > wrote: >> Hi all, >> >> The documentation does not explain at all what means "sync" or "async" >> on pg_stat_replication. > > "potential"

Re: [HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-11-10 Thread Fujii Masao
On Wed, Nov 9, 2016 at 2:33 PM, Michael Paquier wrote: > Hi all, > > The documentation does not explain at all what means "sync" or "async" > on pg_stat_replication. "potential" state also should be explained? > The paragraph "Planning for high availability" >

[HACKERS] Adding in docs the meaning of pg_stat_replication.sync_state

2016-11-08 Thread Michael Paquier
Hi all, The documentation does not explain at all what means "sync" or "async" on pg_stat_replication. The paragraph "Planning for high availability" mentions "catchup" and "streaming", but it does not say that users can refer to it directly in pg_stat_replication. Thoughts about the patch