Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian writes:
> > > Tom Lane wrote:
> > >> I certainly hope that pg_regress isn't freeing the strings it passes
> > >> to putenv() ...
> >
> > > pg_regress does not restore these settings (it says with C/English) so
> > > the code is different.
>
Tom Lane wrote:
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> I certainly hope that pg_regress isn't freeing the strings it passes
> >> to putenv() ...
>
> > pg_regress does not restore these settings (it says with C/English) so
> > the code is different.
>
> That's not what I'm on about. Yo
Bruce Momjian writes:
> Tom Lane wrote:
>> I certainly hope that pg_regress isn't freeing the strings it passes
>> to putenv() ...
> pg_regress does not restore these settings (it says with C/English) so
> the code is different.
That's not what I'm on about. You're trashing strings that are par
Tom Lane wrote:
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> However, that's something for 9.1 and beyond. Bruce's immediate problem
> >> is what to do in pg_upgrade in 9.0, and there I concur that he should
> >> duplicate what pg_regress is doing.
>
> > OK, here is a patch that sets all the
Bruce Momjian writes:
> Tom Lane wrote:
>> However, that's something for 9.1 and beyond. Bruce's immediate problem
>> is what to do in pg_upgrade in 9.0, and there I concur that he should
>> duplicate what pg_regress is doing.
> OK, here is a patch that sets all the variables that pg_regress.c s
Tom Lane wrote:
> Alvaro Herrera writes:
> > Excerpts from Bruce Momjian's message of mi?? sep 01 16:35:18 -0400 2010:
> >> I have implemented your suggestion of setting LANG, LANGUAGE, and
> >> LC_MESSAGES based on code in pg_regress.c; that is the only place I see
> >> where we force English, a
Alvaro Herrera writes:
> Excerpts from Bruce Momjian's message of mié sep 01 16:35:18 -0400 2010:
>> I have implemented your suggestion of setting LANG, LANGUAGE, and
>> LC_MESSAGES based on code in pg_regress.c; that is the only place I see
>> where we force English, and it certainly has receiv
Excerpts from Bruce Momjian's message of mié sep 01 16:35:18 -0400 2010:
> I have implemented your suggestion of setting LANG, LANGUAGE, and
> LC_MESSAGES based on code in pg_regress.c; that is the only place I see
> where we force English, and it certainly has received more testing.
I think a r
Tom Lane wrote:
> Bruce Momjian writes:
> > Greg Sabino Mullane wrote:
> >> Specifically, LANGUAGE changes the headers of pg_controldata
> >> (but not the actual output, LC_ALL does that). Thanks for the
> >> nudge, I'll get to rewriting some code.
>
> > pg_upgrade does this in controldata.c fo
