Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-07 Thread Dimitri Fontaine
Tom Lane writes: > I'm not really convinced that it's worth the trouble though. Making > up those DATA lines is not the hardest part of making a new built-in No but it's cumbersome. I'd welcome simplification here, even if to be honest that itch isn't scratching me enough, some others are much

Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-07 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Greg Stark's message of jue mar 03 13:02:53 -0300 2011: >> But I'm not sure it's worth bothering. Filling in the description >> field is hardly the most annoying part of adding pg_proc entries for >> operators. If we could move most or all of the entries to a

Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-07 Thread Alvaro Herrera
Excerpts from Greg Stark's message of jue mar 03 13:02:53 -0300 2011: > But I'm not sure it's worth bothering. Filling in the description > field is hardly the most annoying part of adding pg_proc entries for > operators. If we could move most or all of the entries to an SQL file > so that we didn

Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-03 Thread Tom Lane
I wrote: > Robert Haas writes: >> "Deprecated, use instead"? Everybody seems happy with that part of the proposal, so I'll make it happen. >> I think the chances that future patches will follow the more complex >> coding rule are near zero, absent some type of automated enforcement >> mechanism

Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-03 Thread Greg Stark
On Thu, Mar 3, 2011 at 3:13 PM, Tom Lane wrote: > 1. Do people like the idea of marking obsolete operator names this > way?  If so, exactly how to mark them?  We could try to add > "(deprecated, ...)" at the end of the existing description, or just > replace the description completely.  In some of

Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-03 Thread Tom Lane
Robert Haas writes: > On Thu, Mar 3, 2011 at 10:13 AM, Tom Lane wrote: >> 2. Given that we do #1, is it really a good idea to generate the >> boilerplate comments automatically?  The argument I can see against it >> is that right now there's a pretty simple coding rule "every pg_proc.h >> entry s

Re: [HACKERS] Mark deprecated operators as such in their comments?

2011-03-03 Thread Robert Haas
On Thu, Mar 3, 2011 at 10:13 AM, Tom Lane wrote: > I finally got around to completing the function-comments cleanup > proposed here: > http://archives.postgresql.org/pgsql-docs/2010-10/msg00041.php > > There are now a heck of a lot of boilerplate comments like >        DESCR("implementation of + o

[HACKERS] Mark deprecated operators as such in their comments?

2011-03-03 Thread Tom Lane
I finally got around to completing the function-comments cleanup proposed here: http://archives.postgresql.org/pgsql-docs/2010-10/msg00041.php There are now a heck of a lot of boilerplate comments like DESCR("implementation of + operator"); in pg_proc.h (about 700 of 'em to be exact). My