Re: [HACKERS] Maximum reasonable bgwriter_delay

2007-06-20 Thread Greg Smith
On Tue, 19 Jun 2007, Heikki Linnakangas wrote: Simon Riggs wrote: Laptop mode? Linux has it... Granted, though you're still going to wake up every second, so I'm not sure how much it helps with battery life. In this context, Linux's laptop mode is all about keeping the disks from

Re: [HACKERS] Maximum reasonable bgwriter_delay

2007-06-20 Thread Tom Lane
Greg Smith [EMAIL PROTECTED] writes: I can't think of any good reason why the bgwriter_delay can't be reduced to 1s if that simplifies things. The simplification Heikki suggests would save a grand total of 9 lines of C code, two of which are braces. Is it really worth it to make such

[HACKERS] Maximum reasonable bgwriter_delay

2007-06-19 Thread Heikki Linnakangas
The maximum for bgwriter_delay is currently 10 seconds. That's a long time, and in fact if you set it to a value greater than 1 s, the sleep is split into 1 s intervals with a call to AbsorbFsyncRequests in between them. Is there a use case for a setting 1 s? We could simplify that logic a

Re: [HACKERS] Maximum reasonable bgwriter_delay

2007-06-19 Thread Simon Riggs
On Tue, 2007-06-19 at 15:53 +0100, Heikki Linnakangas wrote: The maximum for bgwriter_delay is currently 10 seconds. That's a long time, and in fact if you set it to a value greater than 1 s, the sleep is split into 1 s intervals with a call to AbsorbFsyncRequests in between them. Is

Re: [HACKERS] Maximum reasonable bgwriter_delay

2007-06-19 Thread Heikki Linnakangas
Simon Riggs wrote: On Tue, 2007-06-19 at 15:53 +0100, Heikki Linnakangas wrote: The maximum for bgwriter_delay is currently 10 seconds. That's a long time, and in fact if you set it to a value greater than 1 s, the sleep is split into 1 s intervals with a call to AbsorbFsyncRequests in