Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-28 Thread Robert Haas
On Wed, Apr 23, 2014 at 3:46 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: (2014/04/15 15:27), Etsuro Fujita wrote: (2014/04/14 23:53), Robert Haas wrote: On Fri, Apr 11, 2014 at 5:00 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is an updated version of the patch.

Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-23 Thread Etsuro Fujita
(2014/04/15 15:27), Etsuro Fujita wrote: (2014/04/14 23:53), Robert Haas wrote: On Fri, Apr 11, 2014 at 5:00 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is an updated version of the patch. I think the other changes deserve to be considered separately, and in particular I'm

Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-15 Thread Etsuro Fujita
(2014/04/14 23:53), Robert Haas wrote: On Fri, Apr 11, 2014 at 5:00 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is an updated version of the patch. I applied the first two hunks of this, which seem like clear oversights; and also the bit fixing the constraint_name language.

Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-14 Thread Robert Haas
On Fri, Apr 11, 2014 at 5:00 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is an updated version of the patch. I applied the first two hunks of this, which seem like clear oversights; and also the bit fixing the constraint_name language. I think the other changes deserve to be

Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-11 Thread Etsuro Fujita
(2014/04/09 12:03), Etsuro Fujita wrote: (2014/04/09 1:23), Robert Haas wrote: On Tue, Apr 8, 2014 at 5:05 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is a patch to improve the manual page for the ALTER TABLE command. Do we really need to add a section for type_name when we

[HACKERS] Minor improvements in alter_table.sgml

2014-04-08 Thread Etsuro Fujita
Attached is a patch to improve the manual page for the ALTER TABLE command. Thanks, Best regards, Etsuro Fujita diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml index 0b08f83..ce67c71 100644 --- a/doc/src/sgml/ref/alter_table.sgml +++

Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-08 Thread Robert Haas
On Tue, Apr 8, 2014 at 5:05 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is a patch to improve the manual page for the ALTER TABLE command. Do we really need to add a section for type_name when we already have a section for OF type_name? constraint_name is also used for adding

Re: [HACKERS] Minor improvements in alter_table.sgml

2014-04-08 Thread Etsuro Fujita
(2014/04/09 1:23), Robert Haas wrote: On Tue, Apr 8, 2014 at 5:05 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is a patch to improve the manual page for the ALTER TABLE command. Do we really need to add a section for type_name when we already have a section for OF type_name?