On Tue, Mar 29, 2016 at 11:20 PM, Tom Lane wrote:
> Christian Ullrich writes:
>> * Tom Lane wrote:
>>> But then, should not this code make sure that errno *always* gets set?
>
>> A library function that does not fail does not touch errno.
>
> Right, I meant "always in the error path".
>
>>> I'd b
Christian Ullrich writes:
> * Tom Lane wrote:
>> But then, should not this code make sure that errno *always* gets set?
> A library function that does not fail does not touch errno.
Right, I meant "always in the error path".
>> I'd be inclined to think we should use _dosmaperr(), too, rather th
* Tom Lane wrote:
Christian Ullrich writes:
Anyway, I think Michael's fix is wrong. The bug is that the Win32
version of link() (at the bottom of zic.c) does not set errno if its
attempt to copy the file fails, so what dolink() puts into link_errno is
bogus.
Ah-hah, that explains things ni
Christian Ullrich writes:
> Anyway, I think Michael's fix is wrong. The bug is that the Win32
> version of link() (at the bottom of zic.c) does not set errno if its
> attempt to copy the file fails, so what dolink() puts into link_errno is
> bogus.
Ah-hah, that explains things nicely. The pre
* Christian Ullrich wrote:
* Tom Lane wrote:
Christian Ullrich writes:
zic aborts somewhere between writing Etc/UTC and UTC.
Huh ... I would not have guessed that. Can you track down exactly
where it's failing?
I'd love to, but with 656ee84 I cannot reproduce on my Windows 10
system.
* Tom Lane wrote:
Christian Ullrich writes:
zic aborts somewhere between writing Etc/UTC and UTC.
Huh ... I would not have guessed that. Can you track down exactly
where it's failing?
I'd love to, but with 656ee84 I cannot reproduce on my Windows 10
system. I can try on the animals whe
On Mon, Mar 28, 2016 at 10:09 PM, Tom Lane wrote:
> Christian Ullrich writes:
>> * Tom Lane wrote:
>>> Yeah. I've been staring at that for awhile, but it's not clear where
>>> the problem is. There are a bunch of other SET TIME ZONE commands in
>>> the regression tests, how is it that this triv
Christian Ullrich writes:
> * Tom Lane wrote:
>> Yeah. I've been staring at that for awhile, but it's not clear where
>> the problem is. There are a bunch of other SET TIME ZONE commands in
>> the regression tests, how is it that this trivial case fails on the
>> Windows critters?
> zic aborts
On Tue, Mar 29, 2016 at 1:36 PM, Christian Ullrich wrote:
> * Tom Lane wrote:
>
>> Michael Paquier writes:
>>>
>>> Buildfarm-not-being-happy-status: woodloose, mastodon, thrips, jacana.
>>>
>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse&dt=2016-03-29%2000%3A42%3A08
>>> The o
* Tom Lane wrote:
Michael Paquier writes:
Buildfarm-not-being-happy-status: woodloose, mastodon, thrips, jacana.
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse&dt=2016-03-29%2000%3A42%3A08
The origin of the problem is that, which prevents all the subsequent
queries to fail:
On Tue, Mar 29, 2016 at 6:19 AM, Tom Lane wrote:
> Sync tzload() and tzparse() APIs with IANA release tzcode2016c.
>
> This brings us a bit closer to matching upstream, but since it affects
> files outside src/timezone/, we might choose not to back-patch it.
> Hence keep it separate from the main
11 matches
Mail list logo
