Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-11-26 Thread Haribabu kommi
On 24 November 2013 03:04 David Rowley wrote: I've done a quick benchmark on this this morning. Note that I'm using windows here and I used powershell to time the regression run with the following command: PS D:\Postgres\b\src\tools\msvc Measure-Command { .\vcregress.bat check } I ran the tests

Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-11-23 Thread David Rowley
On Thu, Oct 24, 2013 at 9:59 PM, Haribabu kommi haribabu.ko...@huawei.comwrote: Here I have added some more regression tests to improve the missing function coverage of schemacmds.c, user.c and tablespace.c. The added tests are mainly RENAME TO and OWNER TO support. I've just had a

Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-11-23 Thread Kevin Grittner
David Rowley dgrowle...@gmail.com wrote: I've just had a look at both of these patches. All tests that have been added seem to cover new areas that are not previously tested, they also seem to cleanup properly after themselves, so I think these should be a worthwhile addition to the

Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-11-23 Thread David Rowley
On Sun, Nov 24, 2013 at 6:37 AM, Kevin Grittner kgri...@ymail.com wrote: David Rowley dgrowle...@gmail.com wrote: I've just had a look at both of these patches. All tests that have been added seem to cover new areas that are not previously tested, they also seem to cleanup properly after

[HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-10-24 Thread Haribabu kommi
Here I have added some more regression tests to improve the missing function coverage of schemacmds.c, user.c and tablespace.c. The added tests are mainly RENAME TO and OWNER TO support. patches are attached in the mail. please check and provide your suggestions. Regards, Hari babu.

Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-10-24 Thread Michael Paquier
Hi, On Thu, Oct 24, 2013 at 5:59 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Here I have added some more regression tests to improve the missing function coverage of schemacmds.c, user.c and tablespace.c. The added tests are mainly RENAME TO and OWNER TO support. Could you add those