Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Andres Freund
On 2015-05-14 23:28:33 +0200, Andres Freund wrote: I've removed the use of GroupedVars and Andrew is right now working on structural changes. I'm not ready at this point to make a judgement. Andrew worked really hard and addressed the voiced concerns with the way chaining was done. In my last

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Joshua D. Drake
On 05/15/2015 12:32 PM, Josh Berkus wrote: Note that I am not proposing a general delay in feature freeze. I am specifically proposing an additional week for Grouping Sets and *only* for Grouping Sets. Core is in charge of releases. I believe like the other semi and formal organizations

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Jim Nasby
On 5/13/15 7:46 PM, Kouhei Kaigai wrote: * ctidscan as an example of custom-scan This basically hasn't gotten any attention, which may mean nobody cares enough to justify putting it in the tree. We need to either push it to next CF or reject altogether. Agreed. I was fine with never

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Jim Nasby
On 5/14/15 5:48 PM, Tom Lane wrote: True, but I have problems with leaders acting in a way that is unfair to those with less power. Have you considered how demoralizing it is to work in an unfair environment? Unfairness happens, but as leaders, we are supposed to try to avoid it, not cause it.

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Andres Freund
On 2015-05-13 11:38:27 -0400, Tom Lane wrote: Looking at what remains open in the current commitfest: As of now the remaining items !bugfix entries are: * GIN fillfactor I'd like to put this one on Heikki's plate as well, since he's touched the GIN code more than anyone else lately. While

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Michael Paquier
On Sat, May 16, 2015 at 11:00 AM, Andres Freund wrote: On 2015-05-13 11:38:27 -0400, Tom Lane wrote: * GIN fillfactor I'd like to put this one on Heikki's plate as well, since he's touched the GIN code more than anyone else lately. While sad, I think this is going to have to be moved.

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Tom Lane
Andres Freund and...@anarazel.de writes: I think we can close the commitfest now? Moving these three entries to the next one? Yeah, I don't think any of the remaining entries are committable. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Josh Berkus
On 05/14/2015 03:58 PM, Bruce Momjian wrote: On Thu, May 14, 2015 at 06:57:24PM -0400, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Bruce Momjian (br...@momjian.us) wrote: I will call for a vote that the freeze deadline be changed if this patch is rejected to due to time. I

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Andres Freund
On 2015-05-15 18:00:49 +0200, Andres Freund wrote: On 2015-05-14 23:28:33 +0200, Andres Freund wrote: I've removed the use of GroupedVars and Andrew is right now working on structural changes. I'm not ready at this point to make a judgement. Andrew worked really hard and addressed the

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Bruce Momjian
On Thu, May 14, 2015 at 05:10:29PM -0400, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: On 05/13/2015 11:38 AM, Tom Lane wrote: * Grouping Sets I had originally promised to be committer for this one, and still want to go look at it, but Robert's nearby message about not

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Bruce Momjian (br...@momjian.us) wrote: I will call for a vote that the freeze deadline be changed if this patch is rejected to due to time. I might lose the vote, but I am going to try because if we lose our reputation for fairness, we have lost a

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Bruce Momjian
On Thu, May 14, 2015 at 11:28:33PM +0200, Andres Freund wrote: On 2015-05-14 17:10:29 -0400, Tom Lane wrote: FWIW, I did go look at this patch, and concluded it was not close enough to ready to try to squeeze it in now. (I think Andres isn't convinced of that yet, but time grows short, and

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: On Thu, May 14, 2015 at 11:28:33PM +0200, Andres Freund wrote: On 2015-05-14 17:10:29 -0400, Tom Lane wrote: FWIW, I did go look at this patch, and concluded it was not close enough to ready to try to squeeze it in now. (I think Andres isn't

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Robert Haas
On Thu, May 14, 2015 at 6:03 PM, Peter Geoghegan p...@heroku.com wrote: On Thu, May 14, 2015 at 2:28 PM, Andres Freund and...@anarazel.de wrote: On 2015-05-14 17:10:29 -0400, Tom Lane wrote: FWIW, I did go look at this patch, and concluded it was not close enough to ready to try to squeeze it

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Robert Haas
On Thu, May 14, 2015 at 5:54 PM, Bruce Momjian br...@momjian.us wrote: Life is unfair. True, but I have problems with leaders acting in a way that is unfair to those with less power. Have you considered how demoralizing it is to work in an unfair environment? Unfairness happens, but as

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Bruce Momjian
On Thu, May 14, 2015 at 06:57:24PM -0400, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Bruce Momjian (br...@momjian.us) wrote: I will call for a vote that the freeze deadline be changed if this patch is rejected to due to time. I might lose the vote, but I am going to try

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 05/13/2015 11:38 AM, Tom Lane wrote: * Grouping Sets I had originally promised to be committer for this one, and still want to go look at it, but Robert's nearby message about not committing stuff in haste definitely seems to apply. That makes

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, May 14, 2015 at 05:10:29PM -0400, Tom Lane wrote: The good news on this front is that Salesforce has recently taken an interest in having GROUPING SETS capability, so I should be able to find more time to work on this over the next month or two.

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Peter Geoghegan
On Thu, May 14, 2015 at 2:28 PM, Andres Freund and...@anarazel.de wrote: On 2015-05-14 17:10:29 -0400, Tom Lane wrote: FWIW, I did go look at this patch, and concluded it was not close enough to ready to try to squeeze it in now. (I think Andres isn't convinced of that yet, but time grows

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Bruce Momjian
On Thu, May 14, 2015 at 05:37:07PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, May 14, 2015 at 05:10:29PM -0400, Tom Lane wrote: The good news on this front is that Salesforce has recently taken an interest in having GROUPING SETS capability, so I should be able to

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, May 14, 2015 at 05:37:07PM -0400, Tom Lane wrote: [ shrug... ] Andrew had unilaterally removed me as committer from that patch back in January or so, so it dropped way down my priority list. I'm willing to move it back up now, but I could do

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Andres Freund
On 2015-05-14 17:10:29 -0400, Tom Lane wrote: FWIW, I did go look at this patch, and concluded it was not close enough to ready to try to squeeze it in now. (I think Andres isn't convinced of that yet, but time grows short, and I quite agree with Robert that committing almost-ready patches at

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-14 Thread Gavin Flower
On 15/05/15 10:58, Bruce Momjian wrote: On Thu, May 14, 2015 at 06:57:24PM -0400, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Bruce Momjian (br...@momjian.us) wrote: I will call for a vote that the freeze deadline be changed if this patch is rejected to due to time. I might

[HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Tom Lane
Looking at what remains open in the current commitfest: * fsync $PGDATA recursively at startup Andres is the reviewer of record on this one. He should either commit it if he feels it's ready, or bounce it to next CF if not. * EvalPlanQual behaves oddly for FDW queries involving system columns

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Stephen Frost
Tom, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: * Optimization for updating foreign tables in Postgres FDW I concur with Stephen's assessment that this doesn't look well designed. I think we should just mark it RWF for now. I had meant to do that already, sorry about that, done now. *

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Andrew Dunstan
On 05/13/2015 11:38 AM, Tom Lane wrote: * Grouping Sets I had originally promised to be committer for this one, and still want to go look at it, but Robert's nearby message about not committing stuff in haste definitely seems to apply. That makes me sad. I wish you would still try. Sadly,

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Tom Lane
I wrote: * Cube extension kNN support This is still marked as needs review, I'm afraid we have to push to 9.6. * compress method for spgist Sigh. There was a Ditto under this one, but somehow it disappeared in editing :-( regards, tom lane -- Sent via

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Wed, May 13, 2015 at 11:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: * Additional role attributes Is this ready to commit? Stephen's call. -1 for committing this, per discussion earlier today on a thread that's probably not linked into the

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-05-13 11:38:27 -0400, Tom Lane wrote: * Manipulating complex types as non-contiguous structures in-memory This one's mine of course. I've been hoping to get more independent performance testing than it's gotten, but time grows short. I'm

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Robert Haas
On Wed, May 13, 2015 at 11:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: * fsync $PGDATA recursively at startup Andres is the reviewer of record on this one. He should either commit it if he feels it's ready, or bounce it to next CF if not. I committed the first part of this as

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Petr Jelinek
On 13/05/15 17:38, Tom Lane wrote: * Sequence Access Method Heikki's marked as reviewer, so it's his call as to whether this is ready, but the impression I have is that there's not really consensus as to whether the API is good. If not, it's something I think we should push to 9.6. Heikki

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Kouhei Kaigai
* ctidscan as an example of custom-scan This basically hasn't gotten any attention, which may mean nobody cares enough to justify putting it in the tree. We need to either push it to next CF or reject altogether. Agreed. I was fine with never committing this. I don't think we have

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-05-13 11:38:27 -0400, Tom Lane wrote: * parallel mode/contexts Robert's patch, his to deal with (likewise for assessing parallel-safety). Just as a note, a large part of this has been committed. Right, and Robert commented that he isn't

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Andres Freund
On 2015-05-13 11:38:27 -0400, Tom Lane wrote: * parallel mode/contexts Robert's patch, his to deal with (likewise for assessing parallel-safety). Just as a note, a large part of this has been committed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Robert Haas
On Wed, May 13, 2015 at 1:06 PM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@anarazel.de writes: On 2015-05-13 11:38:27 -0400, Tom Lane wrote: * parallel mode/contexts Robert's patch, his to deal with (likewise for assessing parallel-safety). Just as a note, a large part of this

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Andres Freund
On 2015-05-13 11:38:27 -0400, Tom Lane wrote: Looking at what remains open in the current commitfest: * fsync $PGDATA recursively at startup Andres is the reviewer of record on this one. He should either commit it if he feels it's ready, or bounce it to next CF if not. The more important