Re: [HACKERS] Typos in src/backend/optimizer/README

On 2017/10/28 18:15, Robert Haas wrote: On Fri, Oct 27, 2017 at 9:34 AM, Etsuro Fujita wrote: This sentence in the section of Partition-wise joins in src/backend/optimizer/README should be fixed: "This technique of breaking down a join between partition tables into join between their partitions

Re: [HACKERS] Typos in src/backend/optimizer/README

On Fri, Oct 27, 2017 at 9:34 AM, Etsuro Fujita wrote: > This sentence in the section of Partition-wise joins in > src/backend/optimizer/README should be fixed: "This technique of breaking > down a join between partition tables into join between their partitions is > called partition-wise join." >

[HACKERS] Typos in src/backend/optimizer/README

Hi, This sentence in the section of Partition-wise joins in src/backend/optimizer/README should be fixed: "This technique of breaking down a join between partition tables into join between their partitions is called partition-wise join." (1) s/a join between partition tables/a join between p

Re: [HACKERS] Typos in comments

On Sat, Jun 17, 2017 at 8:55 AM, Daniel Gustafsson wrote: > Spotted one “paramter” typo and git grep found two more, patch attached > with > s/paramter/parameter/ for these. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redp

[HACKERS] Typos in comments

Spotted one “paramter” typo and git grep found two more, patch attached with s/paramter/parameter/ for these. cheers ./daniel typo-paramter.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.pos

Re: [HACKERS] Typos in pg_basebackup.c

On Mon, May 15, 2017 at 7:02 AM, Michael Paquier wrote: > Hi all, > > Found $subject while working on the area. A patch is attached. > Thanks, > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

[HACKERS] Typos in pg_basebackup.c

Hi all, Found $subject while working on the area. A patch is attached. Thanks, -- Michael basebackup-typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typos in comments in execMain.c

On Tue, May 9, 2017 at 4:26 AM, Etsuro Fujita wrote: > Here is a small patch to fix typos in comments for InitResultRelInfo() in > execMain.c: s/ResultRelationInfo/ResultRelInfo/ and s/the the/the/. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Co

[HACKERS] Typos in comments in execMain.c

Hi, Here is a small patch to fix typos in comments for InitResultRelInfo() in execMain.c: s/ResultRelationInfo/ResultRelInfo/ and s/the the/the/. Best regards, Etsuro Fujita diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 5c12fb4..2e9fb0e 100644 --- a/src/

Re: [HACKERS] Typos in comments in partition.c

On Tue, May 2, 2017 at 5:58 AM, Etsuro Fujita wrote: > I ran into typos in comments in RelationGetPartitionDispatchInfo() in > partition.c. Here is a small patch for: s/all the leaf partition/all the > leaf partitions/ and s/we we/we/. Committed. -- Robert Haas EnterpriseDB: http://www.enterpr

[HACKERS] Typos in comments in partition.c

Hi, I ran into typos in comments in RelationGetPartitionDispatchInfo() in partition.c. Here is a small patch for: s/all the leaf partition/all the leaf partitions/ and s/we we/we/. Best regards, Etsuro Fujita diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c in

Re: [HACKERS] Typos in waldender.c and slot.c

On Sat, Dec 17, 2016 at 2:08 PM, Michael Paquier wrote: > Hi all, > > While going through the temporary replication slot commits, I have > noticed two typos as attached. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Typos in waldender.c and slot.c

Hi all, While going through the temporary replication slot commits, I have noticed two typos as attached. Thanks, -- Michael slot-typos.patch Description: application/download -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://ww

Re: [HACKERS] Typos in logical decoding

On Mon, Jul 18, 2016 at 11:00 AM, Antonin Houska wrote: > While reading the logical decoding code I noticed a few supposedly mistyped > comments, see the diff below. > Applied, thanks. > Besides that, output_plugin_options argument of CreateInitDecodingContext > function is unused, and the fu

[HACKERS] Typos in logical decoding

While reading the logical decoding code I noticed a few supposedly mistyped comments, see the diff below. Besides that, output_plugin_options argument of CreateInitDecodingContext function is unused, and the function passes NIL to the corresponding argument of StartupDecodingContext. This looks to

Re: [HACKERS] Typos/Questions in bloom documentation

On 2016/06/07 14:41, Michael Paquier wrote: > On Fri, Apr 22, 2016 at 1:25 AM, David G. Johnston > wrote: >> On Wed, Apr 20, 2016 at 9:18 PM, Amit Langote >> wrote: >>> I agree it's unclear. Does the following make it any better (updated >>> patch attached): > > I have sent a patch to rework th

Re: [HACKERS] Typos/Questions in bloom documentation

On Fri, Apr 22, 2016 at 1:25 AM, David G. Johnston wrote: > On Wed, Apr 20, 2016 at 9:18 PM, Amit Langote > wrote: >> I agree it's unclear. Does the following make it any better (updated >> patch attached): I have sent a patch to rework the docs here: http://www.postgresql.org/message-id/cab7np

Re: [HACKERS] Typos in plannodes.h

On 2015/10/21 0:13, Robert Haas wrote: On Tue, Oct 20, 2015 at 7:45 AM, Etsuro Fujita wrote: I found typos in plannodes.h: s/scan.plan.quals/scan.plan.qual/g Please find attached a patch. Oops. Good catch. Committed. Thanks for picking this up! Best regards, Etsuro Fujita -- Sent vi

Re: [HACKERS] Typos in plannodes.h

On Tue, Oct 20, 2015 at 7:45 AM, Etsuro Fujita wrote: > I found typos in plannodes.h: s/scan.plan.quals/scan.plan.qual/g Please > find attached a patch. Oops. Good catch. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsq

[HACKERS] Typos in plannodes.h

Hi, I found typos in plannodes.h: s/scan.plan.quals/scan.plan.qual/g Please find attached a patch. Best regards, Etsuro Fujita diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h index 92fd8e4..6b28c8e 100644 --- a/src/include/nodes/plannodes.h +++ b/src/include/nodes/plan

Re: [HACKERS] Typos in CREATE TABLE doc

On 2015/03/21 5:58, Bruce Momjian wrote: On Thu, Nov 13, 2014 at 08:30:49PM +0900, Etsuro Fujita wrote: (2014/11/13 20:07), Heikki Linnakangas wrote: On 11/13/2014 12:45 PM, Etsuro Fujita wrote: It seems to me there are typos in the reference page for CREATE TABLE. The structure of the sente

Re: [HACKERS] Typos in CREATE TABLE doc

On Thu, Nov 13, 2014 at 08:30:49PM +0900, Etsuro Fujita wrote: > (2014/11/13 20:07), Heikki Linnakangas wrote: > > On 11/13/2014 12:45 PM, Etsuro Fujita wrote: > >> It seems to me there are typos in the reference page for CREATE TABLE. > > > > The structure of the sentence is a bit funky, but it s

Re: [HACKERS] Typos in CREATE TABLE doc

(2014/11/13 20:07), Heikki Linnakangas wrote: > On 11/13/2014 12:45 PM, Etsuro Fujita wrote: >> It seems to me there are typos in the reference page for CREATE TABLE. > > The structure of the sentence is a bit funky, but it seems correct to > me. If you google for "should any", you'll get a bunch

Re: [HACKERS] Typos in CREATE TABLE doc

On 11/13/2014 12:45 PM, Etsuro Fujita wrote: > It seems to me there are typos in the reference page for CREATE TABLE. The structure of the sentence is a bit funky, but it seems correct to me. If you google for "should any", you'll get a bunch of pages discussing similar sentences. I would add a c

[HACKERS] Typos in CREATE TABLE doc

It seems to me there are typos in the reference page for CREATE TABLE. Please find attached a patch. Thanks, Best regards, Etsuro Fujita diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml index 299cce8..ebcb885 100644 --- a/doc/src/sgml/ref/create_table.sgml +++

Re: [HACKERS] Typos in comments

On Mon, Oct 20, 2014 at 3:04 AM, David Rowley wrote: > On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita > wrote: >> I ran into a type " a a " in a comment in snapmgr.c, and found that >> there are four other places that've made the same typo, by the grep >> command. And in one of those places, I f

Re: [HACKERS] Typos in comments

On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita wrote: > I ran into a type " a a " in a comment in snapmgr.c, and found that > there are four other places that've made the same typo, by the grep > command. And in one of those places, I found yet another typo. Please > find attached a patch. > >

[HACKERS] Typos in comments

I ran into a type " a a " in a comment in snapmgr.c, and found that there are four other places that've made the same typo, by the grep command. And in one of those places, I found yet another typo. Please find attached a patch. Thanks, Best regards, Etsuro Fujita diff --git a/src/backend/utils

Re: [HACKERS] typos

On 03/24/2014 08:40 AM, Erik Rijkers wrote: A few 'the the' typos in code & docs. Thanks, fixed. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] typos

A few 'the the' typos in code & docs.--- src/backend/access/transam/xlog.c.orig 2014-03-23 22:43:44.864504319 +0100 +++ src/backend/access/transam/xlog.c 2014-03-23 22:44:02.735634100 +0100 @@ -1089,7 +1089,7 @@ * has progressed. There is a small fixed number of insertion locks, * determined

Re: [HACKERS] Typos

On 30.03.2011 08:34, Fujii Masao wrote: The attached patch fixes two typos. Thanks, applied. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.o

[HACKERS] Typos

Hi, The attached patch fixes two typos. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center typos_v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] typos in HS source code comment

On Thu, Aug 12, 2010 at 9:37 PM, Fujii Masao wrote: > Before 9.0, since xact_redo_commit always calls TransactionIdCommitTree, > TransactionIdSetStatusBit always receives InvalidXLogRecPtr. In 9.0, > xact_redo_commit calls TransactionIdCommitTree only when hot standby is > disabled. OTOH, when hot

Re: [HACKERS] typos in HS source code comment

On Fri, Aug 13, 2010 at 8:28 AM, Robert Haas wrote: > I've committed all of this except for the following, which I'm not > certain is correct: Thanks for the commit. > --- a/src/backend/access/transam/clog.c > +++ b/src/backend/access/transam/clog.c > @@ -355,10 +355,10 @@ TransactionIdSetStatus

Re: [HACKERS] typos in HS source code comment

On Thu, Aug 12, 2010 at 5:02 AM, Fujii Masao wrote: > When I was enjoying reading the HS source code, > I found some typos. Attached patch fixes them. I've committed all of this except for the following, which I'm not certain is correct: --- a/src/backend/access/transam/clog.c +++ b/src/backend/

[HACKERS] typos in HS source code comment

Hi, When I was enjoying reading the HS source code, I found some typos. Attached patch fixes them. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center hs_typo_v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hacke

Re: [HACKERS] typos in source comment

Fujii Masao wrote: Here're the patches to fix typos in source comment. typo_postgres.patch should be backported to v8.2 and v8.3. Thanks, applied. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] typos in source comment

Hi, Here're the patches to fix typos in source comment. typo_postgres.patch should be backported to v8.2 and v8.3. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center typo_pgstandby.patch Description: Binary data typo_postgres.patch Description