Re: [HACKERS] Unused member root in foreign_glob_cxt

2017-01-13 Thread Tom Lane
Ashutosh Bapat writes: > On Thu, Jan 12, 2017 at 6:39 PM, Tom Lane wrote: >> I think you'd just end up putting it back at some point. It's the only >> means that foreign_expr_walker() has for getting at the root pointer, >> and nearly all planner code needs that. Seems to me it's just chance >>

Re: [HACKERS] Unused member root in foreign_glob_cxt

2017-01-12 Thread Ashutosh Bapat
On Thu, Jan 12, 2017 at 6:39 PM, Tom Lane wrote: > Ashutosh Bapat writes: >> The member root in foreign_glob_cxt isn't used anywhere by >> postgres_fdw code. Without that member the code compiles and >> regression passes. The member was added by d0d75c40. I looked at that >> commit briefly but di

Re: [HACKERS] Unused member root in foreign_glob_cxt

2017-01-12 Thread Tom Lane
Ashutosh Bapat writes: > The member root in foreign_glob_cxt isn't used anywhere by > postgres_fdw code. Without that member the code compiles and > regression passes. The member was added by d0d75c40. I looked at that > commit briefly but did not find any code using it there. So, possibly > it's

[HACKERS] Unused member root in foreign_glob_cxt

2017-01-12 Thread Ashutosh Bapat
Hi, The member root in foreign_glob_cxt isn't used anywhere by postgres_fdw code. Without that member the code compiles and regression passes. The member was added by d0d75c40. I looked at that commit briefly but did not find any code using it there. So, possibly it's unused since it was introduced