Re: [HACKERS] Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

2014-03-31 Thread Robert Haas
On Wed, Mar 26, 2014 at 11:23 PM, Amit Kapila wrote: > On Thu, Mar 27, 2014 at 1:39 AM, Robert Haas wrote: >> On Mon, Mar 24, 2014 at 9:02 PM, Amit Kapila wrote: >>> MarkBufferDirty() always increment BufferUsage counter >>> (shared_blks_dirtied) for dirty blocks whenever it dirties any >>> bloc

Re: [HACKERS] Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

2014-03-26 Thread Amit Kapila
On Thu, Mar 27, 2014 at 1:39 AM, Robert Haas wrote: > On Mon, Mar 24, 2014 at 9:02 PM, Amit Kapila wrote: >> MarkBufferDirty() always increment BufferUsage counter >> (shared_blks_dirtied) for dirty blocks whenever it dirties any >> block, whereas same is not true for MarkBufferDirtyHint(). >> Is

Re: [HACKERS] Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

2014-03-26 Thread Robert Haas
On Mon, Mar 24, 2014 at 9:02 PM, Amit Kapila wrote: > MarkBufferDirty() always increment BufferUsage counter > (shared_blks_dirtied) for dirty blocks whenever it dirties any > block, whereas same is not true for MarkBufferDirtyHint(). > Is there any particular reason for not incrementing > shared_

Re: [HACKERS] Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

2014-03-25 Thread Amit Kapila
On Tue, Mar 25, 2014 at 9:32 AM, Amit Kapila wrote: > MarkBufferDirty() always increment BufferUsage counter > (shared_blks_dirtied) for dirty blocks whenever it dirties any > block, whereas same is not true for MarkBufferDirtyHint(). > Is there any particular reason for not incrementing > shared_

[HACKERS] Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

2014-03-24 Thread Amit Kapila
MarkBufferDirty() always increment BufferUsage counter (shared_blks_dirtied) for dirty blocks whenever it dirties any block, whereas same is not true for MarkBufferDirtyHint(). Is there any particular reason for not incrementing shared_blks_dirtied in MarkBufferDirtyHint()? With Regards, Amit Ka