Re: [HACKERS] cache invalidation skip logic

2015-08-10 Thread Qingqing Zhou
On Sun, Aug 9, 2015 at 8:24 AM, Robert Haas wrote: > > In step 1, AcceptInvalidationMessages() should process all pending > invalidation messages. So if step 2 did AcceptInvalidationMessages() > again it would be a no-op, because no messages should remain at that > point. > That's what I think a

Re: [HACKERS] cache invalidation skip logic

2015-08-09 Thread Robert Haas
On Thu, Aug 6, 2015 at 2:19 PM, Qingqing Zhou wrote: > In cache invalidation logic, we have the following comment: > > /* > * Now that we have the lock, check for invalidation messages, so that we > * will update or flush any stale relcache entry before we try to use it. > * RangeVarGetRelid() spe

[HACKERS] cache invalidation skip logic

2015-08-06 Thread Qingqing Zhou
In cache invalidation logic, we have the following comment: /* * Now that we have the lock, check for invalidation messages, so that we * will update or flush any stale relcache entry before we try to use it. * RangeVarGetRelid() specifically relies on us for this. We can skip * this in the not-u