Re: [HACKERS] contrib uninstall scripts need some love
Joshua D. Drake wrote: Guido Barosio wrote: Let me know if you need an extra pair of eyes. O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... OK, are all the uninstall scripts done? --- Joshua D. Drake G.- On 9/10/06, Joshua D. Drake [EMAIL PROTECTED] wrote: Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course. O.k., I will start working through it and report at the end of the week. Joshua D. Drake regards, tom lane -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [HACKERS] contrib uninstall scripts need some love
Bruce Momjian wrote: Joshua D. Drake wrote: Guido Barosio wrote: Let me know if you need an extra pair of eyes. O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... OK, are all the uninstall scripts done? Crap... yes they are, at least the ones I know about. I will submit a patch again -HEAD today. Joshua D. Drake --- Joshua D. Drake G.- On 9/10/06, Joshua D. Drake [EMAIL PROTECTED] wrote: Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course. O.k., I will start working through it and report at the end of the week. Joshua D. Drake regards, tom lane -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] contrib uninstall scripts need some love
Guido Barosio wrote: Let me know if you need an extra pair of eyes. O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... Joshua D. Drake G.- On 9/10/06, Joshua D. Drake [EMAIL PROTECTED] wrote: Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course. O.k., I will start working through it and report at the end of the week. Joshua D. Drake regards, tom lane -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [HACKERS] contrib uninstall scripts need some love
Joshua D. Drake [EMAIL PROTECTED] writes: O.k. I do :) Writing the scripts up are easy enough, but I am unsure how the whole make file foo works... About all you have to do is add the uninstall script to the DATA = line in the makefile. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [HACKERS] contrib uninstall scripts need some love
Joshua D. Drake [EMAIL PROTECTED] writes: I have seen some patches come across with this. Is this done, or do I still need to work on it? Teodor added an uninstall for hstore, and I think Michael has fixed all the problems in the existing scripts, but we still lack uninstall scripts for the other modules I mentioned. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[HACKERS] contrib uninstall scripts need some love
Awhile back, someone went around and made sure that all the contrib modules had uninstall scripts, but most of the new contributions since then don't have 'em: adminpack hstore pg_freespacemap pgrowlocks sslinfo all seem to need one. Also, I tested a few of the existing uninstall scripts in passing while fixing the contains/contained mess, and two out of four were broken (failed to remove everything installed by the module, as shown by getting errors if you then try to reinstall it). Seems like this area needs more attention ... anyone want to work on it? regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [HACKERS] contrib uninstall scripts need some love
Tom Lane wrote: Awhile back, someone went around and made sure that all the contrib modules had uninstall scripts, but most of the new contributions since then don't have 'em: adminpack hstore pg_freespacemap pgrowlocks sslinfo all seem to need one. Also, I tested a few of the existing uninstall scripts in passing while fixing the contains/contained mess, and two out of four were broken (failed to remove everything installed by the module, as shown by getting errors if you then try to reinstall it). Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Joshua D. Drake regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [HACKERS] contrib uninstall scripts need some love
On Sun, Sep 10, 2006 at 12:09:24PM -0700, Joshua D. Drake wrote: Tom Lane wrote: Awhile back, someone went around and made sure that all the contrib modules had uninstall scripts, but most of the new contributions since then don't have 'em: adminpack hstore pg_freespacemap pgrowlocks sslinfo all seem to need one. Also, I tested a few of the existing uninstall scripts in passing while fixing the contains/contained mess, and two out of four were broken (failed to remove everything installed by the module, as shown by getting errors if you then try to reinstall it). Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? For reference, here are some comments about the cleanup work I did a while back: http://archives.postgresql.org/pgsql-patches/2006-03/msg00163.php -- Michael Fuhr ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [HACKERS] contrib uninstall scripts need some love
Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course. regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [HACKERS] contrib uninstall scripts need some love
Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course. O.k., I will start working through it and report at the end of the week. Joshua D. Drake regards, tom lane -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [HACKERS] contrib uninstall scripts need some love
Let me know if you need an extra pair of eyes. G.- On 9/10/06, Joshua D. Drake [EMAIL PROTECTED] wrote: Tom Lane wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this area needs more attention ... anyone want to work on it? I'll take it. How long do I have? Since it's contrib, I don't think we need to hold you to being done before beta1. But the sooner the better of course. O.k., I will start working through it and report at the end of the week. Joshua D. Drake regards, tom lane -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match -- Guido Barosio --- http://www.globant.com [EMAIL PROTECTED] ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] contrib uninstall scripts need some love
On Sun, Sep 10, 2006 at 01:50:39PM -0700, Joshua D. Drake wrote: O.k., I will start working through it and report at the end of the week. I spent a few minutes doing the same tests I did a few months ago and found problems with dblink and ltree; I'll submit patches for those. Tom, do you recall which modules gave you trouble? -- Michael Fuhr ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [HACKERS] contrib uninstall scripts need some love
Michael Fuhr [EMAIL PROTECTED] writes: I spent a few minutes doing the same tests I did a few months ago and found problems with dblink and ltree; I'll submit patches for those. Tom, do you recall which modules gave you trouble? Um ... hstore and tsearch2, I think. I fixed those, but was thinking that other stuff might crawl out from under similar rocks. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [HACKERS] contrib uninstall scripts need some love
On Sun, Sep 10, 2006 at 07:38:24PM -0400, Tom Lane wrote: Michael Fuhr [EMAIL PROTECTED] writes: I spent a few minutes doing the same tests I did a few months ago and found problems with dblink and ltree; I'll submit patches for those. Tom, do you recall which modules gave you trouble? Um ... hstore and tsearch2, I think. I fixed those, but was thinking that other stuff might crawl out from under similar rocks. I don't see an uninstall script for hstore; that one needs to be written. The latest untsearch2.sql looks good in my tests. Should untsearch2.sql be renamed to uninstall_tsearch2.sql to be consistent with all the other uninstall scripts? -- Michael Fuhr ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [HACKERS] contrib uninstall scripts need some love
Michael Fuhr [EMAIL PROTECTED] writes: Should untsearch2.sql be renamed to uninstall_tsearch2.sql to be consistent with all the other uninstall scripts? Yeah, that and lo_drop are outliers that probably ought to be renamed. Offhand I don't see any serious compatibility objection --- who does module removals except by hand? --- but if anyone sees a problem speak now ... I'm also wondering why the heck contrib/lo installs lo_test.sql. That ought to be a regression test anyway, and we don't install regression scripts. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
