On Mon, Oct 7, 2013 at 9:32 AM, Andres Freund and...@2ndquadrant.com wrote:
- RelationIsDoingTimetravel is still a crappy name. How about
RelationRequiredForLogicalDecoding? And maybe the reloption
treat_as_catalog_table can become required_for_logical_decoding.
Hm. I don't really like the
On 10/07/2013 09:32 AM, Andres Freund wrote:
Todo:
* rename treat_as_catalog_table, after agreeing on the new name
* rename remaining timetravel function names
* restrict SuspendDecodingSnapshots usage to RelationInitPhysicalAddr,
that ought to be enough.
* add InLogicalDecoding() function.
*
On 2013-10-08 15:02:39 -0400, Steve Singer wrote:
On 10/07/2013 09:32 AM, Andres Freund wrote:
Todo:
* rename treat_as_catalog_table, after agreeing on the new name
* rename remaining timetravel function names
* restrict SuspendDecodingSnapshots usage to RelationInitPhysicalAddr,
that
On 2013-10-08 12:20:22 -0400, Robert Haas wrote:
On Mon, Oct 7, 2013 at 9:32 AM, Andres Freund and...@2ndquadrant.com wrote:
- RelationIsDoingTimetravel is still a crappy name. How about
RelationRequiredForLogicalDecoding? And maybe the reloption
treat_as_catalog_table can become
On 2013-10-02 10:56:38 -0400, Robert Haas wrote:
On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-10-01 10:07:19 -0400, Robert Haas wrote:
- It seems that HeapSatisfiesHOTandKeyUpdate is now
HeapSatisfiesHOTandKeyandCandidateKeyUpdate. Considering I think
On Wed, Oct 2, 2013 at 11:05 AM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-10-02 10:56:38 -0400, Robert Haas wrote:
On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-10-01 10:07:19 -0400, Robert Haas wrote:
- It seems that
On 2013-10-02 11:06:59 -0400, Robert Haas wrote:
On Wed, Oct 2, 2013 at 11:05 AM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-10-02 10:56:38 -0400, Robert Haas wrote:
On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund and...@2ndquadrant.com
wrote:
On 2013-10-01 10:07:19 -0400, Robert
On Tue, Oct 1, 2013 at 1:56 PM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-10-01 10:07:19 -0400, Robert Haas wrote:
- It seems that HeapSatisfiesHOTandKeyUpdate is now
HeapSatisfiesHOTandKeyandCandidateKeyUpdate. Considering I think this
was merely HeapSatisfiesHOTUpdate a year ago,
Review comments on 0004:
- In heap_insert and heap_multi_insert, please rewrite the following
comment for clarity: add record for the buffer without actual content
thats removed if fpw is done for that buffer.
- In heap_delete, the assignment to need_tuple_data() need not
separately check
Hi,
On 2013-10-01 10:07:19 -0400, Robert Haas wrote:
- AssignTransactionId changes Mustn't to May not, which seems like
an entirely pointless change.
It was Musn't before ;). I am not sure why I changed it to May not
instead of Mustn't.
- Do none of the callers of IsSystemRelation() care
On Tue, Oct 1, 2013 at 10:31 AM, Andres Freund and...@2ndquadrant.com wrote:
I have no problem with caching the primary key in the relcache, or
with using that as the default key for logical decoding, but I'm
extremely uncomfortable with the fallback strategy when no primary key
exists.
On 2013-10-01 10:07:19 -0400, Robert Haas wrote:
- It seems that HeapSatisfiesHOTandKeyUpdate is now
HeapSatisfiesHOTandKeyandCandidateKeyUpdate. Considering I think this
was merely HeapSatisfiesHOTUpdate a year ago, it's hard not to be
afraid that something unscalable is happening to this
Andres Freund and...@2ndquadrant.com wrote:
Attached you can find an updated version of the series taking in some of
the review comments
I don't know whether this is related to the previously-reported
build problems, but when I apply each patch in turn, with make -j4
world make check-world
On 09/27/2013 11:44 AM, Andres Freund wrote:
I'm encountering a make error:
Gah. Lastminute changes. Always the same... Updated patch attached.
Greetings,
Andres Freund
I'm still encountering an error in the make.
make clean
.
.make[3]: Entering directory
Steve Singer wrote:
I'm still encountering an error in the make.
make clean
.
.make[3]: Entering directory
`/usr/local/src/postgresql/src/bin/pg_basebackup'
rm -f pg_basebackup pg_receivexlog pg_recvlogical(X) \
pg_basebackup.o pg_receivexlog.o pg_recvlogical.o \
On 27 September 2013 16:14, Andres Freund and...@2ndquadrant.com wrote:
Hi,
Attached you can find an updated version of the series taking in some of
the review comments (the others are queued, not ignored), including:
* split of things from the big Introduce wal decoding via ... patch
* fix
On 2013-09-27 16:35:53 +0100, Thom Brown wrote:
On 27 September 2013 16:14, Andres Freund and...@2ndquadrant.com wrote:
Hi,
Attached you can find an updated version of the series taking in some of
the review comments (the others are queued, not ignored), including:
* split of things
17 matches
Mail list logo
