Re: [HACKERS] logical decoding doc
On Tue, Mar 18, 2014 at 7:27 PM, Tatsuo Ishii wrote: > Maybe this is to demonstrating "peek ahead" does not consume changes, > but IMO this is a little bit confusing for readers and I think there's > a room to enhance the second sql session comment for example: I didn't write that text, but yeah, that was my interpretation of why it was like that. > postgres=# -- Again you can also peek ahead in the change stream without > consuming changes I don't especially like that particular text, but perhaps it could be made more clear in some way. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] logical decoding doc
It seems two exactly same sql sessions are repeated in logicaldecoding.sgml. Is this intended? postgres=# -- You can also peek ahead in the change stream without consuming changes postgres=# SELECT * FROM pg_logical_slot_peek_changes('regression_slot', NULL, NULL); location | xid | data ---+-+--- 0/16E09C0 | 690 | BEGIN 690 0/16E09C0 | 690 | table public.data: INSERT: id[integer]:3 data[text]:'3' 0/16E0B90 | 690 | COMMIT 690 (3 rows) postgres=# -- You can also peek ahead in the change stream without consuming changes postgres=# SELECT * FROM pg_logical_slot_peek_changes('regression_slot', NULL, NULL); location | xid | data ---+-+--- 0/16E09C0 | 690 | BEGIN 690 0/16E09C0 | 690 | table public.data: INSERT: id[integer]:3 data[text]:'3' 0/16E0B90 | 690 | COMMIT 690 (3 rows) Maybe this is to demonstrating "peek ahead" does not consume changes, but IMO this is a little bit confusing for readers and I think there's a room to enhance the second sql session comment for example: postgres=# -- Again you can also peek ahead in the change stream without consuming changes Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese: http://www.sraoss.co.jp -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers