Re: [HACKERS] oh dear ...

2003-11-15 Thread Joe Conway
Christopher Kings-Lynne wrote: I made up a more thorough regression test for date input formats, and found that there were still some cases that were rejected :-(. Attached is a more complete patch that handles all month-name cases, and explicitly can not change the behavior when there's not a tex

Re: [HACKERS] oh dear ...

2003-11-15 Thread Christopher Kings-Lynne
I made up a more thorough regression test for date input formats, and found that there were still some cases that were rejected :-(. Attached is a more complete patch that handles all month-name cases, and explicitly can not change the behavior when there's not a textual month name. Documentation

Re: [HACKERS] oh dear ...

2003-11-15 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> The pgstat patch has already been checked to my satisfaction, but the >> datetime patch needs more eyeballs on it; anyone out there have time to >> look at it? > FWIW, it looks good to me, seems to work as intended, and passes all > exis

Re: [HACKERS] oh dear ...

2003-11-14 Thread Marc G. Fournier
My bad, confused two different issues in one thread :( On Fri, 14 Nov 2003, Joe Conway wrote: > Marc G. Fournier wrote: > > > > On Fri, 14 Nov 2003, Andrew Dunstan wrote: > >>I'm confused. My understanding from what Tom said is that it affects all > >>configurations. > > > > the stats collector

Re: [HACKERS] oh dear ...

2003-11-14 Thread Marc G. Fournier
On Fri, 14 Nov 2003, Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > Shouldn't you also add a regression test to catch this in the future? > > Yes, I absolutely plan to stick some regression test additions into HEAD. > There's not a need for such changes in the 7.4 bran

Re: [HACKERS] oh dear ...

2003-11-14 Thread Joe Conway
Tom Lane wrote: The pgstat patch has already been checked to my satisfaction, but the datetime patch needs more eyeballs on it; anyone out there have time to look at it? FWIW, it looks good to me, seems to work as intended, and passes all existing regression tests. Joe --

Re: [HACKERS] oh dear ...

2003-11-14 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > Shouldn't you also add a regression test to catch this in the future? Yes, I absolutely plan to stick some regression test additions into HEAD. There's not a need for such changes in the 7.4 branch though. Right at the moment what we need is a

Re: [HACKERS] oh dear ...

2003-11-14 Thread Christopher Kings-Lynne
I propose the attached patch to fix the problem. It doesn't break any regression tests, and it appears to fix the cases noted in its comment. Opinions on whether to apply this to 7.4? I think it should be fixed, since it could cause applications to break. Shouldn't you also add a regression test

Re: [HACKERS] oh dear ...

2003-11-14 Thread Joe Conway
Marc G. Fournier wrote: On Fri, 14 Nov 2003, Andrew Dunstan wrote: I'm confused. My understanding from what Tom said is that it affects all configurations. the stats collector problem, from what I've seen through this list, affects Solaris, and only some Solaris configuration .. But the issue at ha

Re: [HACKERS] oh dear ...

2003-11-14 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > On Fri, 14 Nov 2003, Bruce Momjian wrote: >> I guess the question is whether we would fix this in a minor release, >> and I think the answer it yes, so we can fix it now. > Ah, so we attempt to fix a bug that affects what appears to be a small % > o

Re: [HACKERS] oh dear ...

2003-11-14 Thread Marc G. Fournier
On Fri, 14 Nov 2003, Andrew Dunstan wrote: > I'm confused. My understanding from what Tom said is that it affects all > configurations. the stats collector problem, from what I've seen through this list, affects Solaris, and only some Solaris configuration .. ---(end o

Re: [HACKERS] oh dear ...

2003-11-14 Thread Andrew Dunstan
Marc G. Fournier wrote: On Fri, 14 Nov 2003, Bruce Momjian wrote: Tom Lane wrote: I said: This worked in 7.3: regression=# select '1999-jan-08'::date; ERROR: date/time field value out of range: "1999-jan-08" HINT: Perhaps you need a different "datestyle" setting. Setti

Re: [HACKERS] oh dear ...

2003-11-14 Thread Marc G. Fournier
On Fri, 14 Nov 2003, Bruce Momjian wrote: > Tom Lane wrote: > > I said: > > > This worked in 7.3: > > > regression=# select '1999-jan-08'::date; > > > ERROR: date/time field value out of range: "1999-jan-08" > > > HINT: Perhaps you need a different "datestyle" setting. > > > > > Setting DateSt

Re: [HACKERS] oh dear ...

2003-11-14 Thread Bruce Momjian
Tom Lane wrote: > I said: > > This worked in 7.3: > > regression=# select '1999-jan-08'::date; > > ERROR: date/time field value out of range: "1999-jan-08" > > HINT: Perhaps you need a different "datestyle" setting. > > > Setting DateStyle to YMD doesn't help, and in any case I'd think that > >

Re: [HACKERS] oh dear ...

2003-11-14 Thread Marc G. Fournier
On Fri, 14 Nov 2003, Tom Lane wrote: > I said: > > This worked in 7.3: > > regression=# select '1999-jan-08'::date; > > ERROR: date/time field value out of range: "1999-jan-08" > > HINT: Perhaps you need a different "datestyle" setting. > > > Setting DateStyle to YMD doesn't help, and in any c

Re: [HACKERS] oh dear ...

2003-11-14 Thread Tom Lane
I said: > This worked in 7.3: > regression=# select '1999-jan-08'::date; > ERROR: date/time field value out of range: "1999-jan-08" > HINT: Perhaps you need a different "datestyle" setting. > Setting DateStyle to YMD doesn't help, and in any case I'd think that > this ought to be considered an u

[HACKERS] oh dear ...

2003-11-14 Thread Tom Lane
This worked in 7.3: regression=# select '1999-jan-08'::date; ERROR: date/time field value out of range: "1999-jan-08" HINT: Perhaps you need a different "datestyle" setting. Setting DateStyle to YMD doesn't help, and in any case I'd think that this ought to be considered an unambiguous input fo