Re: [HACKERS] pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)

2011-11-10 Thread Tom Lane
Steve Singer writes: > On 11-11-10 02:00 PM, Tom Lane wrote: >> ... Oh, I see, the problem is that&labels[-1] might not compare to >> &labels[0] the way we want. I think only the first hunk of your >> patch is actually necessary. > Yes the problem is still fixed if I only apply the first hunk.

Re: [HACKERS] pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)

2011-11-10 Thread Steve Singer
On 11-11-10 02:00 PM, Tom Lane wrote: Steve Singer writes: The man page for malloc on AIX is pretty clear on what happens when you try to malloc 0 bytes. It returns NULL. Yes, that's a pretty common behavior for malloc(0). It should not cause a problem here AFAICS. ... Oh, I see, the probl

Re: [HACKERS] pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)

2011-11-10 Thread Tom Lane
Steve Singer writes: > The man page for malloc on AIX is pretty clear on what happens when you > try to malloc 0 bytes. It returns NULL. Yes, that's a pretty common behavior for malloc(0). It should not cause a problem here AFAICS. ... Oh, I see, the problem is that &labels[-1] might not comp

Re: [HACKERS] pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)

2011-11-10 Thread Steve Singer
On 11-11-09 06:35 PM, Tom Lane wrote: Steve Singer writes: I've tracked the issue down to collectSecLabels in pg_dump.c SELECT label, provider, classoid, objoid, objsbid FROM pg_catalog.pg_seclabel; returns 0 rows. The code in collectSecLabels() is not prepared to deal with a zero row

Re: [HACKERS] pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)

2011-11-09 Thread Tom Lane
Steve Singer writes: > I've tracked the issue down to collectSecLabels in pg_dump.c > SELECT label, provider, classoid, objoid, objsbid FROM > pg_catalog.pg_seclabel; > returns 0 rows. > The code in collectSecLabels() is not prepared to deal with a zero row > result and tries to malloc 0 byte

[HACKERS] pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)

2011-11-09 Thread Steve Singer
We have a cluster running 9.1.1 where pg_dump hangs when we try to dump some a database inside of the cluster. The server is running AIX. I can see this on clean cluster where we do an initdb, followed by a createdb and try running pg_dump. I've tracked the issue down to collectSecLabels in