Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-08-15 Thread Michael Paquier
On Wed, Aug 16, 2017 at 9:29 AM, Peter Eisentraut wrote: > I have committed that version. I think the exit message can be useful, > because pg_receivewal will usually run as some kind of background > process where the exit status might be not be visible.

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-08-15 Thread Peter Eisentraut
On 7/9/17 22:08, Michael Paquier wrote: > While the version on my laptop does that: > if (time_to_abort) > { > - fprintf(stderr, _("%s: received interrupt signal, exiting\n"), > - progname); > + if (verbose) > +

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-07-09 Thread Michael Paquier
On Sun, Jul 9, 2017 at 9:30 PM, Michael Paquier wrote: > On Sun, Jul 9, 2017 at 5:58 AM, Magnus Hagander wrote: >> I wonder if we should actually just remove the second message? AFAICT no >> other tools log that information. Is there any particular

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-07-09 Thread Michael Paquier
On Sun, Jul 9, 2017 at 5:58 AM, Magnus Hagander wrote: > I wonder if we should actually just remove the second message? AFAICT no > other tools log that information. Is there any particular reason why we want > that logging in pg_receivewal when we don't have it in other

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-07-08 Thread Magnus Hagander
On Wednesday, June 14, 2017, Michael Paquier wrote: > On Tue, Jun 13, 2017 at 4:50 PM, Craig Ringer > wrote: > > On 13 June 2017 at 14:33, Michael Paquier > wrote: > >> Those come from

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-06-28 Thread Daniel Gustafsson
> On 14 Jun 2017, at 06:04, Michael Paquier wrote: > > On Tue, Jun 13, 2017 at 4:50 PM, Craig Ringer wrote: >> On 13 June 2017 at 14:33, Michael Paquier wrote: >>> Those come from stop_streaming in pg_receivewal.c.

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-06-13 Thread Michael Paquier
On Tue, Jun 13, 2017 at 4:50 PM, Craig Ringer wrote: > On 13 June 2017 at 14:33, Michael Paquier wrote: >> Those come from stop_streaming in pg_receivewal.c. Shouldn't those >> messages only show up to the user if --verbose is used? It seems >>

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-06-13 Thread Craig Ringer
On 13 June 2017 at 14:33, Michael Paquier wrote: > Hi all, > > I have noticed that the following messages can show up from > pg_receivewal even if the verbose mode is not used: > if (prevtimeline != 0 && prevtimeline != timeline) >

[HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-06-13 Thread Michael Paquier
Hi all, I have noticed that the following messages can show up from pg_receivewal even if the verbose mode is not used: if (prevtimeline != 0 && prevtimeline != timeline) fprintf(stderr, _("%s: switched to timeline %u at %X/%X\n"), progname,