Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-07-10 Thread Kyotaro HORIGUCHI
Hello, Anyway, I think that making -n option display all the values that -f option changes would be useful. But since that's not a bugfix, we should apply it only in HEAD. Agreed. Is this a TODO item? It's not that. The 'bug' was my wrong guess and I've found that it is done

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-07-09 Thread Bruce Momjian
On Wed, Jun 25, 2014 at 02:08:26PM +0900, Kyotaro HORIGUCHI wrote: Hello, thank you for the suggestion. I dont' touch what '-n' option shows and rewrite documents for the option a bit. And '-n' won't show the changes of backup location. === There are some changes which haven't been

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-29 Thread Kyotaro HORIGUCHI
Mmm. This patch is found that useless, from the first. Thanks for the patch! But when I read the source code of pg_resetxlog, I found that it has already reset the backup locations. Please see RewriteControlFile() which does that. So I wonder if we need nothing at least in HEAD for the

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-29 Thread Fujii Masao
On Mon, Jun 30, 2014 at 12:49 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Mmm. This patch is found that useless, from the first. Thanks for the patch! But when I read the source code of pg_resetxlog, I found that it has already reset the backup locations. Please see

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-29 Thread Kyotaro HORIGUCHI
Hello, misunderstanding, but all these patches are totally useless. So we should mark this patch as Rejected Patches? I think so. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-29 Thread Abhijit Menon-Sen
At 2014-06-30 13:55:59 +0900, horiguchi.kyot...@lab.ntt.co.jp wrote: So we should mark this patch as Rejected Patches? I think so. Done. -- Abhijit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-27 Thread Fujii Masao
On Fri, Jun 27, 2014 at 12:29 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, I have finished the patches for all of 9.x. I dont' touch what '-n' option shows and rewrite documents for the option a bit. And '-n' won't show the changes of backup location. -8.4: does not

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-26 Thread Kyotaro HORIGUCHI
Hello, I have finished the patches for all of 9.x. I dont' touch what '-n' option shows and rewrite documents for the option a bit. And '-n' won't show the changes of backup location. -8.4: does not have backup locations in ControlFileData. 9.0-9.1: resetxlog_backuploc_9_0-9.1.patch: Add

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-24 Thread Kyotaro HORIGUCHI
Hello, Ok, I'm doing modify it to reset backup locations by default and remove the new option '-b' to do that. Since this seems looking to be a bug for the poeple, I'll provide backpatches back to... 8.4? (Final release of 8.4 is scheduled at July 2014) I looked closer to pg_resetxlog and

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-24 Thread Fujii Masao
On Wed, Jun 25, 2014 at 11:13 AM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, Ok, I'm doing modify it to reset backup locations by default and remove the new option '-b' to do that. Since this seems looking to be a bug for the poeple, I'll provide backpatches back to...

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-24 Thread Kyotaro HORIGUCHI
Hello, thank you for the suggestion. I dont' touch what '-n' option shows and rewrite documents for the option a bit. And '-n' won't show the changes of backup location. === There are some changes which haven't been shown by '-n' option, even not displayed at all. I think these should be

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-23 Thread Kyotaro HORIGUCHI
Hello, thank you for the comments. On Sun, Jun 22, 2014 at 8:54 PM, Simon Riggs si...@2ndquadrant.com wrote: On 13 June 2014 12:27, Fujii Masao masao.fu...@gmail.com wrote: I think that pg_resetxlog should reset backup locations by default since they are useless (rather harmful) after

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 3:49 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, thank you for the comments. On Sun, Jun 22, 2014 at 8:54 PM, Simon Riggs si...@2ndquadrant.com wrote: On 13 June 2014 12:27, Fujii Masao masao.fu...@gmail.com wrote: I think that pg_resetxlog

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-23 Thread Kyotaro HORIGUCHI
Hi, At Mon, 23 Jun 2014 17:10:05 +0900, Fujii Masao masao.fu...@gmail.com wrote in cahgqgwfy_cdmfuriu6zoat2htqo_eijaj7vwewysol15oct...@mail.gmail.com I assume the primary usage of this patch to be, as described before, Dissolving a recovery freezing caused by wrongly placed backup label.

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-22 Thread Simon Riggs
On 13 June 2014 12:27, Fujii Masao masao.fu...@gmail.com wrote: I think that pg_resetxlog should reset backup locations by default since they are useless (rather harmful) after pg_resetxlog. Thought? +1 Do we regard that point as a bug that should be backpatched? -- Simon Riggs

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-22 Thread Fujii Masao
On Sun, Jun 22, 2014 at 8:54 PM, Simon Riggs si...@2ndquadrant.com wrote: On 13 June 2014 12:27, Fujii Masao masao.fu...@gmail.com wrote: I think that pg_resetxlog should reset backup locations by default since they are useless (rather harmful) after pg_resetxlog. Thought? +1 Do we regard

[HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-13 Thread Kyotaro HORIGUCHI
Hello, this is a patch that add the function to clear backup location information to pg_resetxlog. As per the discussion held before, this function cannot be back patched to the older versions than 9.4. And it also slipped over 9.4 so proposed in this CF. This simplly erases the backup location

Re: [HACKERS] pg_resetxlog to clear backup start/end locations.

2014-06-13 Thread Fujii Masao
On Fri, Jun 13, 2014 at 5:08 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, this is a patch that add the function to clear backup location information to pg_resetxlog. As per the discussion held before, this function cannot be back patched to the older versions than 9.4.