On Wednesday 10 June 2009 23:54:41 Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
I think it usually does that already ...
Um, attached you will find a bunch of counterexamples.
At a quick look, I'm not sure that any of these are in code that hasn't
been edited since the 8.3
Peter Eisentraut wrote:
On Wednesday 10 June 2009 23:54:41 Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
I think it usually does that already ...
Um, attached you will find a bunch of counterexamples.
At a quick look, I'm not sure that any of these are
Andrew Dunstan and...@dunslane.net writes:
Peter Eisentraut wrote:
On Wednesday 10 June 2009 23:54:41 Tom Lane wrote:
At a quick look, I'm not sure that any of these are in code that hasn't
been edited since the 8.3 pgindent run.
So what does that mean then? Surely pgindent doesn't keep
Andrew Dunstan wrote:
Bruce Momjian wrote:
The consolidated list comes from Windows(mingw) and Linux. My Cygwin
run broke for some reason, and 'objdump --stabs' doesn't seem to do what
we need on FBSD, so the output there was empty. If someone knows how to
get the typedefs out via
Bruce Momjian wrote:
Andrew Dunstan wrote:
Bruce Momjian wrote:
The consolidated list comes from Windows(mingw) and Linux. My Cygwin
run broke for some reason, and 'objdump --stabs' doesn't seem to do what
we need on FBSD, so the output there was empty. If someone knows how to
get
Andrew Dunstan wrote:
Bruce Momjian wrote:
Andrew Dunstan wrote:
Bruce Momjian wrote:
The consolidated list comes from Windows(mingw) and Linux. My Cygwin
run broke for some reason, and 'objdump --stabs' doesn't seem to do what
we need on FBSD, so the output there was
Bruce Momjian br...@momjian.us writes:
OK, pgindent run with updated list and applied to CVS HEAD. I eyeballed
the patch and it looked clean, and it tested successfully. Thanks.
Do we have any TODO items concerning pgindent at this point? You had
mentioned wanting to research its behavior
Tom Lane wrote:
Do we have any TODO items concerning pgindent at this point? Y
Yes, we will make the buildfarm and standalone find-typedefs run from a
common pieces of code so they are always in sync.
cheers
andrew
--
Sent via pgsql-hackers mailing list
Andrew Dunstan wrote:
Tom Lane wrote:
Do we have any TODO items concerning pgindent at this point? Y
Yes, we will make the buildfarm and standalone find-typedefs run from a
common pieces of code so they are always in sync.
BTW if we had an official typedef list that could be used
Alvaro Herrera wrote:
BTW if we had an official typedef list that could be used for the
length of a whole major release, we could run pgindent on a regular
basis (say fortnightly or monthly); patch submitters would just need to
run it on their own trees to avoid merge conflicts.
(Hmm, but I'm
Merlin Moncure mmonc...@gmail.com writes:
I confirmed the aix problem on 4.3.3. Installed the patches and
updated postgres 8.4b2 removing the aix hack. Server starts fine:
$ LOG: could not bind IPv6 socket: Addr family not supported by protocol
HINT: Is another postmaster already running
On Thu, Jun 11, 2009 at 2:13 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Merlin Moncure mmonc...@gmail.com writes:
I confirmed the aix problem on 4.3.3. Installed the patches and
updated postgres 8.4b2 removing the aix hack. Server starts fine:
$ LOG: could not bind IPv6 socket: Addr family not
On Tue, 2009-06-09 at 13:21 -0400, Bruce Momjian wrote:
It is time to run pgindent on CVS HEAD for 8.4. I am thinking of
running it at zero-hour GMT tomorrow, meaning five hours from now.
Any objections?
Why don't we do this automatically after each individual commit? That
way each commit
Andrew Dunstan wrote:
Bruce Momjian wrote:
OK, Andrew, would you use the find_typedef file that is in CVS HEAD and
run that. I think that will fix our problem and then I can use the
buildfarm version. How often does that run and does it pull the script
from CVS HEAD?
The
Simon Riggs si...@2ndquadrant.com writes:
On Tue, 2009-06-09 at 13:21 -0400, Bruce Momjian wrote:
It is time to run pgindent on CVS HEAD for 8.4. I am thinking of
running it at zero-hour GMT tomorrow, meaning five hours from now.
Why don't we do this automatically after each individual
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I saw a few odd things. Most importantly, it seems 'stat' was
introduced as a typedef on _both_ lists, yielding weird changes like:
The standard headers do define struct stat. I wonder whether the
objdump kluge we are using is
Bruce Momjian br...@momjian.us writes:
Tom Lane wrote:
We don't have a lot of time for research. Maybe the best thing is to
just manually remove stat from the typedef list (along with anything
else that clearly shouldn't be there)?
I agree we are running out of time so I will be running
Bruce Momjian wrote:
Andrew Dunstan wrote:
Bruce Momjian wrote:
OK, Andrew, would you use the find_typedef file that is in CVS HEAD and
run that. I think that will fix our problem and then I can use the
buildfarm version. How often does that run and does it pull the script
from
Andrew Dunstan wrote:
Well, sometimes I build it and they don't come ;-).
I don't have every platform under the sun that I can run this on,
although I do now have an FBSD VM that I didn't have when I worked on
this previously. If you're actually going to use it I'll set it up as a
Bruce Momjian wrote:
Good point. Here is another diff I need you to make to the pl file.
Done. Linux run under way.
If you want to make your pl file the official version and replace the
shell script in CVS, that is fine with me. Do you want me to do that?
It needs to be done in
Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I saw a few odd things. Most importantly, it seems 'stat' was
introduced as a typedef on _both_ lists, yielding weird changes like:
The standard headers do define struct stat. I wonder whether the
objdump
Andrew Dunstan wrote:
Bruce Momjian wrote:
Good point. Here is another diff I need you to make to the pl file.
Done. Linux run under way.
If you want to make your pl file the official version and replace the
shell script in CVS, that is fine with me. Do you want me to do
Bruce Momjian br...@momjian.us writes:
OK, I have found the cause of the script error, and it was my fault. A
month after we ran pgindent for 8.3 (December 2007), I received this
issue from Tom:
http://archives.postgresql.org/pgsql-hackers/2007-12/msg00800.php
Something I noticed the other
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
OK, I have found the cause of the script error, and it was my fault. A
month after we ran pgindent for 8.3 (December 2007), I received this
issue from Tom:
http://archives.postgresql.org/pgsql-hackers/2007-12/msg00800.php
Bruce Momjian br...@momjian.us writes:
I am unclear why struct pointers are not being formatted properly in
function headers but will research it.
Yeah, if we can fix that directly without adding the names to the
typedef list, it would be better. But not something to do right now.
Have you
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I am unclear why struct pointers are not being formatted properly in
function headers but will research it.
Yeah, if we can fix that directly without adding the names to the
typedef list, it would be better. But not something to do
Bruce Momjian br...@momjian.us writes:
Have you started the pgindent run yet? I have a patch ready for
the cursor stability issue, but will hold off committing if it might
create a merge problem for you.
I am waiting for Andrew to tell me he is ready with updated lists for
his platforms.
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I am unclear why struct pointers are not being formatted properly in
function headers but will research it.
Yeah, if we can fix that directly without adding the names to the
typedef list, it would be better. But not something
Andrew Dunstan wrote:
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I am unclear why struct pointers are not being formatted properly in
function headers but will research it.
Yeah, if we can fix that directly without adding the names to the
typedef list, it
Out of curiosity how different is the output if we don't pass the
typedef list at all? I'm wondering if the formatting differences are
things we actually care much about anyways.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Bruce Momjian wrote:
I did a diff, attached, and found some typedefs that don't appear, like
PortalData. That is defined in our code as:
typedef struct PortalData *Portal;
typedef struct PortalData
{
/* Bookkeeping data */
...
Greg Stark st...@enterprisedb.com writes:
Out of curiosity how different is the output if we don't pass the
typedef list at all? I'm wondering if the formatting differences are
things we actually care much about anyways.
It tends to put extra spaces in variable declarations that are using
the
On Tuesday 09 June 2009 20:21:35 Bruce Momjian wrote:
It is time to run pgindent on CVS HEAD for 8.4. I am thinking of
running it at zero-hour GMT tomorrow, meaning five hours from now.
Any objections?
Btw., can you make pgindent remove whitespace at the end of lines?
--
Sent via
Peter Eisentraut pete...@gmx.net writes:
Btw., can you make pgindent remove whitespace at the end of lines?
I think it usually does that already ...
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
Andrew Dunstan wrote:
Bruce Momjian wrote:
I did a diff, attached, and found some typedefs that don't appear, like
PortalData. That is defined in our code as:
typedef struct PortalData *Portal;
typedef struct PortalData
{
/* Bookkeeping data */
Tom Lane wrote:
Greg Stark st...@enterprisedb.com writes:
Out of curiosity how different is the output if we don't pass the
typedef list at all? I'm wondering if the formatting differences are
things we actually care much about anyways.
It tends to put extra spaces in variable
Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
Btw., can you make pgindent remove whitespace at the end of lines?
I think it usually does that already ...
Yes.
--
Bruce Momjian br...@momjian.ushttp://momjian.us
EnterpriseDB
On Wednesday 10 June 2009 22:50:15 Bruce Momjian wrote:
Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
Btw., can you make pgindent remove whitespace at the end of lines?
I think it usually does that already ...
Yes.
Um, attached you will find a bunch of counterexamples.
Peter Eisentraut pete...@gmx.net writes:
I think it usually does that already ...
Um, attached you will find a bunch of counterexamples.
At a quick look, I'm not sure that any of these are in code that hasn't
been edited since the 8.3 pgindent run.
regards, tom lane
On Wed, Jun 10, 2009 at 9:54 PM, Tom Lanet...@sss.pgh.pa.us wrote:
Peter Eisentraut pete...@gmx.net writes:
I think it usually does that already ...
Um, attached you will find a bunch of counterexamples.
At a quick look, I'm not sure that any of these are in code that hasn't
been edited
Andrew Dunstan wrote:
I am doing runs as requested on various platforms to extract the
typedef lists. Linux is done, Windows (mingw) is running, FBSD and
Cygwin to come.
Results in a few hours. The buildfarm will have a consolidated list.
The consolidated list comes from
Andrew Dunstan wrote:
Andrew Dunstan wrote:
I am doing runs as requested on various platforms to extract the
typedef lists. Linux is done, Windows (mingw) is running, FBSD and
Cygwin to come.
Results in a few hours. The buildfarm will have a consolidated list.
The
Bruce Momjian wrote:
The consolidated list comes from Windows(mingw) and Linux. My Cygwin
run broke for some reason, and 'objdump --stabs' doesn't seem to do what
we need on FBSD, so the output there was empty. If someone knows how to
get the typedefs out via objdump on FBSD would they
Andrew Dunstan and...@dunslane.net writes:
Bruce Momjian wrote:
I will check on our Postgres shell server right away.
OK, so we got that working, and the consolidated list now contains FBSD
data as well.
Um, let's *go* guys. RC1 wrap is scheduled for 18 hours from now.
That means it is
It is time to run pgindent on CVS HEAD for 8.4. I am thinking of
running it at zero-hour GMT tomorrow, meaning five hours from now.
Any objections?
--
Bruce Momjian br...@momjian.ushttp://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life
Bruce Momjian wrote:
It is time to run pgindent on CVS HEAD for 8.4. I am thinking of
running it at zero-hour GMT tomorrow, meaning five hours from now.
Any objections?
I ran pgindent and was concerned enough about the results so I am
posting here rather than applying any changes. I used
Bruce Momjian wrote:
The typedef is coming from the indicated line, and from
/usr/include/sys/stat.h, where there is no typedef for stat. Obviously
Linux or the buildfarm is finding the same issue, but I have no idea
why.
My only guess right now is that we are linking postgres differently
Bruce Momjian br...@momjian.us writes:
I saw a few odd things. Most importantly, it seems 'stat' was
introduced as a typedef on _both_ lists, yielding weird changes like:
The standard headers do define struct stat. I wonder whether the
objdump kluge we are using is unable to distinguish
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I saw a few odd things. Most importantly, it seems 'stat' was
introduced as a typedef on _both_ lists, yielding weird changes like:
The standard headers do define struct stat. I wonder whether the
objdump kluge we are using is
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
I saw a few odd things. Most importantly, it seems 'stat' was
introduced as a typedef on _both_ lists, yielding weird changes like:
The standard headers do define struct stat. I wonder whether the
objdump kluge we are using is
Bruce Momjian br...@momjian.us writes:
Tom Lane wrote:
We don't have a lot of time for research. Maybe the best thing is to
just manually remove stat from the typedef list (along with anything
else that clearly shouldn't be there)?
Do you want me to just run with my old typedef list now and
Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
Tom Lane wrote:
We don't have a lot of time for research. Maybe the best thing is to
just manually remove stat from the typedef list (along with anything
else that clearly shouldn't be there)?
Do you want me to just run with my
Bruce Momjian wrote:
OK, Andrew, would you use the find_typedef file that is in CVS HEAD and
run that. I think that will fix our problem and then I can use the
buildfarm version. How often does that run and does it pull the script
from CVS HEAD?
The buildfarm does not run the
It is about time to run pgindent before we enter beta testing. Is this
weekend good for everyone?
--
Bruce Momjian [EMAIL PROTECTED]
EnterpriseDBhttp://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
---(end of
Bruce Momjian [EMAIL PROTECTED] writes:
It is about time to run pgindent before we enter beta testing. Is this
weekend good for everyone?
I think we should wait until the fate of the GUC patch is determined
--- if we want to apply it, a pgindent run is going to cause some
unnecessary work,
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
It is about time to run pgindent before we enter beta testing. Is this
weekend good for everyone?
I think we should wait until the fate of the GUC patch is determined
--- if we want to apply it, a pgindent run is going to cause some
I am going to run pgindent in 8 hours, in preparation for 7.4 beta.
I am completing the list of release changes and should be done in 8-12
hours.
--
Bruce Momjian| http://candle.pha.pa.us
[EMAIL PROTECTED] | (610) 359-1001
+ If your life is a hard
57 matches
Mail list logo
