Re: [HACKERS] printing table in asciidoc with psql

2015-04-01 Thread Bruce Momjian
On Tue, Mar 31, 2015 at 05:06:49PM -0400, Bruce Momjian wrote: > Uh, you broke asciidoctor 1.5.2. ;-) LOL > > I installed the Asciidoctor Firefox plugin: Asciidoctor has confirmed they have a bug and hope to fix it in their next release: http://discuss.asciidoctor.org/Problem-with-ta

Re: [HACKERS] printing table in asciidoc with psql

2015-03-31 Thread Bruce Momjian
On Tue, Mar 31, 2015 at 05:25:48PM +0100, Thom Brown wrote: > Slightly updated patch attached and applied.  I moved asciidoc after > HTML in the list, rather than at the end.  Thanks for everyone's hard > work on this.  > > > I think I done gone broke it: > > CREATE TABLE "| 3^.||moo

Re: [HACKERS] printing table in asciidoc with psql

2015-03-31 Thread Thom Brown
On 31 March 2015 at 16:35, Bruce Momjian wrote: > On Wed, Mar 25, 2015 at 09:12:41AM -0400, Bruce Momjian wrote: > > On Wed, Mar 25, 2015 at 09:37:08PM +0900, Michael Paquier wrote: > > > On Wed, Mar 25, 2015 at 4:59 PM, Bruce Momjian > wrote: > > > > On Wed, Mar 25, 2015 at 02:18:58PM +0900, Mi

Re: [HACKERS] printing table in asciidoc with psql

2015-03-31 Thread Bruce Momjian
On Wed, Mar 25, 2015 at 09:12:41AM -0400, Bruce Momjian wrote: > On Wed, Mar 25, 2015 at 09:37:08PM +0900, Michael Paquier wrote: > > On Wed, Mar 25, 2015 at 4:59 PM, Bruce Momjian wrote: > > > On Wed, Mar 25, 2015 at 02:18:58PM +0900, Michael Paquier wrote: > > >> > [options="header",cols=" > >>

Re: [HACKERS] printing table in asciidoc with psql

2015-03-25 Thread Bruce Momjian
On Wed, Mar 25, 2015 at 09:37:08PM +0900, Michael Paquier wrote: > On Wed, Mar 25, 2015 at 4:59 PM, Bruce Momjian wrote: > > On Wed, Mar 25, 2015 at 02:18:58PM +0900, Michael Paquier wrote: > >> > [options="header",cols=" >> > | > >> > |5 2.2+^.^ |4 2.2+^.^ > >> > |2 2.2+^.^ |3 2.2+^.^ > >> >

Re: [HACKERS] printing table in asciidoc with psql

2015-03-25 Thread Michael Paquier
On Wed, Mar 25, 2015 at 4:59 PM, Bruce Momjian wrote: > On Wed, Mar 25, 2015 at 02:18:58PM +0900, Michael Paquier wrote: >> > [options="header",cols="> > | >> > |5 2.2+^.^ |4 2.2+^.^ >> > |2 2.2+^.^ |3 2.2+^.^ >> > | >> >> Hm. This is still incorrect. You should remove options="header" her

Re: [HACKERS] printing table in asciidoc with psql

2015-03-25 Thread Bruce Momjian
On Wed, Mar 25, 2015 at 02:18:58PM +0900, Michael Paquier wrote: > > [options="header",cols=" > | > > |5 2.2+^.^ |4 2.2+^.^ > > |2 2.2+^.^ |3 2.2+^.^ > > | > > Hm. This is still incorrect. You should remove options="header" here > or the first tuple is treated as a header in the case > non

Re: [HACKERS] printing table in asciidoc with psql

2015-03-24 Thread Michael Paquier
On Wed, Mar 25, 2015 at 4:52 AM, Bruce Momjian wrote: > On Tue, Mar 24, 2015 at 11:15:33AM +0900, Michael Paquier wrote: >> On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote: >> > Notice the added 'l' next to the '<'. Updated patch attached. Any >> > other issues? >> >> Ah, right. That's a go

Re: [HACKERS] printing table in asciidoc with psql

2015-03-24 Thread Bruce Momjian
On Tue, Mar 24, 2015 at 11:15:33AM +0900, Michael Paquier wrote: > On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote: > > Notice the added 'l' next to the '<'. Updated patch attached. Any > > other issues? > > Ah, right. That's a good catch and your patch fixes the issue. Still, > there are p

Re: [HACKERS] printing table in asciidoc with psql

2015-03-23 Thread Michael Paquier
On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote: > Notice the added 'l' next to the '<'. Updated patch attached. Any > other issues? Ah, right. That's a good catch and your patch fixes the issue. Still, there are problems with the tuple-only mode and the expanded mode. For example using thi

Re: [HACKERS] printing table in asciidoc with psql

2015-03-23 Thread Bruce Momjian
On Sun, Mar 22, 2015 at 08:06:17PM +0900, Michael Paquier wrote: > > I have updated the attached patch to do as you suggested. Please also > > test the \x output. Thanks. > > Indeed. If I use a specific column name like this one, I am seeing > problems with the expanded mode: > =# create table "

Re: [HACKERS] printing table in asciidoc with psql

2015-03-22 Thread Michael Paquier
On Sun, Mar 22, 2015 at 10:09 AM, Bruce Momjian wrote: > On Sat, Mar 21, 2015 at 09:20:03PM +0900, Michael Paquier wrote: >> This does not work: >> =# create table "5 2.2+^.^" (); >> CREATE TABLE >> =# \pset format asciidoc >> Output format is asciidoc. >> =# \d >> >> .List of relations >> [option

Re: [HACKERS] printing table in asciidoc with psql

2015-03-21 Thread Bruce Momjian
On Sat, Mar 21, 2015 at 09:20:03PM +0900, Michael Paquier wrote: > This does not work: > =# create table "5 2.2+^.^" (); > CREATE TABLE > =# \pset format asciidoc > Output format is asciidoc. > =# \d > > .List of relations > [options="header",cols=" | > ^l|Schema ^l|Name ^l|Type ^l|Owner > |pu

Re: [HACKERS] printing table in asciidoc with psql

2015-03-21 Thread Michael Paquier
On Fri, Mar 20, 2015 at 11:10 PM, Bruce Momjian wrote: > I was able to fix all the reported problems with the attached patch. > I used this for testing the output: > > https://asciidoclive.com/ > > Is it OK now? This does not work: =# create table "5 2.2+^.^" (); CREATE TABLE =# \pset form

Re: [HACKERS] printing table in asciidoc with psql

2015-03-20 Thread Bruce Momjian
On Wed, Dec 3, 2014 at 03:52:30PM +0900, Michael Paquier wrote: > > I see a trailing spaces, but I don't see a described effect. Please, can you > > send some more specific test case? > > This formatting problem is trivial to reproduce: > =# create table "foo" (); > > CREATE TABLE > Time: 9.826

Re: [HACKERS] printing table in asciidoc with psql

2014-12-02 Thread Michael Paquier
On Wed, Dec 3, 2014 at 3:52 PM, Michael Paquier wrote: > This patch has been marked as "Waiting on Author" for a couple of > weeks, and the problems mentioned before have not been completely > addressed, hence marking this patch as returned with feedback. It > would be nice to see progress for the

Re: [HACKERS] printing table in asciidoc with psql

2014-12-02 Thread Michael Paquier
On Mon, Nov 17, 2014 at 7:48 AM, Pavel Stehule wrote: > 2014-11-07 22:37 GMT+01:00 Alvaro Herrera : >> >> >> I did \o /tmp/tst, then >> \dS >> create table "eh | oh" (); >> \dS >> >> and then filtered the output file to HTML. The CREATE TABLE tag ended >> up in the same line as the title of the f

Re: [HACKERS] printing table in asciidoc with psql

2014-11-16 Thread Pavel Stehule
Hi 2014-11-07 22:37 GMT+01:00 Alvaro Herrera : > > I did \o /tmp/tst, then > \dS > create table "eh | oh" (); > \dS > > and then filtered the output file to HTML. The CREATE TABLE tag ended > up in the same line as the title of the following table. I think > there's a newline is missing somewhe

Re: [HACKERS] printing table in asciidoc with psql

2014-11-15 Thread Pavel Stehule
Hi I can fix reported bugs today or tomorrow Regards Pavel 2014-11-14 21:00 GMT+01:00 Szymon Guz : > > On 14 November 2014 20:57, Alvaro Herrera > wrote: > >> Is anyone going to submit a new version of this patch? >> >> >> > > Hi Alvaro, > due to family issues I will not be able to work on it

Re: [HACKERS] printing table in asciidoc with psql

2014-11-14 Thread Szymon Guz
On 14 November 2014 20:57, Alvaro Herrera wrote: > Is anyone going to submit a new version of this patch? > > > Hi Alvaro, due to family issues I will not be able to work on it for the next 10 days. regards, Szymon

Re: [HACKERS] printing table in asciidoc with psql

2014-11-14 Thread Alvaro Herrera
Is anyone going to submit a new version of this patch? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.p

Re: [HACKERS] printing table in asciidoc with psql

2014-11-07 Thread Alvaro Herrera
I did \o /tmp/tst, then \dS create table "eh | oh" (); \dS and then filtered the output file to HTML. The CREATE TABLE tag ended up in the same line as the title of the following table. I think there's a newline is missing somewhere. The good news is that the | in the table name was processed

Re: [HACKERS] printing table in asciidoc with psql

2014-10-30 Thread Pavel Stehule
2014-10-30 9:30 GMT+01:00 Szymon Guz : > On 30 October 2014 09:04, Pavel Stehule wrote: > >> >> >> 2014-10-29 12:23 GMT+01:00 Szymon Guz : >> >>> >>> >>> On 17 October 2014 09:01, Pavel Stehule wrote: >>> Hi Szymon I found a small bug - it doesn't escape "|" well postgre

Re: [HACKERS] printing table in asciidoc with psql

2014-10-30 Thread Szymon Guz
On 30 October 2014 09:04, Pavel Stehule wrote: > > > 2014-10-29 12:23 GMT+01:00 Szymon Guz : > >> >> >> On 17 October 2014 09:01, Pavel Stehule wrote: >> >>> Hi Szymon >>> >>> I found a small bug - it doesn't escape "|" well >>> >>> postgres=# select * from mytab ; >>> a | numeric_b |

Re: [HACKERS] printing table in asciidoc with psql

2014-10-30 Thread Pavel Stehule
2014-10-29 12:23 GMT+01:00 Szymon Guz : > > > On 17 October 2014 09:01, Pavel Stehule wrote: > >> Hi Szymon >> >> I found a small bug - it doesn't escape "|" well >> >> postgres=# select * from mytab ; >> a | numeric_b | c >> --+---+ >> Ahoj |1

Re: [HACKERS] printing table in asciidoc with psql

2014-10-29 Thread Szymon Guz
On 17 October 2014 09:01, Pavel Stehule wrote: > Hi Szymon > > I found a small bug - it doesn't escape "|" well > > postgres=# select * from mytab ; > a | numeric_b | c > --+---+ > Ahoj |10 | 2014-10-17 > Hello|20 | 2014-10-18 > H

Re: [HACKERS] printing table in asciidoc with psql

2014-10-17 Thread Pavel Stehule
Hi Szymon I found a small bug - it doesn't escape "|" well postgres=# select * from mytab ; a | numeric_b | c --+---+ Ahoj |10 | 2014-10-17 Hello|20 | 2014-10-18 Hi |30 | 2014-10-19 aaa| | | 2014-10-17

Re: [HACKERS] printing table in asciidoc with psql

2014-09-17 Thread Szymon Guz
On 17 September 2014 19:55, Szymon Guz wrote: > > > On 17 September 2014 19:30, Peter Eisentraut wrote: > >> On 9/16/14 3:52 PM, Szymon Guz wrote: >> > It's not finished yet, I'm not sure it there is any sense in supporting >> > border types etc. >> >> AFAICT, Asciidoc doesn't support border typ

Re: [HACKERS] printing table in asciidoc with psql

2014-09-17 Thread Szymon Guz
On 17 September 2014 19:30, Peter Eisentraut wrote: > On 9/16/14 3:52 PM, Szymon Guz wrote: > > It's not finished yet, I'm not sure it there is any sense in supporting > > border types etc. > > AFAICT, Asciidoc doesn't support border types, so (if so) you should > just ignore that setting. > Too

Re: [HACKERS] printing table in asciidoc with psql

2014-09-17 Thread Peter Eisentraut
On 9/16/14 3:52 PM, Szymon Guz wrote: > It's not finished yet, I'm not sure it there is any sense in supporting > border types etc. AFAICT, Asciidoc doesn't support border types, so (if so) you should just ignore that setting. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] printing table in asciidoc with psql

2014-09-17 Thread Pavel Stehule
2014-09-16 21:52 GMT+02:00 Szymon Guz : > Hi, > I've been working a little bit on a patch for printing tables in asciidoc > with psql. > > It's not finished yet, I'm not sure it there is any sense in supporting > border types etc. The code is not cleared so far, but any remarks on the > style not

Re: [HACKERS] printing table in asciidoc with psql

2014-09-17 Thread Emanuel Calvo
El 16/09/14 16:52, Szymon Guz escribió: > Hi, > I've been working a little bit on a patch for printing tables in > asciidoc with psql. > > It's not finished yet, I'm not sure it there is any sense in > supporting border types etc. The code is not cleared so far, but any > remarks on the style not

[HACKERS] printing table in asciidoc with psql

2014-09-16 Thread Szymon Guz
Hi, I've been working a little bit on a patch for printing tables in asciidoc with psql. It's not finished yet, I'm not sure it there is any sense in supporting border types etc. The code is not cleared so far, but any remarks on the style not playing well with the normal postgres style of code ar