Re: [HACKERS] pset_quoted_string is broken

2014-10-26 Thread David Rowley
On Mon, Oct 27, 2014 at 12:20 PM, Tom Lane wrote: > David Rowley writes: > > It seems the buffer created in pset_quoted_string is just 1 char too > small. > > Yeah, that's a bug. Fix pushed, thanks! > > Thanks for committing. > > This breaks psql's \pset for me, though I've no idea why the bu

Re: [HACKERS] pset_quoted_string is broken

2014-10-26 Thread Tom Lane
David Rowley writes: > It seems the buffer created in pset_quoted_string is just 1 char too small. Yeah, that's a bug. Fix pushed, thanks! > This breaks psql's \pset for me, though I've no idea why the buildfarm is > not complaining a bit more. I think in most cases, maxalign padding of the ma

[HACKERS] pset_quoted_string is broken

2014-10-26 Thread David Rowley
It seems the buffer created in pset_quoted_string is just 1 char too small. This breaks psql's \pset for me, though I've no idea why the buildfarm is not complaining a bit more. As it stands, if the function is given an empty string to quote, it tries to build a string with 2 single quotes and a