On Wed, Jul 21, 2010 at 11:13 PM, Fujii Masao wrote:
> On Thu, Jul 22, 2010 at 11:57 AM, Robert Haas wrote:
>> Should we be using is_absolute_path() here instead, as libpq does?
>
> Yes. The attached patch does that.
>
>>> On Wed, Jul 21, 2010 at 10:09 PM, David Christensen
>>> wrote:
>>> If we
On Thu, Jul 22, 2010 at 11:57 AM, Robert Haas wrote:
> Should we be using is_absolute_path() here instead, as libpq does?
Yes. The attached patch does that.
>> On Wed, Jul 21, 2010 at 10:09 PM, David Christensen
>> wrote:
>> If we print the local socket when it's been explicitly set via the ho
On Wed, Jul 21, 2010 at 10:09 PM, David Christensen wrote:
>
> On Jul 21, 2010, at 8:48 PM, Fujii Masao wrote:
>
>> On Wed, Jul 21, 2010 at 7:29 PM, Robert Haas wrote:
>>> On Wed, Jul 21, 2010 at 1:07 AM, Fujii Masao wrote:
On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas
wrote:
> O
On Wed, Jul 21, 2010 at 9:48 PM, Fujii Masao wrote:
> On Wed, Jul 21, 2010 at 7:29 PM, Robert Haas wrote:
>> On Wed, Jul 21, 2010 at 1:07 AM, Fujii Masao wrote:
>>> On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas wrote:
OK, committed.
>>>
>>> When I specify the path of the directory for the
On Jul 21, 2010, at 8:48 PM, Fujii Masao wrote:
> On Wed, Jul 21, 2010 at 7:29 PM, Robert Haas wrote:
>> On Wed, Jul 21, 2010 at 1:07 AM, Fujii Masao wrote:
>>> On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas wrote:
OK, committed.
>>>
>>> When I specify the path of the directory for the Un
On Wed, Jul 21, 2010 at 7:29 PM, Robert Haas wrote:
> On Wed, Jul 21, 2010 at 1:07 AM, Fujii Masao wrote:
>> On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas wrote:
>>> OK, committed.
>>
>> When I specify the path of the directory for the Unix-domain socket
>> as the host, \conninfo doesn't mention
On Wed, Jul 21, 2010 at 1:07 AM, Fujii Masao wrote:
> On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas wrote:
>> OK, committed.
>
> When I specify the path of the directory for the Unix-domain socket
> as the host, \conninfo doesn't mention that this connection is based
> on the Unix-domain socket.
On Tue, Jul 20, 2010 at 11:14 PM, Robert Haas wrote:
> OK, committed.
When I specify the path of the directory for the Unix-domain socket
as the host, \conninfo doesn't mention that this connection is based
on the Unix-domain socket. Is this intentional?
$ psql -h"/tmp" -c"\conninfo"
You are con
On Tue, Jul 20, 2010 at 12:16 AM, David Christensen wrote:
> On Jul 19, 2010, at 11:10 PM, Robert Haas wrote:
>
>> On Tue, Jul 20, 2010 at 12:07 AM, Robert Haas wrote:
>>> On Tue, Jul 20, 2010 at 12:02 AM, David Christensen
>>> wrote:
> I would propose to print instead:
>
> You are
On Jul 19, 2010, at 11:10 PM, Robert Haas wrote:
> On Tue, Jul 20, 2010 at 12:07 AM, Robert Haas wrote:
>> On Tue, Jul 20, 2010 at 12:02 AM, David Christensen
>> wrote:
I would propose to print instead:
You are connected to database "rhaas" via local socket as user "rhaas".
>>>
On Tue, Jul 20, 2010 at 12:07 AM, Robert Haas wrote:
> On Tue, Jul 20, 2010 at 12:02 AM, David Christensen
> wrote:
>>> I would propose to print instead:
>>>
>>> You are connected to database "rhaas" via local socket as user "rhaas".
>>
>>
>> One minor quibble here; you lose the ability to see w
On Tue, Jul 20, 2010 at 12:02 AM, David Christensen wrote:
>> I would propose to print instead:
>>
>> You are connected to database "rhaas" via local socket as user "rhaas".
>
>
> One minor quibble here; you lose the ability to see which pg instance you're
> running on if there are multiple ones
> I would propose to print instead:
>
> You are connected to database "rhaas" via local socket as user "rhaas".
One minor quibble here; you lose the ability to see which pg instance you're
running on if there are multiple ones running on different local sockets, so
maybe either the port or the
On Mon, Jul 19, 2010 at 11:41 PM, David Christensen wrote:
>> I took a look at this patch. One problem is that it doesn't handle
>> the case where there is no database connection (for example, shut down
>> the database with pg_ctl, then do select 1, then do \conninfo). I've
>> fixed that in the
On Jul 19, 2010, at 10:34 PM, Robert Haas wrote:
> On Sun, Jul 18, 2010 at 2:00 PM, David Christensen wrote:
>> Updated the commitfest entry with the patch, updated the title to reflect
>> the actual name of the command, and marked as ready for committer.
>
> I took a look at this patch. One
On Sun, Jul 18, 2010 at 2:00 PM, David Christensen wrote:
> Updated the commitfest entry with the patch, updated the title to reflect the
> actual name of the command, and marked as ready for committer.
I took a look at this patch. One problem is that it doesn't handle
the case where there is n
On Jul 18, 2010, at 12:33 PM, David Christensen wrote:
>
> On Jul 18, 2010, at 12:30 PM, Tom Lane wrote:
>
>> David Christensen writes:
>>> machack:machack:5432=# \c "foo""bar"
>>> You are now connected to database "foo"bar".
>>
>> What this is reflecting is that backslash commands have their
17 matches
Mail list logo
