On 11/28/2011 09:19 PM, Josh Kupershmidt wrote:
Other than those small gripes, the patch looks fine. Attached is an
updated version to save you some keystrokes.
Thanks. Committed.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to yo
On Sat, Nov 26, 2011 at 11:02 AM, Andrew Dunstan wrote:
>> Also, should the malloc() of newval just use pg_malloc() instead?
>
> Yes, also done.
This bit is unnecessary, since pg_malloc() takes care of the error handling:
+ if (!newval)
+ {
+
On 11/20/2011 11:07 AM, Josh Kupershmidt wrote:
On Wed, Nov 2, 2011 at 5:36 PM, Andrew Dunstan wrote:
Updated patch is attached - adding to Nov commitfest.
Review of the v2 patch:
* Submission Review
Patch applies with some fuzz and builds without warnings. I noticed
some tab characters bei
On Wed, Nov 2, 2011 at 5:36 PM, Andrew Dunstan wrote:
> Updated patch is attached - adding to Nov commitfest.
Review of the v2 patch:
* Submission Review
Patch applies with some fuzz and builds without warnings. I noticed
some tab characters being used in psql-ref.sgml where they shouldn't
be.
On 09/26/2011 05:16 PM, Andrew Dunstan wrote:
On 09/26/2011 05:07 PM, Jeff Janes wrote:
But in any case, considering that we are both wondering if it works on
Windows, I think that argues that an automatic regression test would
be very handy.
I think an automated test should be possible
On 09/26/2011 05:07 PM, Jeff Janes wrote:
But in any case, considering that we are both wondering if it works on
Windows, I think that argues that an automatic regression test would
be very handy.
I think an automated test should be possible. Something like:
\setenv PGFOO blurfl
\!
On Mon, Sep 26, 2011 at 12:07 PM, Josh Kupershmidt wrote:
> On Thu, Sep 15, 2011 at 7:02 PM, Andrew Dunstan wrote:
>> On Thu, September 15, 2011 6:10 pm, Josh Kupershmidt wrote:
>>> [need way to show current values]
>> \! echo $foo
>>
>> (which is how I tested the patch, of course)
>
> Ah, right.
On Thu, Sep 15, 2011 at 7:02 PM, Andrew Dunstan wrote:
> On Thu, September 15, 2011 6:10 pm, Josh Kupershmidt wrote:
>> [need way to show current values]
> \! echo $foo
>
> (which is how I tested the patch, of course)
Ah, right. IMO it'd be helpful to mention that echo example in your
changes to
On Thu, Sep 15, 2011 at 7:46 AM, Andrew Dunstan wrote:
> On Thu, September 15, 2011 10:44 am, Andrew Dunstan wrote:
>>
>> As discussed, patch attached.
>>
>
>
> this time with patch.
Hi Andrew,
A description of the \setenv command should show up in the output of \?.
Should there be a regression
On Thu, September 15, 2011 6:10 pm, Josh Kupershmidt wrote:
> On Thu, Sep 15, 2011 at 10:46 AM, Andrew Dunstan
> wrote:
>> this time with patch.
>
> I think help.c should document the \setenv command. And a link from
> the "Environment" section[1] of psql's doc page to the section about
> \setenv
On Thu, Sep 15, 2011 at 10:46 AM, Andrew Dunstan wrote:
> this time with patch.
I think help.c should document the \setenv command. And a link from
the "Environment" section[1] of psql's doc page to the section about
\setenv might help too.
The existing \set command lists all internal variables
On Thu, September 15, 2011 10:44 am, Andrew Dunstan wrote:
>
> As discussed, patch attached.
>
this time with patch.
setenv.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mai
As discussed, patch attached.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
13 matches
Mail list logo
