Re: [HACKERS] query cancel issues in contrib/dblink

2010-02-24 Thread Bruce Momjian
What happened to this patch? --- Itagaki Takahiro wrote: Merlin Moncure mmonc...@gmail.com wrote: Takahiroitagaki.takah...@oss.ntt.co.jp wrote: contrib/dblink seems to have no treatments for query cancels. (1)

Re: [HACKERS] query cancel issues in contrib/dblink

2010-02-24 Thread Robert Haas
On Wed, Feb 24, 2010 at 2:33 PM, Bruce Momjian br...@momjian.us wrote: What happened to this patch? I'm pretty sure it's the same as this: https://commitfest.postgresql.org/action/patch_view?id=263 ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] query cancel issues in contrib/dblink

2010-02-24 Thread Takahiro Itagaki
Robert Haas robertmh...@gmail.com wrote: I'm pretty sure it's the same as this: https://commitfest.postgresql.org/action/patch_view?id=263 Yes, (2) are resolved with the patch with a different implementation. (2) is fixed by RegisterXactCallback(AtEOXact_dblink). However, there might be

Re: [HACKERS] query cancel issues in contrib/dblink

2009-09-16 Thread Joe Conway
Itagaki Takahiro wrote: Stephen Frost sfr...@snowman.net wrote: Can you provide an update on this patch? Joe, you were going to review and possibly commit it. Itagaki, did you have a new version? Are there any outstanding issues? Thanks for your reviewing. Here is an updated

Re: [HACKERS] query cancel issues in contrib/dblink

2009-09-15 Thread Stephen Frost
Joe, Itagaki, Can you provide an update on this patch? Joe, you were going to review and possibly commit it. Itagaki, did you have a new version? Are there any outstanding issues? Thanks, Stephen signature.asc Description: Digital signature

Re: [HACKERS] query cancel issues in contrib/dblink

2009-09-15 Thread Itagaki Takahiro
Stephen Frost sfr...@snowman.net wrote: Can you provide an update on this patch? Joe, you were going to review and possibly commit it. Itagaki, did you have a new version? Are there any outstanding issues? Thanks for your reviewing. Here is an updated version. I fixed some bugs: *

Re: [HACKERS] query cancel issues in contrib/dblink

2009-06-28 Thread Itagaki Takahiro
Merlin Moncure mmonc...@gmail.com wrote: Takahiroitagaki.takah...@oss.ntt.co.jp wrote: contrib/dblink seems to have no treatments for query cancels. (1) Users need to wait for completion of remote query. (2) PGresult objects will be memory leak. Here is a patch to fix the issues. I hope

Re: [HACKERS] query cancel issues in contrib/dblink

2009-06-26 Thread Merlin Moncure
On Thu, Jun 25, 2009 at 10:41 PM, Itagaki Takahiroitagaki.takah...@oss.ntt.co.jp wrote: Hi, contrib/dblink seems to have no treatments for query cancels. It causes the following issues: (1) Users need to wait for completion of remote query.    Requests for query cancel won't be delivered to

[HACKERS] query cancel issues in contrib/dblink

2009-06-25 Thread Itagaki Takahiro
Hi, contrib/dblink seems to have no treatments for query cancels. It causes the following issues: (1) Users need to wait for completion of remote query. Requests for query cancel won't be delivered to remote servers. (2) PGresult objects will be memory leak. The result is not released