Re: [HACKERS] should I post the patch as committed?

2010-04-21 Thread Pavan Deolasee
On Tue, Apr 20, 2010 at 10:41 PM, Alvaro Herrera wrote: > > > > I think committing a patch from a non-regular is a special case and > attaching the modified patch is reasonable in that case. > > My 8.8 Richter ... > > Or may be just mention the commit id for easy look up in the git log. Thanks,

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Alvaro Herrera
Bruce Momjian escribió: > Magnus Hagander wrote: > > Yeah, +1. I always go to one of the other sources (most of the time, > > the gitweb or git server). > > > > It doesn't hurt to attach it if it happens to be around, but I > > wouldn't suggest spending any extra effort on it... > > Well, many t

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Kevin Grittner
Robert Haas wrote: > is it helpful to attach the patch-as-committed to the -hackers > email, or is it just duplicative of what's already available > elsewhere? I'm fine with using git.postgresql.org to see what was committed. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@pos

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Bruce Momjian
Magnus Hagander wrote: > On Tue, Apr 20, 2010 at 18:30, Tom Lane wrote: > > Robert Haas writes: > >> Bruce suggested to me off-list that when I commit a patch with > >> revisions, I ought to attach the committed patch to the email in which > >> I say that I have committed it. ?I know that Bruce h

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Magnus Hagander
On Tue, Apr 20, 2010 at 18:30, Tom Lane wrote: > Robert Haas writes: >> Bruce suggested to me off-list that when I commit a patch with >> revisions, I ought to attach the committed patch to the email in which >> I say that I have committed it.  I know that Bruce habitually does >> this, but I've

Re: [HACKERS] should I post the patch as committed?

2010-04-20 Thread Tom Lane
Robert Haas writes: > Bruce suggested to me off-list that when I commit a patch with > revisions, I ought to attach the committed patch to the email in which > I say that I have committed it. I know that Bruce habitually does > this, but I've never found it very helpful, since I prefer to look at

[HACKERS] should I post the patch as committed?

2010-04-20 Thread Robert Haas
On Sun, Apr 18, 2010 at 8:55 PM, Robert Haas wrote: > Thanks for the review.  Committed with revisions along the lines you suggest. Bruce suggested to me off-list that when I commit a patch with revisions, I ought to attach the committed patch to the email in which I say that I have committed it.