Re: [HACKERS] ss_family in hba.c

2003-06-25 Thread Kurt Roeckx
On Tue, Jun 24, 2003 at 04:10:13PM -0400, Jason Tishler wrote: > Bruce, > > On Tue, Jun 24, 2003 at 03:04:05PM -0400, Bruce Momjian wrote: > > Kurt Roeckx wrote: > > > All that probably needed to change for cygwin was to no longer > > > use sa_family_t in the getaddrinfo.c. > > > > But Jason repo

Re: [HACKERS] ss_family in hba.c

2003-06-24 Thread Jason Tishler
Bruce, On Tue, Jun 24, 2003 at 03:04:05PM -0400, Bruce Momjian wrote: > Kurt Roeckx wrote: > > All that probably needed to change for cygwin was to no longer > > use sa_family_t in the getaddrinfo.c. > > But Jason reported he needed that typedef for sa_family_t. Jason, is > that accurate. Yes.

Re: [HACKERS] ss_family in hba.c

2003-06-24 Thread Bruce Momjian
Kurt Roeckx wrote: > On Mon, Jun 23, 2003 at 07:49:11PM -0400, Bruce Momjian wrote: > > > > I have applied a patch to CVS to fix the problem. It is all your patch, > > except for the part you got from me, which was wrong. :-( > > > > It took me a while to realize the subtlety of your patch. Fi

Re: [HACKERS] ss_family in hba.c

2003-06-24 Thread Kurt Roeckx
On Mon, Jun 23, 2003 at 07:49:11PM -0400, Bruce Momjian wrote: > > I have applied a patch to CVS to fix the problem. It is all your patch, > except for the part you got from me, which was wrong. :-( > > It took me a while to realize the subtlety of your patch. First, it > removes the use of sa

Re: [CYGWIN] [HACKERS] ss_family in hba.c

2003-06-24 Thread Jason Tishler
Bruce, On Mon, Jun 23, 2003 at 07:49:11PM -0400, Bruce Momjian wrote: > This should fix most platforms. I am not sure how cygwin is going to > handle this --- we might have to add a specific sa_family_t typedef > for that platform --- MinGW does have sa_family_t, but probably > doesn't need it an

Re: [HACKERS] ss_family in hba.c

2003-06-23 Thread Bruce Momjian
I have applied a patch to CVS to fix the problem. It is all your patch, except for the part you got from me, which was wrong. :-( It took me a while to realize the subtlety of your patch. First, it removes the use of sa_family_t _except_ for cases that don't have SOCKADDR_STORAGE, where it is

Re: [HACKERS] ss_family in hba.c

2003-06-20 Thread Bruno Wolff III
On Fri, Jun 20, 2003 at 18:56:30 -0500, Bruno Wolff III <[EMAIL PROTECTED]> wrote: > On Thu, Jun 19, 2003 at 23:01:19 +0200, > Kurt Roeckx <[EMAIL PROTECTED]> wrote: > > On Tue, Jun 17, 2003 at 11:01:27PM -0500, Bruno Wolff III wrote: > > > > > > My system does have its own sockaddr_storage de

Re: [HACKERS] ss_family in hba.c

2003-06-20 Thread Bruno Wolff III
On Thu, Jun 19, 2003 at 23:01:19 +0200, Kurt Roeckx <[EMAIL PROTECTED]> wrote: > On Tue, Jun 17, 2003 at 11:01:27PM -0500, Bruno Wolff III wrote: > > > > My system does have its own sockaddr_storage definition. I think > > it uses __ss_ as the prefix. Also, after looking at the fallback > > defi

Re: [HACKERS] ss_family in hba.c

2003-06-19 Thread Kurt Roeckx
On Tue, Jun 17, 2003 at 11:01:27PM -0500, Bruno Wolff III wrote: > > My system does have its own sockaddr_storage definition. I think > it uses __ss_ as the prefix. Also, after looking at the fallback > definition in pqcomm.h, I don't see where that defines ss_family > and hence don't see how that

Re: [HACKERS] ss_family in hba.c

2003-06-17 Thread Bruno Wolff III
On Tue, Jun 17, 2003 at 23:01:27 -0500, Bruno Wolff III <[EMAIL PROTECTED]> wrote: > I am going to see if adding __ works as suggested by someone else > who replied. This worked. I think the reason auth.c compiled was because the reference to ss_family was in conditional code that isn't used on

Re: [HACKERS] ss_family in hba.c

2003-06-17 Thread Bruno Wolff III
On Tue, Jun 17, 2003 at 22:49:00 +0200, Kurt Roeckx <[EMAIL PROTECTED]> wrote: > On Tue, Jun 17, 2003 at 03:32:32PM -0500, Bruno Wolff III wrote: > > I was looking at this some more and now think there is something wrong > > with the references to ss_family rather than a missing inlcude file. > >

Re: [HACKERS] ss_family in hba.c

2003-06-17 Thread Bruno Wolff III
On Tue, Jun 17, 2003 at 22:49:00 +0200, Kurt Roeckx <[EMAIL PROTECTED]> wrote: > On Tue, Jun 17, 2003 at 03:32:32PM -0500, Bruno Wolff III wrote: > > I was looking at this some more and now think there is something wrong > > with the references to ss_family rather than a missing inlcude file. > >

Re: [HACKERS] ss_family in hba.c

2003-06-17 Thread Mike Aubury
My system has the same problem - struct sockaddr_storage is defined in /usr/include/bits/socket.h : struct sockaddr_storage { __SOCKADDR_COMMON (__ss_); /* Address family, etc. */ __ss_aligntype __ss_align; /* Force desired alignment. */ char __ss_padding[_SS_PADSIZE]; }; Whe

Re: [HACKERS] ss_family in hba.c

2003-06-17 Thread Kurt Roeckx
On Tue, Jun 17, 2003 at 03:32:32PM -0500, Bruno Wolff III wrote: > I was looking at this some more and now think there is something wrong > with the references to ss_family rather than a missing inlcude file. > Perhaps those were supposed to be references to sa_family or there > is a missing field

[HACKERS] ss_family in hba.c

2003-06-17 Thread Bruno Wolff III
I was looking at this some more and now think there is something wrong with the references to ss_family rather than a missing inlcude file. Perhaps those were supposed to be references to sa_family or there is a missing field from the socket_storage type definition. ---(end