Re: Oddity in tuple routing for foreign partitions

It seems almost fine for me, but just one point.. At Thu, 26 Apr 2018 17:36:44 +0900, Etsuro Fujita wrote in <5ae18f9c.6080...@lab.ntt.co.jp> > (2018/04/26 15:35), Amit Langote wrote: > > On 2018/04/26 12:43, Etsuro Fujita wrote: > > +resultRelation ==

Re: Built-in connection pooling

On 26.04.2018 05:09, Michael Paquier wrote: On Wed, Apr 25, 2018 at 03:42:31PM -0400, Robert Haas wrote: The difficulty of finding them all is really the problem. If we had a reliable way to list everything that needs to be moved into session state, then we could try to come up with a design

Re: unused_oids script is broken with bsd sed

On 4/26/18, Tom Lane wrote: > John Naylor writes: >> For those following along, these scripts still assume we're in the >> catalog directory. I can hack on that part tomorrow if no one else >> has. > > I didn't touch this point. Patch 0002 is my attempt

Re: Toast issues with OldestXmin going backwards

On Mon, Apr 23, 2018 at 11:21 PM, Amit Kapila wrote: > If I read correctly, it seems one of the main reason [1] is to save > the extra pass over the heap and improve the code. Now, ideally, the > extra pass over heap should also free up some space (occupied by the > rows

Re: Typo in JIT documentation

On Wed, Apr 25, 2018 at 3:30 AM, Magnus Hagander wrote: > On Wed, Apr 25, 2018 at 4:11 AM, Michael Paquier > wrote: >> >> Hi all, >> >> I just found $subject: >> the server was compiled without --with-llvm), >> -JIT will not performed, even if

Re: [HACKERS] Clock with Adaptive Replacement

On Wed, Apr 25, 2018 at 6:54 PM, Peter Geoghegan wrote: > Before some of the big shared_buffers bottlenecks were alleviated > several years ago, it was possible to observe shared_buffers evictions > occurring essentially at random. I have no idea if that's still true, > but it could

Re: GSoC 2018: Sorting Algorithm and Benchmarking

On Wed, Apr 25, 2018 at 3:12 PM, Kefan Yang wrote: > If I understand it correctly, the sorting benchmark should be an executable > under the src/bin/ folder just like pgbench? What would this executable do, exactly? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com

Re: perltidy tweaks

On 04/26/2018 12:33 PM, Tom Lane wrote: > Peter Eisentraut writes: >> I prpose two tweaks for the perltidy configuration: >> - The new perltidy version can avoid writing backup files, so we don't >> need to explicitly delete them after. > +1 +1 > >> - Use

Re: description of root_tuple_slot missing

On Mon, Apr 23, 2018 at 02:50:10PM +0900, Amit Langote wrote: > I noticed that the description of root_tuple_slot member is missing in the > comment above PartitionTupleRouting definition. See if the attached patch > fixes it correctly. > > Thanks, > Amit > diff --git

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

On Mon, Apr 16, 2018 at 07:48:47PM +0300, Liudmila Mantrova wrote: > Hi everyone, > > When translating doc updates, Alexander Lakhin noticed that trigram examples > were not quite accurate. > A small patch fixing this issue is attached. FYI, this has been applied by Teodor Sigaev:

Re: unused_oids script is broken with bsd sed

John Naylor writes: > On 4/26/18, Tom Lane wrote: >> I notice that duplicate_oids is now a good factor of 10 slower than it was >> before (~0.04 sec to ~0.4 sec, on my machine). While this doesn't seem >> like a problem for manual use, it seems annoying

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Thu, Apr 26, 2018 at 2:10 AM, Masahiko Sawada wrote: > Thank you for sharing. That's good to know. > > Andres pointed out the performance degradation due to hash collision > when multiple loading. I think the point is that it happens at where > users don't know.

Re: WIP: a way forward on bootstrap data

On Thu, Apr 26, 2018 at 2:11 AM, Mark Dilger wrote: > >> On Apr 25, 2018, at 1:31 PM, Tom Lane wrote: >> >> Robert Haas writes: >>> On Wed, Apr 25, 2018 at 3:44 PM, Mark Dilger >>> wrote: There

Re: WIP: a way forward on bootstrap data

On Wed, Apr 25, 2018 at 04:39:42PM -0400, Tom Lane wrote: > Mark Dilger writes: > >> On Apr 25, 2018, at 1:00 PM, Robert Haas wrote: > >> -1 for trying to automate this. It varies between fooin and foo_in, > >> and it'll be annoying to have to

Re: [HACKERS] Clock with Adaptive Replacement

On Thu, Apr 26, 2018 at 10:39 AM, Robert Haas wrote: > I think it is. We haven't done anything to address it. I think if we > want to move to direct I/O -- which may be something we need or want > to do -- we're going to have to work a lot harder at making good page >

Scariest patch tournament, PostgreSQL 11 edition

PostgreSQL hackers and community at large, In the spirit of the season, the Release Management Team would like to gather your thoughts on Fear, Risk and Data Corruption for features in PostgreSQL 11. What patch or patches committed in this cycle do you think have the highest probability of

Re: perltidy tweaks

Peter Eisentraut writes: > I prpose two tweaks for the perltidy configuration: > - The new perltidy version can avoid writing backup files, so we don't > need to explicitly delete them after. +1 > - Use option --nooutdent-long-quotes. This is similar to a

Re: Oddity in tuple routing for foreign partitions

(2018/04/26 12:43), Etsuro Fujita wrote: (2018/04/25 17:29), Amit Langote wrote: On 2018/04/25 16:42, Kyotaro HORIGUCHI wrote: At Wed, 25 Apr 2018 11:19:23 +0900, Amit Langote wrote: After the refactoring, it appears to me that we only need this much: + rte = makeNode(RangeTblEntry); +

Re: Oddity in tuple routing for foreign partitions

On 2018/04/26 15:27, Etsuro Fujita wrote: > (2018/04/26 12:43), Etsuro Fujita wrote: >> (2018/04/25 17:29), Amit Langote wrote: >>> On 2018/04/25 16:42, Kyotaro HORIGUCHI wrote: At Wed, 25 Apr 2018 11:19:23 +0900, Amit Langote wrote: > After the refactoring, it appears to me that we only

Re: Corrupted btree index on HEAD because of covering indexes

Teodor, are you caught up to the point where it'd be okay to run pgindent, or are there still patches waiting? There is a gin predicate lock patch from Heikki, I will work on it. But I have not objection to run pgindent, I believe gin patch will be easy to change. -- Teodor Sigaev

Re: Should we add GUCs to allow partition pruning to be disabled?

On 25 April 2018 at 09:59, Alvaro Herrera wrote: > Amit Langote wrote: >> Although the config.sgml coverage of the new capabilities seems pretty >> good, some may find their being mentioned in 5.10 Table Partitioning >> helpful. Or if we don't want to hijack 5.10.4,

Re: Oddity in tuple routing for foreign partitions

On 2018/04/26 12:43, Etsuro Fujita wrote: > (2018/04/25 17:29), Amit Langote wrote: >> Hmm, I missed that we do need information from a proper RTE as well.  So, >> I suppose we should be doing this instead of creating the RTE for foreign >> partition from scratch. >> >> +    rte =

Re: Oddity in tuple routing for foreign partitions

(2018/04/26 15:39), Amit Langote wrote: On 2018/04/26 15:27, Etsuro Fujita wrote: Here is a new version I'd like to propose for fixing this issue without the former patch. Sorry, didn't notice this before sending my patch, which I also marked v7. It's a bit different than yours and has

Re: Oddity in tuple routing for foreign partitions

On 2018/04/26 2:59, Robert Haas wrote: > On Tue, Apr 24, 2018 at 10:19 PM, Amit Langote > wrote: >> I tried to do that. So, attached are two patches. >> >> 1. Fix for ExecInitPartitionInfo to use the right RT index to pass to >>InitResultRelInfo >> >> 2. v5 of

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Thu, Apr 26, 2018 at 3:30 AM, Robert Haas wrote: > On Tue, Apr 10, 2018 at 9:08 PM, Masahiko Sawada > wrote: >> Never mind. There was a lot of items especially at the last CommitFest. >> >>> In terms of moving forward, I'd still like to hear what

Re: Is there a memory leak in commit 8561e48?

On 4/19/18 02:10, Michael Paquier wrote: > On Thu, Apr 19, 2018 at 11:38:09AM +0800, jian.l...@i-soft.com.cn wrote: >> in commit 8561e48, _SPI_stack alloc from TopMemoryContext. But >> AtEOXact_SPI just set _SPI_stack = NULL. Is this a memory leak? > > You are right. I can easily see the leak

Re: Is there a memory leak in commit 8561e48?

Peter Eisentraut writes: > On 4/19/18 02:10, Michael Paquier wrote: >> You are right. I can easily see the leak if I use for example a >> background worker which connects to a database, and launches many >> transactions in a row. The laziest reproducer I have

Re: obsoleting plpython2u and defaulting plpythonu to plpython3u

Andrew Dunstan writes: > After installing python3, I switched buildfarm animal prion to build and > test with python3 instead of python2 a day or two ago. All this required > was setting PYTHON=/usr/bin/python3 in the environment. Everything else > Just Worked.

Re: obsoleting plpython2u and defaulting plpythonu to plpython3u

On 04/26/2018 04:39 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 4/25/18 04:50, Pavel Raiskup wrote: >>> So full drop is not what ask for now (it will be needed for lts/enterprise >>> distros for quite some time anyway), I just think that plpython3

Re: Oddity in tuple routing for foreign partitions

(2018/04/26 15:35), Amit Langote wrote: On 2018/04/26 12:43, Etsuro Fujita wrote: (2018/04/25 17:29), Amit Langote wrote: Hmm, I missed that we do need information from a proper RTE as well. So, I suppose we should be doing this instead of creating the RTE for foreign partition from scratch.

Re: Remove mention in docs that foreign keys on partitioned tables are not supported

On 2018/04/26 13:01, David Rowley wrote: > The attached small patch removes the mention that partitioned tables > cannot have foreign keys defined on them. > > This has been supported since 3de241db I noticed also that the item regarding row triggers might be obsolete as of 86f575948c7, thanks

Re: Racing DEADLOCK on PostgreSQL 9.3

try "Сombination of blocked and blocking activity" from https://wiki.postgresql.org/wiki/Lock_Monitoring - it should show you the originator. pg_stat_activity.waiting only show affected On 25 April 2018 at 19:56, Jerry Sievers wrote: > Nick Dro

Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled.

On Thu, Apr 26, 2018 at 5:36 PM, Etsuro Fujita wrote: > (2018/04/25 18:51), Ashutosh Bapat wrote: >> >> On Tue, Apr 24, 2018 at 4:49 PM, Etsuro Fujita >> wrote: >>> >>> o 0001-Handle-ConvertRowtypeExprs-in-pull_vars_clause.patch: > > >>>

Allow auto_explain to log to NOTICE

Hi all This patch allows a user to configure auto_explain to log to NOTICE instead of the server log. This allows automated testing of application-generated queries to ensure correct plans etc from code that can inspect returned notices but not the server log. I don't see any tests for

Re: Allow auto_explain to log to NOTICE

Hi, On 2018-04-27 11:43:58 +0930, Tom Dunstan wrote: > This patch allows a user to configure auto_explain to log to NOTICE instead > of the server log. This allows automated testing of application-generated > queries to ensure correct plans etc from code that can inspect returned > notices but

Re: Allow auto_explain to log to NOTICE

On 2018-04-27 11:52:18 +0930, Tom Dunstan wrote: > > I'd argue this should contain the non-error cases. It's just as > > reasonable to want to add this as a debug level or such. > > > > So all of warning, info, debug and debug1-5? Yea. Likely nobody will ever use debug5, but I don't see a point

Re: community bonding

Thanks Gasper for the information! 2018-04-23 22:41 GMT-07:00 Gasper Zejn : > > On 24. 04. 2018 06:22, Charles Cui wrote: > > Hi PostgreSQL community and mentors: > > > > Thanks for selecting my project as one of GSoC student projects! > > Pretty exciting and honor to join the

Re: community bonding

Thanks Aleksander for your comments! These are helpful! 2018-04-24 2:07 GMT-07:00 Aleksander Alekseev : > Hello Charles, > > > Thanks for selecting my project as one of GSoC student projects! Pretty > > exciting and honor to join the development for PostgreSQL (the

Re: Allow auto_explain to log to NOTICE

> "Tom" == Tom Dunstan writes: Tom> Hi all Tom> This patch allows a user to configure auto_explain to log to Tom> NOTICE instead of the server log. This allows automated testing of Tom> application-generated queries to ensure correct plans etc from Tom> code that can

Re: community bonding

On 24 April 2018 at 12:22, Charles Cui wrote: > Hi PostgreSQL community and mentors: > > Thanks for selecting my project as one of GSoC student projects! Pretty > exciting and honor to join the development for PostgreSQL (the best database > in the world :)). So for the

Re: Is there a memory leak in commit 8561e48?

On Thu, Apr 26, 2018 at 06:36:01PM -0400, Tom Lane wrote: > Uh, no, the memory *isn't* reused later. The coding in AtEOXact_SPI > assumes that it can just null out _SPI_stack because whatever that > might've been pointing to is transaction-lifespan memory and will > go away without extra work

Re: Setting rpath on llvmjit.so?

On Thu, Apr 26, 2018 at 01:16:09PM -0600, Jason Petersen wrote: > So the tooling around people using it is there and it’s used by some > very large and mature projects covering a variety of domains: I don’t > know if it’s “poorly supported” (the documentation leaves something to > be desired), but

Re: Typo in JIT documentation

On Thu, Apr 26, 2018 at 02:50:51PM -0400, Robert Haas wrote: > Hmm, I thought we talked about changing such references to say 'JIT > compilation' rather than just 'JIT'. Perhaps. I recall that this has been mentioned already the last couple of weeks on the JIT thread. Personally, I can see that

Re: Standby corruption after master is restarted

Thank you for noticing me of that. Is there any way to know how a bug report has been concluded? Or should I search -hackers for a corresponding thread? At Thu, 26 Apr 2018 21:13:48 +0900, Michael Paquier wrote in <20180426121348.ga2...@paquier.xyz> > On Thu, Apr 26, 2018

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Hi, On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote: > The jitflags in the PlannedStmt structure of type "int", but in _out and > _read functions it is treated as of "bool" type. > > WRITE_BOOL_FIELD(jitFlags); > READ_BOOL_FIELD(jitFlags); > > I am thinking of it is a copy paste mistake as

Re: Oddity in tuple routing for foreign partitions

At Thu, 26 Apr 2018 21:16:38 +0900, Etsuro Fujita wrote in <5ae1c326.6040...@lab.ntt.co.jp> > (2018/04/26 20:06), Kyotaro HORIGUCHI wrote: > > Please rewrite it to use not array reference, but pointer > > reference if one mtstate logically holds just one

Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS

On Tue, Apr 24, 2018 at 12:09 PM, Bruce Momjian wrote: > On Mon, Apr 23, 2018 at 01:14:48PM -0700, Andres Freund wrote: >> Hi, >> >> On 2018-03-28 10:23:46 +0800, Craig Ringer wrote: >> > TL;DR: Pg should PANIC on fsync() EIO return. Retrying fsync() is not OK at >> > least on

Re: Toast issues with OldestXmin going backwards

On Thu, Apr 26, 2018 at 03:09:01PM -0400, Tom Lane wrote: > Have we given up on the angle of "prevent OldestXmin from retreating"? > That seems like it'd be far more bulletproof than trying to work > around places that break one-by-one. Strong +1 on that. -- Michael signature.asc Description:

Re: description of root_tuple_slot missing

On 2018/04/27 3:54, Bruce Momjian wrote: > On Mon, Apr 23, 2018 at 02:50:10PM +0900, Amit Langote wrote: >> I noticed that the description of root_tuple_slot member is missing in the >> comment above PartitionTupleRouting definition. See if the attached patch >> fixes it correctly. > > Patch

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

On Thu, Apr 26, 2018 at 07:03:49PM +0530, Ashutosh Bapat wrote: > On Thu, Apr 26, 2018 at 9:04 AM, Haribabu Kommi >> I am thinking of it is a copy paste mistake as the other members around the >> initflags are of "bool" type or is there any specific reason to treat as >> "bool" type? > > No, I

Re: Toast issues with OldestXmin going backwards

> "Tom" == Tom Lane writes: Tom> Have we given up on the angle of "prevent OldestXmin from Tom> retreating"? I haven't, and I'm thinking about it, but I don't have an immediate solution. Thinking-out-loud mode: 1) we could store minimum values for OldestXmin for each

Re: Standby corruption after master is restarted

On Fri, Apr 27, 2018 at 09:49:08AM +0900, Kyotaro HORIGUCHI wrote: > Thank you for noticing me of that. Is there any way to know how a > bug report has been concluded? Or should I search -hackers for > a corresponding thread? Keeping a look at the list of patches for bugs in the CF app, and

Re: "could not reattach to shared memory" on buildfarm member dory

On 24 April 2018 at 15:18, Magnus Hagander wrote: > Back when I was combating windows AV on a daily basis, this normally did not > have the same effect. Just disabling the AV didn't actually remove the parts > that caused issues, it just hid them. Actual uninstall is what

Re: Standby corruption after master is restarted

Hello. I found how this occurs. # added -hackers I've seen similar case with inadequite operation but this time I found that it can happen under normal operation. At Tue, 17 Apr 2018 17:14:05 +0200, Emre Hasegeli wrote in

Re: Built-in connection pooling

On 25.04.2018 20:02, Merlin Moncure wrote: Would integrated pooling help the sharding case (genuinely curious)? I don't quite have my head around the issue. I've always wanted pgbouncer to be able to do things like round robin queries to non-sharded replica for simple load balancing but it

Sv: Sv: Re: Query is over 2x slower with jit=on

På onsdag 18. april 2018 kl. 18:26:03, skrev Andreas Joseph Krogh < andr...@visena.com >: På onsdag 18. april 2018 kl. 17:50:55, skrev Andres Freund >: On 2018-04-18 17:35:31 +0200, Andreas Joseph Krogh wrote: > With

Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled.

(2018/04/25 18:51), Ashutosh Bapat wrote: On Tue, Apr 24, 2018 at 4:49 PM, Etsuro Fujita wrote: o 0001-Handle-ConvertRowtypeExprs-in-pull_vars_clause.patch: Another thing I noticed about this patch is this: postgres=# create table prt1 (a int, b int, c

Re: minor fix for acquire_inherited_sample_rows

On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: > On Tue, Apr 24, 2018 at 6:19 AM, Amit Langote > wrote: >> Given what equalTupleDescs was invented for (commit a152ebeec), reducing >> it down to what can be sensibly used for checking

Re: unused_oids script is broken with bsd sed

On 04/26/2018 01:37 PM, John Naylor wrote:> Patch 0002 is my attempt at this. Not sure how portable this is. It's also clunkier than before in that you need to tell it where to find Catalog.pm, since it seems Perl won't compile unless "use lib" points to a string and not an expression.

Re: unused_oids script is broken with bsd sed

Andreas Karlsson writes: > What about using FindBin (http://perldoc.perl.org/FindBin.html)? A quick check suggests that that's present in the core perl distribution pretty far back, so I think it'll work. Question is, is it any better than John's "dirname(__FILE__)" solution?

Re: minor fix for acquire_inherited_sample_rows

On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat wrote: > On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: >> +1. I think we're really abusing equalTupleDescs() for purposes for >> which it was not invented. Instead of changing it,

Re: unused_oids script is broken with bsd sed

I wrote: > Andreas Karlsson writes: >> What about using FindBin (http://perldoc.perl.org/FindBin.html)? > A quick check suggests that that's present in the core perl > distribution pretty far back, so I think it'll work. > Question is, is it any better than John's

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

On Thu, Apr 26, 2018 at 9:04 AM, Haribabu Kommi wrote: > The jitflags in the PlannedStmt structure of type "int", but in _out and > _read functions it is treated as of "bool" type. > > WRITE_BOOL_FIELD(jitFlags); > READ_BOOL_FIELD(jitFlags); > > I am thinking of it is a

Re: Setting rpath on llvmjit.so?

> On Apr 18, 2018, at 8:57 AM, Tom Lane wrote: > > I'm wondering whether that will result in expending a lot of effort to move > from a poorly-supported build system to a different poorly-supported build > system. I’m not sure whether the former is autoconf/make or cmake,

Re: obsoleting plpython2u and defaulting plpythonu to plpython3u

On 4/25/18 04:50, Pavel Raiskup wrote: > So full drop is not what ask for now (it will be needed for lts/enterprise > distros for quite some time anyway), I just think that plpython3 should be > the default (by build system, by 'plpythonu'=>'plpython3u', etc.). I don't think we should do that

Re: minor fix for acquire_inherited_sample_rows

Amit Langote wrote: > On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat > wrote: > > On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: > >> +1. I think we're really abusing equalTupleDescs() for purposes for > >> which it was not invented.

Re: Toast issues with OldestXmin going backwards

Robert Haas writes: > I wonder if perhaps get_actual_variable_range() has a hazard of this > type as well. If OldestXmin retreats, then the special snapshot type > which it uses could see a row whose TOAST entry has been removed > meanwhile. Hm, yeah. I wonder if we

Re: obsoleting plpython2u and defaulting plpythonu to plpython3u

Peter Eisentraut writes: > On 4/25/18 04:50, Pavel Raiskup wrote: >> So full drop is not what ask for now (it will be needed for lts/enterprise >> distros for quite some time anyway), I just think that plpython3 should be >> the default (by build system, by

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

Hi, On 2018-04-26 15:08:24 -0400, Robert Haas wrote: > I don't think that's a very useful suggestion. Changing > N_RELEXTLOCK_ENTS requires a recompile, which is going to be > impractical for most users. Even if we made it a GUC, we don't want > users to have to tune stuff like this. If we

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

Hello Markus, Markus Winand wrote: > * Patch 0001: Accept TEXT and CDATA nodes in XMLTABLE’s column_expression. > > > Column_expressions that match TEXT or CDATA nodes must return > > the contents of the node itself, not the content of the > > non-existing childs (i.e. the empty string). > >

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Thu, Apr 26, 2018 at 3:10 PM, Andres Freund wrote: >> I think the real question is whether the scenario is common enough to >> worry about. In practice, you'd have to be extremely unlucky to be >> doing many bulk loads at the same time that all happened to hash to >> the

Re: Transform for pl/perl

On 4/24/18 14:31, Andrew Dunstan wrote: > There is the routine IsValidJsonNumber that helps - see among others > hstore_io.c for an example use. I would need something like that taking a double/float8 input. But I think there is no such shortcut available, so I just wrote out the tests for isinf