Re: Fix some trivial issues of the document/comment

"ZHUO QL (KDr2)" writes: > I'm learning PGSQL and reading the source, and find few trivial issues in the > docs: LGTM, pushed. Thanks for the patch! regards, tom lane

inconsistency and inefficiency in setup_conversion()

Taking a close look at the result of setup_conversion(), wrong or at least confusing comments are applied to the functions. Consider this family of conversions: select conproc, conname from pg_conversion where conproc = 'utf8_to_win'::regproc order by oid; conproc | conname

Re: [GENERAL] huge RAM use in multi-command ALTER of table heirarchy

On Tue, Jul 18, 2017 at 07:26:30PM -0400, Tom Lane wrote: > > It's probably a bit late in the v10 cycle to be taking any risks in > > this area, but I'd vote for ripping out RememberToFreeTupleDescAtEOX > > as soon as the v11 cycle opens, unless someone can show an example > > of non-broken coding

Re: Postgres, fsync, and OSs (specifically linux)

Hi, On 2018-04-28 11:10:54 -0400, Stephen Frost wrote: > When we crash-restart, we also go through and clean things up some, no? > Seems like that gives us the potential to end up fixing things ourselves > and allowing the crash-restart to succeed. Sure, there's the potential for that. But it's

Re: Postgres, fsync, and OSs (specifically linux)

Hi, On 2018-04-28 17:35:48 +0200, Michael Banck wrote: > This dmesg-checking has been mentioned several times now, but IME > enterprise distributions (or server ops teams?) seem to tighten access > to dmesg and /var/log to non-root users, including postgres. > > Well, or just vanilla Debian

Re: Postgres, fsync, and OSs (specifically linux)

Hi, On 2018-04-28 08:25:53 -0700, Simon Riggs wrote: > > - Use direct IO. Due to architectural performance issues in PG and the > > fact that it'd not be applicable for all installations I don't think > > this is a reasonable fix for the issue presented here. Although it's > > independently

Re: GCC 8 warnings

Peter Eisentraut writes: > On 4/24/18 05:57, Devrim Gündüz wrote: >> While building stable releases and v11 on Fedora 28, I am seeing some >> warnings. > Attached is a patch to fix these warnings in master. These are very > similar to the class of warnings we

Re: Verbosity of genbki.pl

Peter Eisentraut writes: > Maybe we can take another look at this. Right now, make -s world > produces *only* the following output: > $ make -s world > Generating BKI files and symbol definition headers... > Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

I took a stab at fixing those issues, as well as the bug when fastupdate is turned on concurrently. Does the attached patch look sane to you? That's look sane, and I believe it should be applied but I see some issue in your patch: I don't very happy with rootBuffer added everywhere.

Re: Postgres, fsync, and OSs (specifically linux)

Hi, On 2018-04-28 20:00:25 +0800, Craig Ringer wrote: > On 28 April 2018 at 06:28, Andres Freund wrote: > > The second major type of proposal was using direct-IO. That'd generally > > be a desirable feature, but a) would require some significant changes to > > postgres to be

Re: GCC 8 warnings

Hi, On 2018-04-28 12:16:39 -0400, Tom Lane wrote: > -SharedFilePath(char *path, SharedFileSet *fileset, const char *name) > +SharedFilePath(char *path, size_t size, SharedFileSet *fileset, const char > *name) > { > - chardirpath[MAXPGPATH]; > + char

Re: inconsistency and inefficiency in setup_conversion()

John Naylor writes: > Taking a close look at the result of setup_conversion(), wrong or at > least confusing comments are applied to the functions. Ugh. Between that and the large chunk of initdb runtime eaten by setup_conversion(), that seems like plenty of reason to redo

Re: Verbosity of genbki.pl

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Peter Eisentraut writes: > > Maybe we can take another look at this. Right now, make -s world > > produces *only* the following output: > > > $ make -s world > > Generating BKI files and symbol definition

Re: Built-in connection pooling

On 27.04.2018 23:43, Merlin Moncure wrote: On Fri, Apr 27, 2018 at 11:44 AM, Konstantin Knizhnik wrote: On 27.04.2018 18:33, Merlin Moncure wrote: On Fri, Apr 27, 2018 at 10:05 AM, Konstantin Knizhnik wrote: On 27.04.2018 16:49,

Re: WIP: a way forward on bootstrap data

On 4/26/18, Tom Lane wrote: > (The prosrc-from-proname case, in isolation, could be handled about > as well by adding a hardwired rule like we have for pronargs.) If we think we might go in the direction of more special-case behavior, the attached patch more fully documents

Re: Postgres, fsync, and OSs (specifically linux)

On 28 April 2018 at 06:28, Andres Freund wrote: > Hi, > > I thought I'd send this separately from [0] as the issue has become more > general than what was mentioned in that thread, and it went off into > various weeds. Thanks very much for going and for the great summary. >

Re: [HACKERS] Clock with Adaptive Replacement

Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > On Thu, Apr 26, 2018 at 10:39 AM, Robert Haas wrote: > > I'm personally not very excited about making rules like "index pages > > are more valuable than heap pages". Such rules will in many cases be > > true, but it's

Re: Patch missing from back branches

Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > There is dory in the buildfarm which compiles using VS 2015, but it runs > only 9.6 and newer versions. That would be specifically because compiling 9.5 didn't work.. We'd be happy to have dory running on older major versions, if

Re: Postgres, fsync, and OSs (specifically linux)

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2018-04-27 19:38:30 -0400, Bruce Momjian wrote: > > On Fri, Apr 27, 2018 at 04:10:43PM -0700, Andres Freund wrote: > > > On 2018-04-27 19:04:47 -0400, Bruce Momjian wrote: > > > > On Fri, Apr 27, 2018 at 03:28:42PM -0700, Andres Freund

Re: Postgres, fsync, and OSs (specifically linux)

Greetings, * Craig Ringer (cr...@2ndquadrant.com) wrote: > On 28 April 2018 at 06:28, Andres Freund wrote: > > - Add a pre-checkpoint hook that checks for filesystem errors *after* > > fsyncing all the files, but *before* logging the checkpoint completion > > record.

Re: Verbosity of genbki.pl

On 4/9/18 15:02, Tom Lane wrote: > Andres Freund writes: >> On 2018-04-08 13:33:42 -0400, Tom Lane wrote: >>> Traditionally genbki.pl has printed "Writing foo" for every file >>> it writes out. > >>> 2. Print just one message like "Generating postgres.bki and related >>>

Re: Postgres, fsync, and OSs (specifically linux)

Hi, On Sat, Apr 28, 2018 at 11:21:20AM -0400, Stephen Frost wrote: > * Craig Ringer (cr...@2ndquadrant.com) wrote: > > On 28 April 2018 at 06:28, Andres Freund wrote: > > > - Add a pre-checkpoint hook that checks for filesystem errors *after* > > > fsyncing all the files,

Re: "could not reattach to shared memory" on buildfarm member dory

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Noah Misch writes: > > On Tue, Apr 24, 2018 at 11:37:33AM +1200, Thomas Munro wrote: > >> Maybe try asking what's mapped there with VirtualQueryEx() on failure? > > > +1. An implementation of that: > >

Re: Toast issues with OldestXmin going backwards

Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Apr 27, 2018 at 11:35 AM, Andrew Gierth > wrote: > >> "Robert" == Robert Haas writes: > > Robert> One idea that occurred to me is to somehow record -- I guess in > >

Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

Michael Paquier writes: > JIT is introducing the installation of LLVM bitcode modules, and any > installation done results in the following comment in output, which > repeats basically for all the extensions installed: > # Then install files > # > # The many INSTALL_DATA

Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

Andres Freund writes: > On April 28, 2018 11:05:15 AM PDT, Tom Lane wrote: >> Close inspection of the >> "make install" output revealed a few other issues, which I hope >> I fixed rather than making things worse. > Broke the llvm enabled part of the bf.

Re: [RFC] Add an until-0 loop in psql

> > > I did it too. It is not too hard - there was not a agreement on syntax. > > can be nice some like CTE > > WITH PROCEDURE x(a int, b int) AS ... $$ SELECT x(10); > I've seen "WITH function" syntax in Oracle (here's an example:

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

I don't very happy with rootBuffer added everywhere. ginInsertItemPointers() and  ginPrepareDataScan() now take both args, rootBlkno and rootBuffer, second could be invalid. As I can see, you did it to call CheckForSerializableConflictIn() in ginEntryInsert(). Seems, it could be reverted and

Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

On April 28, 2018 11:05:15 AM PDT, Tom Lane wrote: >Michael Paquier writes: >> JIT is introducing the installation of LLVM bitcode modules, and any >> installation done results in the following comment in output, which >> repeats basically for all the

Re: Is a modern build system acceptable for older platforms

On 28.04.2018 05:27, Yuriy Zhuravlev wrote: "make distcheck" CMake have no this bad concept, in my opinion, if you want to make the project you should have a full build environment. (but I don't want to argue about it here) this is not about having a working build environment, it is

Re: WIP: a way forward on bootstrap data

John Naylor writes: > On 4/26/18, Tom Lane wrote: >> (The prosrc-from-proname case, in isolation, could be handled about >> as well by adding a hardwired rule like we have for pronargs.) > If we think we might go in the direction of more special-case >

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Andres Freund writes: > On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote: >> I am thinking of it is a copy paste mistake as the other members around the >> initflags are of "bool" type or is there any specific reason to treat as >> "bool" type? > No, it's an oversight. It

Re: [HACKERS] Clock with Adaptive Replacement

On Sun, Apr 29, 2018 at 2:39 AM, Stephen Frost wrote: > * Peter Geoghegan (p...@bowt.ie) wrote: >> On Thu, Apr 26, 2018 at 10:39 AM, Robert Haas wrote: >> > I'm personally not very excited about making rules like "index pages >> > are more valuable than

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

On April 28, 2018 1:47:56 PM PDT, Tom Lane wrote: >Andres Freund writes: >> On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote: >>> I am thinking of it is a copy paste mistake as the other members >around the >>> initflags are of "bool" type or is there

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Greetings, On Sat, Apr 28, 2018 at 17:55 Andres Freund wrote: > > > On April 28, 2018 1:47:56 PM PDT, Tom Lane wrote: > >Andres Freund writes: > >> On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote: > >>> I am thinking of it is a

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Stephen Frost writes: > On Sat, Apr 28, 2018 at 17:55 Andres Freund wrote: >> Perhaps Steven could change dory's config so it rebuilds when idle? >> There's a setting for that... > Not at a sufficiently capable keyboard at the moment to do that, so I’ve >

Re: Toast issues with OldestXmin going backwards

> "Stephen" == Stephen Frost writes: Stephen> I tend to agree.. However, this isn't something that's been Stephen> happening a lot, from what I gather, Right now I can't prove it happens in the wild at all - I think I've ruled it out as an explanation for the original

Re: Postgres, fsync, and OSs (specifically linux)

On 28 April 2018 at 23:25, Simon Riggs wrote: > On 27 April 2018 at 15:28, Andres Freund wrote: > >> - Add a pre-checkpoint hook that checks for filesystem errors *after* >> fsyncing all the files, but *before* logging the checkpoint completion >>

Re: [HACKERS] Clock with Adaptive Replacement

On Sat, Apr 28, 2018 at 7:39 AM, Stephen Frost wrote: > Perhaps I'm misunderstanding the case here, but with the ring buffer we > use for sequential access, aren't we already discouraging keeping heap > pages around, particularly when they're coming from a sequential scan? > >

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Greetings, On Sat, Apr 28, 2018 at 18:23 Tom Lane wrote: > Stephen Frost writes: > > On Sat, Apr 28, 2018 at 17:55 Andres Freund wrote: > >> Perhaps Steven could change dory's config so it rebuilds when idle? > >> There's a setting

Re: Postgres, fsync, and OSs (specifically linux)

On 29 April 2018 at 00:15, Andres Freund wrote: > Hi, > > On 2018-04-28 08:25:53 -0700, Simon Riggs wrote: >> > - Use direct IO. Due to architectural performance issues in PG and the >> > fact that it'd not be applicable for all installations I don't think >> > this is a

Re: [RFC] Add an until-0 loop in psql

2018-04-28 21:25 GMT+02:00 Corey Huinker : > >> I did it too. It is not too hard - there was not a agreement on syntax. >> >> can be nice some like CTE >> >> WITH PROCEDURE x(a int, b int) AS ... $$ SELECT x(10); >> > > I've seen "WITH function" syntax in Oracle

Re: community bonding

Thanks for your comments, Craig! 2018-04-26 21:03 GMT-07:00 Craig Ringer : > On 24 April 2018 at 12:22, Charles Cui wrote: > > Hi PostgreSQL community and mentors: > > > > Thanks for selecting my project as one of GSoC student projects! Pretty >

RE: GSoC 2018: Sorting Algorithm and Benchmarking

Hey, I’ve joined the workspace. The username is Kefan Yang I agree we can create a channel for this project From: Andrey Borodin Sent: April 27, 2018 9:22 PM To: Kefan Yang Cc: PostgreSQL Hackers; Atri Sharma Subject: Re: GSoC 2018: Sorting Algorithm and Benchmarking > 27 апр. 2018 г., в

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

Stephen Frost writes: > On Sat, Apr 28, 2018 at 18:23 Tom Lane wrote: >> Actually, I was about to ask whether you guys had changed anything about >> dory's configuration recently. It's now had eight consecutive passes >> since I put in 63ca350 last night.