Re: OpenSSL 3.0.0 compatibility

2020-05-30 Thread Andrew Dunstan
On 5/28/20 6:16 PM, Daniel Gustafsson wrote: > > OpenSSL also deprecates DES keys in 3.0.0, which cause our password callback > tests to fail with the cryptic error "fetch failed", as the test suite keys > are > encrypted with DES. 0002 fixes this by changing to AES256 (randomly chosen > among

Re: OpenSSL 3.0.0 compatibility

2020-05-30 Thread Peter Eisentraut
On 2020-05-29 14:45, Daniel Gustafsson wrote: I think we should set OPENSSL_API_COMPAT=10001, and move that along with whatever our oldest supported release is going forward. That declares our intention, it will silence the deprecation warnings, and IIUC, if the deprecated stuff actually

Re: speed up unicode normalization quick check

2020-05-30 Thread John Naylor
On Sat, May 30, 2020 at 12:13 AM Mark Dilger wrote: > > > I forgot in my first round of code review to mention, "thanks for the patch". > I generally like what you are doing here, and am trying to review it so it > gets committed. And I forgot to say thanks for taking a look! > The reason I

Re: Inlining of couple of functions in pl_exec.c improves performance

2020-05-30 Thread Michael Paquier
On Sat, May 23, 2020 at 10:33:43PM +0530, Amit Khandekar wrote: > By inlining of the two functions, found noticeable reduction in > execution time as shown (figures are in milliseconds, averaged over > multiple runs; taken from 'explain analyze' execution times) : > ARM VM : >HEAD : 100 ;

Re: Read access for pg_monitor to pg_replication_origin_status view

2020-05-30 Thread Michael Paquier
On Fri, May 29, 2020 at 05:39:31PM -0300, Martín Marqués wrote: > I believe we could skip the superuser() check for cases like > pg_replication_origin_session_progress() and > pg_replication_origin_progress(). > > Once option could be to add a third bool argument check_superuser to >

Re: OpenSSL 3.0.0 compatibility

2020-05-30 Thread Michael Paquier
On Sat, May 30, 2020 at 11:29:11AM +0200, Peter Eisentraut wrote: > I'm not sure. I don't have a good sense of what OpenSSL versions we claim > to support in branches older than PG13. We made a conscious decision for > 1.0.1 in PG13, but I seem to recall that that discussion also revealed that >